26710 2009-06-24 23:47:53 -0700 [Qt] Qt needs Clipboard::files() implementation 2010-12-14 02:50:28 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 31332 1 eric webkit-qt-unassigned ben commit-queue jarred jesus kent.hansen kling robert oldest_to_newest 128105 0 eric 2009-06-24 23:47:53 -0700 [Qt] Qt needs Clipboard::files() implementation So that WebKit properly supports drag and drop of files onto web pages. See bug 25916 152126 1 ben 2009-10-03 21:50:41 -0700 Is there a test page for this feature? Is it suppose to return the file names ore the file contents? First pass: PassRefPtr<FileList> ClipboardQt::files() const { - notImplemented(); - return 0; + if (policy() != ClipboardReadable) + return FileList::create(); + + RefPtr<FileList> fileList = FileList::create(); + QList<QUrl> urls = m_readableData->urls(); + foreach (QUrl url, urls) { + if (url.scheme() != QLatin1String("file")) + continue; + fileList->append(File::create(url.toLocalFile())); + } + + return fileList.release(); } 153269 2 eric 2009-10-07 21:56:19 -0700 There are several tests. Qt's DumpRenderTree needs a eventSender.beginDragWithFiles implementation. There is a bug filed about Windows DumpRenderTree (bug 25924), but I don't see one for Qt yet. 317256 3 robert 2010-12-04 02:37:43 -0800 Currently drag'n'drop in Qt DRT is pretty much intractable, see https://bugs.webkit.org/show_bug.cgi?id=31332 320934 4 jarred 2010-12-12 21:23:51 -0800 Tests depend upon beginDragWithFiles implementation in DRT, so you can mark this bug as depending upon this one: https://bugs.webkit.org/show_bug.cgi?id=50902 320939 5 76352 jarred 2010-12-12 22:09:29 -0800 Created attachment 76352 Proposed patch 321794 6 ben 2010-12-14 01:40:10 -0800 yah! 321850 7 76352 commit-queue 2010-12-14 02:50:22 -0800 Comment on attachment 76352 Proposed patch Clearing flags on attachment: 76352 Committed r74009: <http://trac.webkit.org/changeset/74009> 321851 8 commit-queue 2010-12-14 02:50:28 -0800 All reviewed patches have been landed. Closing bug. 76352 2010-12-12 22:09:29 -0800 2010-12-14 02:50:22 -0800 Proposed patch clipboard-files.patch text/plain 1883 jarred ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTUzZDA5Yi4uNGQ2NzM1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMi0xMiAgSmFycmVkIE5pY2hv bGxzICA8amFycmVkQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUXQncyBDbGlwYm9hcmQ6OmZpbGVzKCkgaW1wbGVtZW50YXRpb24g Zm9yIEhUTUw1IERyYWcvRHJvcCAoRGF0YVRyYW5zZmVyKQorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gUnVuIHRlc3RzIG1hbnVhbGx5IHVudGlsIERSVCBpcyB1cGRhdGVkIHcvIGJlZ2luRHJhZ1dp dGhGaWxlcy4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L0NsaXBib2FyZFF0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNsaXBib2FyZFF0OjpmaWxlcyk6CisKIDIwMTAtMTItMTIgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhh biBMb3Blei4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ2xpcGJvYXJkUXQuY3Bw IGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DbGlwYm9hcmRRdC5jcHAKaW5kZXggMjBjZjYyYi4uYzE0 ZDM2MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DbGlwYm9hcmRRdC5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DbGlwYm9hcmRRdC5jcHAKQEAgLTIsNiArMiw3IEBACiAg KiBDb3B5cmlnaHQgKEMpIDIwMDcgQXBwbGUgSW5jLiAgQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAq IENvcHlyaWdodCAoQykgMjAwNiwgMjAwNyBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVk LgogICogQ29weXJpZ2h0IChDKSAyMDA4IE5va2lhIENvcnBvcmF0aW9uIGFuZC9vciBpdHMgc3Vi c2lkaWFyeSgtaWVzKQorICogQ29weXJpZ2h0IChDKSAyMDEwIFNlbmNoYSwgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFu ZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVy bWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0yMDQsOCAr MjA1LDIwIEBAIEhhc2hTZXQ8U3RyaW5nPiBDbGlwYm9hcmRRdDo6dHlwZXMoKSBjb25zdAogCiBQ YXNzUmVmUHRyPEZpbGVMaXN0PiBDbGlwYm9hcmRRdDo6ZmlsZXMoKSBjb25zdAogewotICAgIG5v dEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIDA7CisgICAgaWYgKHBvbGljeSgpICE9IENsaXBi b2FyZFJlYWRhYmxlIHx8ICFtX3JlYWRhYmxlRGF0YS0+aGFzVXJscygpKQorICAgICAgICByZXR1 cm4gRmlsZUxpc3Q6OmNyZWF0ZSgpOworCisgICAgUmVmUHRyPEZpbGVMaXN0PiBmaWxlTGlzdCA9 IEZpbGVMaXN0OjpjcmVhdGUoKTsKKyAgICBRTGlzdDxRVXJsPiB1cmxzID0gbV9yZWFkYWJsZURh dGEtPnVybHMoKTsKKworICAgIGZvciAoaW50IGkgPSAwOyBpIDwgdXJscy5zaXplKCk7IGkrKykg eworICAgICAgICBRVXJsIHVybCA9IHVybHNbaV07CisgICAgICAgIGlmICh1cmwuc2NoZW1lKCkg IT0gUUxhdGluMVN0cmluZygiZmlsZSIpKQorICAgICAgICAgICAgY29udGludWU7CisgICAgICAg IGZpbGVMaXN0LT5hcHBlbmQoRmlsZTo6Y3JlYXRlKHVybC50b0xvY2FsRmlsZSgpKSk7CisgICAg fQorCisgICAgcmV0dXJuIGZpbGVMaXN0LnJlbGVhc2UoKTsKIH0KIAogdm9pZCBDbGlwYm9hcmRR dDo6c2V0RHJhZ0ltYWdlKENhY2hlZEltYWdlKiBpbWFnZSwgY29uc3QgSW50UG9pbnQmIHBvaW50 KQo=