267085 2024-01-04 08:50:48 -0800 overflow: hidden prevents CSS Subgrid 2024-02-07 15:14:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering Safari 17 Mac (Apple Silicon) macOS 14 RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/44050 https://codesandbox.io/p/sandbox/zen-rhodes-mbse3s?file=%2FApp.svelte BrowserCompat, InRadar P2 Normal --- 1 darius sgill26 bfulgham jaffathecake karlcow sgill26 simon.fraser webkit-bug-importer zalan oldest_to_newest 2002969 0 darius 2024-01-04 08:50:48 -0800 Applying `overflow: hidden` to an element that also has `display: grid; grid-template-rows: subgrid` will result in the element acting as though it doesn't have subgrid applied... unlike in Firefox and Chrome where subgrid behaves as expected. Reproduced here: https://codesandbox.io/p/sandbox/zen-rhodes-mbse3s?file=%2FApp.svelte Marked this as Safari 17, but I've confirmed that it exists in Technology Preview (Release 185 (Safari 17.4, WebKit 19618.1.9.8)) too. Marked this as macOS 14 but I've observed this on macOS 13, iOS/iPadOS 16, and iOS/iPadOS 17 as well. ... Cards with rounded corners and overflow hidden are a [big element of our design on mux.com](https://share.cleanshot.com/pJD9nrFX), so I've been dying to use subgrid for a while. Unfortunately, this bug is preventing me from rolling it out, even behind a @supports flag, since I know it'll layout incorrectly on Safari. Let me know if there's more I can provide! Y'all are the best. Thanks for making the best browser engine ;) 2004450 1 webkit-bug-importer 2024-01-11 08:51:14 -0800 <rdar://problem/120848131> 2005440 2 sgill26 2024-01-16 16:17:58 -0800 I think the issue is that RenderElement::establishesIndependentFormattingContext() returns true if hasPotentiallyScrollableOverflow() returns true, but we also need to make sure that the box is a block box before we do that. The spec says: If the computed value of overflow on a block box is neither visible nor clip nor a combination thereof, it establishes an independent formatting context for its contents. https://drafts.csswg.org/css-overflow-3/#overflow-control 2005464 3 sgill26 2024-01-16 18:04:33 -0800 Pull request: https://github.com/WebKit/WebKit/pull/22845 2005608 4 sgill26 2024-01-17 09:52:25 -0800 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/44050 2005625 5 ews-feeder 2024-01-17 11:08:31 -0800 Committed 273134@main (78a954e5a2bd): <https://commits.webkit.org/273134@main> Reviewed commits have been landed. Closing PR #22845 and removing active labels. 2011559 6 sgill26 2024-02-07 15:14:15 -0800 *** Bug 268539 has been marked as a duplicate of this bug. ***