26704 2009-06-24 19:08:23 -0700 bugzilla-tool needs to invoke a specific build-webkit 2009-06-25 14:52:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned levin mrowe oldest_to_newest 128071 0 eric 2009-06-24 19:08:23 -0700 bugzilla-tool needs to invoke a specific build-webkit Currently it uses the one in your path. Which might be in a different webkit repository, which means you'll end up buildnig the wrong copy of WebKit. This is what caused the bad checkins today. :( It's also wrong to use the build-webkit in the path because not everyone will have build-webkit in their path. bugzilla-tool is cwd aware, it passes the cwd off to the SCM system and asks it if its a valid SCM checkout and if so, what the root directory of the checkout is. bugzilla-tool assumes whatever root directory you're in is a WebKit checkout. This allows me to have multiple webkit checkouts and make modifications to bugzilla-tool in one and test the modified version against other checkouts. 128276 1 31876 eric 2009-06-25 14:35:03 -0700 Created attachment 31876 Call WebKitTools/Scripts scripts by their absolute paths --- 3 files changed, 27 insertions(+), 6 deletions(-) 128280 2 31876 mrowe 2009-06-25 14:49:55 -0700 Comment on attachment 31876 Call WebKitTools/Scripts scripts by their absolute paths As mentioned on IRC, the leading underscore on _script_path is inconsistent with the convention used on other methods in the file. r=me 128281 3 eric 2009-06-25 14:52:27 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/scm.py Committed r45197 http://trac.webkit.org/changeset/45197 31876 2009-06-25 14:35:03 -0700 2009-06-25 14:49:55 -0700 Call WebKitTools/Scripts scripts by their absolute paths bugzilla_requires_a_filename.patch text/plain 3672 eric YjhhYzk0MGExYWE3NmY0NjQ5MGViNTdlYWM3NWM1NjcyZDUwMGM0MwpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDE5YzA2MTAu LmY3OGYyOTkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRU b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wNi0yNSAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2FsbCBXZWJLaXRUb29scy9TY3JpcHRzIHNjcmlwdHMgYnkgdGhlaXIgYWJz b2x1dGUgcGF0aHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI2NzA0CisKKyAgICAgICAgYnVnemlsbGEtdG9vbCB1c2VkIHRvIHVzZSB3aGF0ZXZlciBi dWlsZC13ZWJraXQgd2FzIGluIHlvdXIgcGF0aC4KKyAgICAgICAgVGhhdCBjb3VsZCBlbmQgdXAg YnVpbGRpbmcgdGhlIHdyb25nIGNvcHkgb2YgV2ViS2l0LgorCisgICAgICAgICogU2NyaXB0cy9i dWd6aWxsYS10b29sOgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9zY20ucHk6CisKIDIwMDkt MDYtMjUgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhdmUgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL2J1Z3ppbGxhLXRvb2wgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wK aW5kZXggNTIwNGFjZi4uOTliMWQzNiAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9i dWd6aWxsYS10b29sCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbApAQCAt MjM1LDE4ICsyMzUsMjMgQEAgY2xhc3MgTGFuZFBhdGNoZXNGcm9tQnVncyhDb21tYW5kKToKIAog ICAgIEBzdGF0aWNtZXRob2QKICAgICBkZWYgcnVuX2FuZF90aHJvd19pZl9mYWlsKHNjcmlwdF9u YW1lKToKLSAgICAgICAgYnVpbGRfd2Via2l0X3Byb2Nlc3MgPSBzdWJwcm9jZXNzLlBvcGVuKHNj cmlwdF9uYW1lLCBzaGVsbD1UcnVlKQorICAgICAgICBidWlsZF93ZWJraXRfcHJvY2VzcyA9IHN1 YnByb2Nlc3MuUG9wZW4oc2NyaXB0X25hbWUpCiAgICAgICAgIHJldHVybl9jb2RlID0gYnVpbGRf d2Via2l0X3Byb2Nlc3Mud2FpdCgpCiAgICAgICAgIGlmIHJldHVybl9jb2RlOgogICAgICAgICAg ICAgcmFpc2UgU2NyaXB0RXJyb3IoIiVzIGZhaWxlZCB3aXRoIGV4aXQgY29kZSAlZCIgJSAoc2Ny aXB0X25hbWUsIHJldHVybl9jb2RlKSkKIAogICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiBydW5f d2Via2l0X3NjcmlwdChjbHMsIHNjcmlwdF9uYW1lKToKKyAgICAgICAgIyBXZSBtaWdodCBuZWVk IHRvIHBhc3Mgc2NtIGludG8gdGhpcyBmdW5jdGlvbiBmb3Igc2NtLmNoZWNrb3V0X3Jvb3QKKyAg ICAgICAgY2xzLnJ1bl9hbmRfdGhyb3dfaWZfZmFpbChvcy5wYXRoLmpvaW4oIldlYktpdFRvb2xz IiwgIlNjcmlwdHMiLCBzY3JpcHRfbmFtZSkpCisKKyAgICBAY2xhc3NtZXRob2QKICAgICBkZWYg YnVpbGRfd2Via2l0KGNscyk6Ci0gICAgICAgIGNscy5ydW5fYW5kX3Rocm93X2lmX2ZhaWwoImJ1 aWxkLXdlYmtpdCIpCisgICAgICAgIGNscy5ydW5fd2Via2l0X3NjcmlwdCgiYnVpbGQtd2Via2l0 IikKIAogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBydW5fd2Via2l0X3Rlc3RzKGNscyk6Ci0g ICAgICAgIGNscy5ydW5fYW5kX3Rocm93X2lmX2ZhaWwoInJ1bi13ZWJraXQtdGVzdHMiKQorICAg ICAgICBjbHMucnVuX3dlYmtpdF9zY3JpcHQoInJ1bi13ZWJraXQtdGVzdHMiKQogCiAgICAgQHN0 YXRpY21ldGhvZAogICAgIGRlZiBzZXR1cF9mb3JfbGFuZGluZyhzY20sIG9wdGlvbnMpOgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weSBiL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy9zY20ucHkKaW5kZXggZGM4YTZkMy4uYmE3YjdjOCAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL21vZHVsZXMvc2NtLnB5CkBAIC03MCw2ICs3MCw5IEBAIGNsYXNzIFNDTToKICAgICAg ICAgICAgIHJldHVybiBleGl0X2NvZGUKICAgICAgICAgcmV0dXJuIG91dHB1dAogCisgICAgZGVm IF9zY3JpcHRfcGF0aChzZWxmLCBzY3JpcHRfbmFtZSk6CisgICAgICAgIHJldHVybiBvcy5wYXRo LmpvaW4oc2VsZi5jaGVja291dF9yb290LCAiV2ViS2l0VG9vbHMiLCAiU2NyaXB0cyIsIHNjcmlw dF9uYW1lKQorCiAgICAgZGVmIGVuc3VyZV9jbGVhbl93b3JraW5nX2RpcmVjdG9yeShzZWxmLCBm b3JjZSk6CiAgICAgICAgIGlmIG5vdCBmb3JjZSBhbmQgbm90IHNlbGYud29ya2luZ19kaXJlY3Rv cnlfaXNfY2xlYW4oKToKICAgICAgICAgICAgIHByaW50IHNlbGYucnVuX2NvbW1hbmQoc2VsZi5z dGF0dXNfY29tbWFuZCgpLCByYWlzZV9vbl9mYWlsdXJlPUZhbHNlKQpAQCAtOTIsNyArOTUsNyBA QCBjbGFzcyBTQ006CiAgICAgICAgICMgSXQncyBwb3NzaWJsZSB0aGF0IHRoZSBwYXRjaCB3YXMg bm90IG1hZGUgZnJvbSB0aGUgcm9vdCBkaXJlY3RvcnkuCiAgICAgICAgICMgV2Ugc2hvdWxkIGRl dGVjdCBhbmQgaGFuZGxlIHRoYXQgY2FzZS4KICAgICAgICAgY3VybF9wcm9jZXNzID0gc3VicHJv Y2Vzcy5Qb3BlbihbJ2N1cmwnLCBwYXRjaFsndXJsJ11dLCBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBF KQotICAgICAgICBwYXRjaF9hcHBseV9wcm9jZXNzID0gc3VicHJvY2Vzcy5Qb3BlbihbJ3N2bi1h cHBseScsICctLXJldmlld2VyJywgcGF0Y2hbJ3Jldmlld2VyJ11dLCBzdGRpbj1jdXJsX3Byb2Nl c3Muc3Rkb3V0KQorICAgICAgICBwYXRjaF9hcHBseV9wcm9jZXNzID0gc3VicHJvY2Vzcy5Qb3Bl bihbc2VsZi5fc2NyaXB0X3BhdGgoJ3N2bi1hcHBseScpLCAnLS1yZXZpZXdlcicsIHBhdGNoWydy ZXZpZXdlciddXSwgc3RkaW49Y3VybF9wcm9jZXNzLnN0ZG91dCkKIAogICAgICAgICByZXR1cm5f Y29kZSA9IHBhdGNoX2FwcGx5X3Byb2Nlc3Mud2FpdCgpCiAgICAgICAgIGlmIHJldHVybl9jb2Rl OgpAQCAtMTg4LDcgKzE5MSw3IEBAIGNsYXNzIFNWTihTQ00pOgogICAgICAgICBzZWxmLnJ1bl9j b21tYW5kKCJzdm4gcmVzZXQgLVIiKQogCiAgICAgZGVmIHVwZGF0ZV93ZWJraXQoc2VsZik6Ci0g ICAgICAgIHNlbGYucnVuX2NvbW1hbmQoInVwZGF0ZS13ZWJraXQiKQorICAgICAgICBzZWxmLnJ1 bl9jb21tYW5kKHNlbGYuX3NjcmlwdF9wYXRoKCJ1cGRhdGUtd2Via2l0IikpCiAKICAgICBkZWYg c3RhdHVzX2NvbW1hbmQoc2VsZik6CiAgICAgICAgIHJldHVybiAnc3ZuIHN0YXR1cycKQEAgLTIw Nyw3ICsyMTAsNyBAQCBjbGFzcyBTVk4oU0NNKToKICAgICAgICAgcmV0dXJuICJzdm4iCiAKICAg ICBkZWYgY3JlYXRlX3BhdGNoX2NvbW1hbmQoc2VsZik6Ci0gICAgICAgIHJldHVybiAic3ZuLWNy ZWF0ZS1wYXRjaCIKKyAgICAgICAgcmV0dXJuIHNlbGYuX3NjcmlwdF9wYXRoKCJzdm4tY3JlYXRl LXBhdGNoIikKIAogICAgIGRlZiBjb21taXRfd2l0aF9tZXNzYWdlKHNlbGYsIG1lc3NhZ2UpOgog ICAgICAgICBpZiBzZWxmLmRyeXJ1bjoK