267011 2024-01-02 16:19:44 -0800 [JSC] RegExp /u flag doesn't respect atomicity of surrogate pairs 2024-11-29 17:09:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=283840 InRadar P2 Normal --- 267593 1 ashvayka msaboff bfulgham schuyler webkit-bug-importer oldest_to_newest 2002645 0 ashvayka 2024-01-02 16:19:44 -0800 Simple test case: /\uDC9A$/u.exec("a💚") // \uDC9A being a trailing surrogate of 💚 Expected: null Actual: matches \uDC9A The bug is observed in both JIT and Interpreter, anywhere we match characters (another good example is negated character classes). Current logic allows us to end up in-between trailing and leading surrogate, producing false matches. Related test262 failures: * test/built-ins/RegExp/prototype/Symbol.search/u-lastindex-advance.js * test/built-ins/RegExp/prototype/Symbol.split/u-lastindex-adv-thru-failure.js * test/built-ins/RegExp/prototype/exec/u-lastindex-adv.js * test/language/literals/regexp/u-astral-char-class-invert.js 2002646 1 webkit-bug-importer 2024-01-02 16:20:01 -0800 <rdar://problem/120391451> 2004264 2 msaboff 2024-01-10 16:48:24 -0800 Pull request: https://github.com/WebKit/WebKit/pull/22631 2004509 3 ews-feeder 2024-01-11 11:17:40 -0800 Committed 272928@main (584a9a820ab2): <https://commits.webkit.org/272928@main> Reviewed commits have been landed. Closing PR #22631 and removing active labels. 2004687 4 ashvayka 2024-01-12 07:58:25 -0800 *** Bug 205477 has been marked as a duplicate of this bug. *** 2005296 5 msaboff 2024-01-16 10:36:44 -0800 The fix in 272928@main regressed performance in JetStream2 / UniPoker. Rolling this out to address the performance regression. 2005323 6 msaboff 2024-01-16 11:16:04 -0800 Fix with performance regression reverted in 273081@main (9d426c6ff391): <https://commits.webkit.org/273081@main> 2019368 7 bfulgham 2024-03-07 10:04:29 -0800 This is now being tracked as: <rdar://124217243> 2020556 8 msaboff 2024-03-12 13:47:13 -0700 Pull request: https://github.com/WebKit/WebKit/pull/25793 2020741 9 ews-feeder 2024-03-13 09:47:04 -0700 Committed 276031@main (67969c218ddf): <https://commits.webkit.org/276031@main> Reviewed commits have been landed. Closing PR #25793 and removing active labels.