26696 2009-06-24 15:26:05 -0700 Member functions in DataGridColumnList should return pointers instead of PassRefPtr 2009-06-24 15:48:31 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 levin levin oldest_to_newest 128017 0 levin 2009-06-24 15:26:05 -0700 The PassRefPtr is usually returned to indicate that the ref count is being passed and that isn't the case here. The class still maintains a ref count on these items. (Besides just that general idea, I'm doing this because it helps me get our autogenerated code for v8 bindings building.) 128018 1 31814 levin 2009-06-24 15:35:54 -0700 Created attachment 31814 Proposed fix. 128019 2 31814 hyatt 2009-06-24 15:38:06 -0700 Comment on attachment 31814 Proposed fix. r=me 128021 3 levin 2009-06-24 15:48:31 -0700 Committed as http://trac.webkit.org/changeset/45111 31814 2009-06-24 15:35:54 -0700 2009-06-24 15:38:06 -0700 Proposed fix. bug26696.txt text/plain 3894 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzNmZmIxMS4uNTQ3NDQ4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wNi0yNCAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQnVnIDI2Njk2OiBNZW1iZXIgZnVuY3Rpb25zIGluIERhdGFHcmlkQ29s dW1uTGlzdCBzaG91bGQgcmV0dXJuIHBvaW50ZXJzIGluc3RlYWQgb2YgUGFzc1JlZlB0ci4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2Njk2CisKKyAg ICAgICAgKiBodG1sL0RhdGFHcmlkQ29sdW1uTGlzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE YXRhR3JpZENvbHVtbkxpc3Q6Oml0ZW1XaXRoTmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpEYXRh R3JpZENvbHVtbkxpc3Q6OmFkZCk6CisgICAgICAgICogaHRtbC9EYXRhR3JpZENvbHVtbkxpc3Qu aDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFHcmlkQ29sdW1uTGlzdDo6aXRlbSk6CisgICAgICAg IChXZWJDb3JlOjpEYXRhR3JpZENvbHVtbkxpc3Q6OnByaW1hcnlDb2x1bW4pOgorICAgICAgICAo V2ViQ29yZTo6RGF0YUdyaWRDb2x1bW5MaXN0Ojpzb3J0Q29sdW1uKToKKwogMjAwOS0wNi0yNCAg U2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUg Ik1lc3N5IiBIeWF0dC4KQEAgLTk3LDcgKzExMiw3IEBACiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjM5MgogICAgICAgICBCdWcgMjYzOTI6IEluIGh0 bWwsIG1vZGlmaWNhdGlvbiBvZiB4bGluazpocmVmIG9mIGFuIG5ld2x5IGluc2VydGVkIHN2ZyBp bWFnZSBkb2VzIG5vdCB3b3JrLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjYzMjgKLSAgICAgICAgQnVnIDI2MzI4OiBjaGFuZ2luZyBocmVmIGF0dHJp YnV0ZSBvZiBzdmcgaW1hZ2VzIGRvd3Mgbm90IHdvcmsgd2hlbiBjaGFuZ2luZyBkaXNwbGF5IGF0 dHJpYnV0ZSBhcyB3ZWxsCisgICAgICAgIEJ1ZyAyNjMyODogY2hhbmdpbmcgaHJlZiBhdHRyaWJ1 dGUgb2Ygc3ZnIGltYWdlcyBkb2VzIG5vdCB3b3JrIHdoZW4gY2hhbmdpbmcgZGlzcGxheSBhdHRy aWJ1dGUgYXMgd2VsbAogCiAgICAgICAgIFJlYWN0IHRvIGhyZWYgdXBkYXRlcyBldmVuIHdoZW4g dGhlcmUgaXMgbm8gcmVuZGVyZXIsIGkuZS4gZGlzcGxheT1ub25lLgogCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2h0bWwvRGF0YUdyaWRDb2x1bW5MaXN0LmNwcCBiL1dlYkNvcmUvaHRtbC9EYXRhR3Jp ZENvbHVtbkxpc3QuY3BwCmluZGV4IDI4ZmM3MGEuLjQ4ZjdkNjAgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaHRtbC9EYXRhR3JpZENvbHVtbkxpc3QuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9EYXRhR3Jp ZENvbHVtbkxpc3QuY3BwCkBAIC0zNiwyMyArMzYsMjMgQEAgRGF0YUdyaWRDb2x1bW5MaXN0Ojp+ RGF0YUdyaWRDb2x1bW5MaXN0KCkKICAgICBjbGVhcigpOwogfQogCi1QYXNzUmVmUHRyPERhdGFH cmlkQ29sdW1uPiBEYXRhR3JpZENvbHVtbkxpc3Q6Oml0ZW1XaXRoTmFtZShjb25zdCBBdG9taWNT dHJpbmcmIG5hbWUpIGNvbnN0CitEYXRhR3JpZENvbHVtbiogRGF0YUdyaWRDb2x1bW5MaXN0Ojpp dGVtV2l0aE5hbWUoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lKSBjb25zdAogewogICAgIHVuc2ln bmVkIGxlbmd0aCA9IG1fY29sdW1ucy5zaXplKCk7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsg aSA8IGxlbmd0aDsgKytpKSB7CiAgICAgICAgIGlmIChtX2NvbHVtbnNbaV0tPmlkKCkgPT0gbmFt ZSkKLSAgICAgICAgICAgIHJldHVybiBtX2NvbHVtbnNbaV07CisgICAgICAgICAgICByZXR1cm4g bV9jb2x1bW5zW2ldLmdldCgpOwogICAgIH0KICAgICByZXR1cm4gMDsKIH0KIAotUGFzc1JlZlB0 cjxEYXRhR3JpZENvbHVtbj4gRGF0YUdyaWRDb2x1bW5MaXN0OjphZGQoY29uc3QgU3RyaW5nJiBp ZCwgY29uc3QgU3RyaW5nJiBsYWJlbCwgY29uc3QgU3RyaW5nJiB0eXBlLCBib29sIHByaW1hcnks IHVuc2lnbmVkIHNob3J0IHNvcnRhYmxlKQorRGF0YUdyaWRDb2x1bW4qIERhdGFHcmlkQ29sdW1u TGlzdDo6YWRkKGNvbnN0IFN0cmluZyYgaWQsIGNvbnN0IFN0cmluZyYgbGFiZWwsIGNvbnN0IFN0 cmluZyYgdHlwZSwgYm9vbCBwcmltYXJ5LCB1bnNpZ25lZCBzaG9ydCBzb3J0YWJsZSkKIHsKICAg ICBSZWZQdHI8RGF0YUdyaWRDb2x1bW4+IGNvbHVtbiA9IERhdGFHcmlkQ29sdW1uOjpjcmVhdGUo dGhpcywgaWQsIGxhYmVsLCB0eXBlLCBwcmltYXJ5LCBzb3J0YWJsZSk7CiAgICAgaWYgKHByaW1h cnkpCiAgICAgICAgIG1fcHJpbWFyeUNvbHVtbiA9IGNvbHVtbjsKICAgICBtX2NvbHVtbnMuYXBw ZW5kKGNvbHVtbik7Ci0gICAgcmV0dXJuIGNvbHVtbjsKKyAgICByZXR1cm4gY29sdW1uLmdldCgp OwogfQogCiB2b2lkIERhdGFHcmlkQ29sdW1uTGlzdDo6cmVtb3ZlKERhdGFHcmlkQ29sdW1uKiBj b2wpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvRGF0YUdyaWRDb2x1bW5MaXN0LmggYi9XZWJD b3JlL2h0bWwvRGF0YUdyaWRDb2x1bW5MaXN0LmgKaW5kZXggMjVkN2UzYi4uZDBjYWViZSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9odG1sL0RhdGFHcmlkQ29sdW1uTGlzdC5oCisrKyBiL1dlYkNvcmUv aHRtbC9EYXRhR3JpZENvbHVtbkxpc3QuaApAQCAtMjMsMTQgKzIzLDE0IEBAIHB1YmxpYzoKIAog ICAgIHVuc2lnbmVkIGxlbmd0aCgpIGNvbnN0IHsgcmV0dXJuIG1fY29sdW1ucy5zaXplKCk7IH0K IAotICAgIFBhc3NSZWZQdHI8RGF0YUdyaWRDb2x1bW4+IGl0ZW0odW5zaWduZWQgaW5kZXgpIGNv bnN0IHsgcmV0dXJuIG1fY29sdW1uc1tpbmRleF07IH0KLSAgICBQYXNzUmVmUHRyPERhdGFHcmlk Q29sdW1uPiBpdGVtV2l0aE5hbWUoY29uc3QgQXRvbWljU3RyaW5nJikgY29uc3Q7CisgICAgRGF0 YUdyaWRDb2x1bW4qIGl0ZW0odW5zaWduZWQgaW5kZXgpIGNvbnN0IHsgcmV0dXJuIG1fY29sdW1u c1tpbmRleF0uZ2V0KCk7IH0KKyAgICBEYXRhR3JpZENvbHVtbiogaXRlbVdpdGhOYW1lKGNvbnN0 IEF0b21pY1N0cmluZyYpIGNvbnN0OwogCi0gICAgUGFzc1JlZlB0cjxEYXRhR3JpZENvbHVtbj4g cHJpbWFyeUNvbHVtbigpIGNvbnN0IHsgcmV0dXJuIG1fcHJpbWFyeUNvbHVtbjsgfQorICAgIERh dGFHcmlkQ29sdW1uKiBwcmltYXJ5Q29sdW1uKCkgY29uc3QgeyByZXR1cm4gbV9wcmltYXJ5Q29s dW1uLmdldCgpOyB9CiAKLSAgICBQYXNzUmVmUHRyPERhdGFHcmlkQ29sdW1uPiBzb3J0Q29sdW1u KCkgY29uc3QgeyByZXR1cm4gbV9zb3J0Q29sdW1uOyB9CisgICAgRGF0YUdyaWRDb2x1bW4qIHNv cnRDb2x1bW4oKSBjb25zdCB7IHJldHVybiBtX3NvcnRDb2x1bW4uZ2V0KCk7IH0KIAotICAgIFBh c3NSZWZQdHI8RGF0YUdyaWRDb2x1bW4+IGFkZChjb25zdCBTdHJpbmcmIGlkLCBjb25zdCBTdHJp bmcmIGxhYmVsLCBjb25zdCBTdHJpbmcmIHR5cGUsIGJvb2wgcHJpbWFyeSwgdW5zaWduZWQgc2hv cnQgc29ydGFibGUpOworICAgIERhdGFHcmlkQ29sdW1uKiBhZGQoY29uc3QgU3RyaW5nJiBpZCwg Y29uc3QgU3RyaW5nJiBsYWJlbCwgY29uc3QgU3RyaW5nJiB0eXBlLCBib29sIHByaW1hcnksIHVu c2lnbmVkIHNob3J0IHNvcnRhYmxlKTsKICAgICB2b2lkIHJlbW92ZShEYXRhR3JpZENvbHVtbiop OwogICAgIHZvaWQgbW92ZShEYXRhR3JpZENvbHVtbiosIHVuc2lnbmVkIGxvbmcgaW5kZXgpOwog ICAgIHZvaWQgY2xlYXIoKTsK