266942 2023-12-30 16:59:11 -0800 generateWasm.py: return value can be wrong due IEEE 754 precision 2024-01-02 12:27:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build PC Linux RESOLVED FIXED https://github.com/WebKit/WebKit/pull/22270 InRadar P2 Normal --- 1 conrad+webkitbugzilla webkit-unassigned justin_michaud keith_miller mark.lam webkit-bug-importer oldest_to_newest 2002319 0 conrad+webkitbugzilla 2023-12-30 16:59:11 -0800 The assert function currently checks, if power number raised to the number fits memorybits. This seems not always work on every system, as it happens, that the float numbers are not correctly rounded. I suspect, that this is related to the IEEE 754 precision. It looks like, that 'math.log' always produced a float. This patch adds an int, so its being rounded to a full number and works on my system, where otherwise the rounding would fail. The return method also returns the result as an int. Example: * start python (tested with 3.11 and 3.12) $ import math $ 2 ** 3 = 8 $ 2.0 ** 3.0 = 7.999999999999999 $ int(2.0) ** int(3.0) = 8 $ 2 ** int(3.0) = 8 diff --git a/Source/JavaScriptCore/wasm/generateWasm.py b/Source/JavaScriptCore/wasm/generateWasm.py index 434223d346a0d..7a99210b60a21 100755 --- a/Source/JavaScriptCore/wasm/generateWasm.py +++ b/Source/JavaScriptCore/wasm/generateWasm.py @@ -136,5 +136,5 @@ def memoryLog2Alignment(op): if not match: print(op["name"]) memoryBits = int(match.group(2) if match.group(2) else match.group(1)) - assert 2 ** math.log(memoryBits, 2) == memoryBits + assert 2 ** int(math.log(memoryBits, 2)) == memoryBits return str(int(math.log(memoryBits / 8, 2))) 2002590 1 ews-feeder 2024-01-02 12:26:49 -0800 Committed 272577@main (509b303bf565): <https://commits.webkit.org/272577@main> Reviewed commits have been landed. Closing PR #22270 and removing active labels. 2002591 2 webkit-bug-importer 2024-01-02 12:27:18 -0800 <rdar://problem/120382432>