266897 2023-12-26 11:03:45 -0800 Exposing navigator.language to web workers 2024-01-02 11:04:14 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified NEW BrowserCompat, InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 webkit-unassigned ap cdumez heycam karlcow webkit-bug-importer oldest_to_newest 2002001 0 ahmad.saleem792 2023-12-26 11:03:45 -0800 Hi Team, While investigating WPT failures, I noticed that we fail two tests here: WPT Test Case: https://wpt.fyi/results/html/dom/idlharness.worker.html?label=master&label=experimental&aligned=&q=safari%3Afail > WorkerGlobalScope interface: attribute onlanguagechange > WorkerGlobalScope interface: self must inherit property "onlanguagechange" with the proper type WebKit / Safari is only browser currently failing these (so I will add 'BrowserCompat' tag - in addition to 'WPTImpact'). Blink Commit (for reference) - https://chromium.googlesource.com/chromium/src.git/+/6c688717fa4d50920ebcb0ab80e95023ff562656 FIXME in WebKit Source: https://searchfox.org/wubkat/rev/2cb2f84b68df8a519e252d535de43e7d19567883/Source/WebCore/workers/WorkerGlobalScope.idl#39 I didn't manage to find similar bug so I thought to raise for better tracking. Thanks! 2002002 1 ahmad.saleem792 2023-12-26 11:11:07 -0800 NOTE - just uncommenting in IDL file (FIXME) leads to test progression. So we might have already necessary implementation. Although, will wait for more context or input from others. 2002018 2 ap 2023-12-26 12:20:09 -0800 Language.cpp has some locking added for OffscreenCanvas thread safety, so Navigator.language may indeed be trivial to enable in workers at this point. Careful verification would still be needed, of course. However onlanguagechange clearly doesn't have an implementation, so uncommenting the line in IDL won't make it work. 2002565 3 webkit-bug-importer 2024-01-02 11:04:14 -0800 <rdar://problem/120378717>