266866 2023-12-24 09:48:30 -0800 Dash character in character range breaks <input> pattern regex 2023-12-25 07:27:52 -0800 1 1 1 Unclassified WebKit Forms Safari 17 Mac (Apple Silicon) macOS 14 RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=183361 BrowserCompat, InRadar P2 Major --- 1 webkit webkit-unassigned ahmad.saleem792 akeerthi annevk cdumez karlcow msaboff webkit-bug-importer webkit wenson_hsieh oldest_to_newest 2001822 0 webkit 2023-12-24 09:48:30 -0800 OVERVIEW When the regex of a <input> pattern contains a character range with a actual dash character (not a range operator), the validation for the form element is always true. Dash characters recognized as range operators are not an issue (like: [0-9]), only dash characters recognized as an actual character in a set (like: [0-9-]). This is a regression because it works as expected on older versions. Is similar to, if not same as: https://github.com/GoogleChrome/chromium-dashboard/issues/3106 STEPS TO REPRODUCE i = document.createElement('input'); i.value = 'asdf'; i.pattern = '^[0-9-]{4}$'; v1 = i.checkValidity(); // returns true instead of false i.pattern = '^[0-9]{4}$'; v2 = i.checkValidity(); // returns false as expected console.log(v1, v2); ACTUAL RESULTS Safari 17: true - false Safari 15: false - false EXPECTED RESULTS false - false 2001851 1 karlcow 2023-12-24 19:57:24 -0800 I wonder if it could be because of this change by Anne https://searchfox.org/wubkat/diff/092303e2abb1e89254f64b301953ac0fbf36c681/Source/WebCore/html/BaseTextInputType.cpp#43 2001852 2 webkit-bug-importer 2023-12-24 19:57:34 -0800 <rdar://problem/120106089> 2001911 3 annevk 2023-12-25 07:27:52 -0800 Hey Ian, thank you for reporting this. This is an intentional change in behavior: see bug 251675. You can fix this by escaping - as \\-, although if you set it from script you might need even more backslashes. I suspect \\\\-. As such closing this as INVALID.