26686 2009-06-24 11:22:43 -0700 Add using WTF:: statement to FastAllocBase and remove unnecessary scope usings 2009-06-24 18:32:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 26675 26676 26677 0 zoltan webkit-unassigned oldest_to_newest 127941 0 zoltan 2009-06-24 11:22:43 -0700 Based on Darin's comment ( https://bugs.webkit.org/show_bug.cgi?id=26675#c2 ), 1. I've extended FastAllocBase.h with using WTF::FastAllocBase to avoid unnecessary WTF:: usings; 2. I've removed the existing and unnecessary WTF:: usings. 127942 1 31792 zoltan 2009-06-24 11:23:10 -0700 Created attachment 31792 proposed patch 127969 2 31792 mjs 2009-06-24 12:17:01 -0700 Comment on attachment 31792 proposed patch r=me 128060 3 eric 2009-06-24 18:32:31 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/interpreter/Interpreter.h M JavaScriptCore/profiler/CallIdentifier.h M JavaScriptCore/runtime/ScopeChain.h M JavaScriptCore/wtf/FastAllocBase.h Committed r45130 http://trac.webkit.org/changeset/45130 31792 2009-06-24 11:23:10 -0700 2009-06-24 12:17:01 -0700 proposed patch Scope.patch text/plain 2708 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1MDg3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDYtMjQgIFpvbHRhbiBI b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXh0ZW5kIEZhc3RBbGxvY0Jhc2UuaCB3aXRoICd1 c2luZyBXVEY6OkZhc3RBbGxvY0Jhc2UnIHRvIGF2b2lkCisgICAgICAgIHVubmVjZXNzYXJ5IFdU Rjo6IHVzaW5ncy4KKyAgICAgICAgUmVtb3ZlIGV4aXN0aW5nIHVubmVjZXNzYXJ5IFdURjo6IHVz aW5ncy4KKworICAgICAgICAqIGludGVycHJldGVyL0ludGVycHJldGVyLmg6CisgICAgICAgICog cHJvZmlsZXIvQ2FsbElkZW50aWZpZXIuaDoKKyAgICAgICAgKiBydW50aW1lL1Njb3BlQ2hhaW4u aDoKKyAgICAgICAgKiB3dGYvRmFzdEFsbG9jQmFzZS5oOgorCiAyMDA5LTA2LTI0ICBab2x0YW4g SG9ydmF0aCAgPGh6b2x0YW5AaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE1hY2llaiBTdGFjaG93aWFrLgpJbmRleDogSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50 ZXJwcmV0ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRl cnByZXRlci5oCShyZXZpc2lvbiA0NTA4NykKKysrIEphdmFTY3JpcHRDb3JlL2ludGVycHJldGVy L0ludGVycHJldGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTY2LDcgKzY2LDcgQEAgbmFtZXNwYWNl IEpTQyB7CiAKICAgICBlbnVtIHsgTWF4TWFpblRocmVhZFJlZW50cnlEZXB0aCA9IDI1NiwgTWF4 U2Vjb25kYXJ5VGhyZWFkUmVlbnRyeURlcHRoID0gMzIgfTsKIAotICAgIGNsYXNzIEludGVycHJl dGVyIDogcHVibGljIFdURjo6RmFzdEFsbG9jQmFzZSB7CisgICAgY2xhc3MgSW50ZXJwcmV0ZXIg OiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiAgICAgICAgIGZyaWVuZCBjbGFzcyBKSVQ7CiAgICAg ICAgIGZyaWVuZCBjbGFzcyBDYWNoZWRDYWxsOwogICAgIHB1YmxpYzoKSW5kZXg6IEphdmFTY3Jp cHRDb3JlL3Byb2ZpbGVyL0NhbGxJZGVudGlmaWVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlw dENvcmUvcHJvZmlsZXIvQ2FsbElkZW50aWZpZXIuaAkocmV2aXNpb24gNDUwODcpCisrKyBKYXZh U2NyaXB0Q29yZS9wcm9maWxlci9DYWxsSWRlbnRpZmllci5oCSh3b3JraW5nIGNvcHkpCkBAIC0z Miw3ICszMiw3IEBACiAKIG5hbWVzcGFjZSBKU0MgewogCi0gICAgc3RydWN0IENhbGxJZGVudGlm aWVyIDogcHVibGljIFdURjo6RmFzdEFsbG9jQmFzZSB7CisgICAgc3RydWN0IENhbGxJZGVudGlm aWVyIDogcHVibGljIEZhc3RBbGxvY0Jhc2UgewogICAgICAgICBVU3RyaW5nIG1fbmFtZTsKICAg ICAgICAgVVN0cmluZyBtX3VybDsKICAgICAgICAgdW5zaWduZWQgbV9saW5lTnVtYmVyOwpJbmRl eDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9TY29wZUNoYWluLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUvcnVudGltZS9TY29wZUNoYWluLmgJKHJldmlzaW9uIDQ1MDg3KQorKysgSmF2 YVNjcmlwdENvcmUvcnVudGltZS9TY29wZUNoYWluLmgJKHdvcmtpbmcgY29weSkKQEAgLTMwLDcg KzMwLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgY2xhc3MgSlNPYmplY3Q7CiAgICAgY2xhc3Mg U2NvcGVDaGFpbkl0ZXJhdG9yOwogICAgIAotICAgIGNsYXNzIFNjb3BlQ2hhaW5Ob2RlIDogcHVi bGljIFdURjo6RmFzdEFsbG9jQmFzZSB7CisgICAgY2xhc3MgU2NvcGVDaGFpbk5vZGUgOiBwdWJs aWMgRmFzdEFsbG9jQmFzZSB7CiAgICAgcHVibGljOgogICAgICAgICBTY29wZUNoYWluTm9kZShT Y29wZUNoYWluTm9kZSogbmV4dCwgSlNPYmplY3QqIG9iamVjdCwgSlNHbG9iYWxEYXRhKiBnbG9i YWxEYXRhLCBKU09iamVjdCogZ2xvYmFsVGhpcykKICAgICAgICAgICAgIDogbmV4dChuZXh0KQpJ bmRleDogSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RBbGxvY0Jhc2UuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvRmFzdEFsbG9jQmFzZS5oCShyZXZpc2lvbiA0NTA4NykKKysrIEph dmFTY3JpcHRDb3JlL3d0Zi9GYXN0QWxsb2NCYXNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTM5Nyw0 ICszOTcsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogfSAvLyBuYW1lc3BhY2UgV1RGCiAKKy8vIFVz aW5nIFdURjo6RmFzdEFsbG9jQmFzZSB0byBhdm9pZCB1c2luZyBGYXN0QWxsb2NCYXNlJ3MgZXhw bGljaXQgcXVhbGlmaWNhdGlvbiBieSBXVEY6Oi4KK3VzaW5nIFdURjo6RmFzdEFsbG9jQmFzZTsK KwogI2VuZGlmIC8vIEZhc3RBbGxvY0Jhc2VfaAo=