26681 2009-06-24 08:36:47 -0700 Problem updating applicationCache when server returns 304 2010-08-12 13:49:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows Server 2003 RESOLVED FIXED http://new.efficientcoder.net/2009/06/webkitsafari-application-cache-work.html InRadar P2 Normal --- 1 kevinw ap ap laszlo.gombos oldest_to_newest 127917 0 kevinw 2009-06-24 08:36:47 -0700 1) Configure an application to use a manifest and window.applicationCache 2) Download initial cache, everythings works fine. Server returns an ETag or Last-Modified date within the header. Also has headers to disable cacheing. 3) Cache is updated, but the one or more of the resources aren't 4) WebKit requests a resource sending up If-Modified-Since and If-None-Match header headers. 5) Server returns a 304 Not Modified. 6) WebKit makes another request (goes back to step 4) this process will go on in an infinite loop. You can see a more detailed overview at: http://new.efficientcoder.net/2009/06/webkitsafari-application-cache-work.html 127958 1 mrowe 2009-06-24 12:03:06 -0700 <rdar://problem/7003461> 128137 2 ap 2009-06-25 02:20:40 -0700 From code inspection, looks like we fail to call m_pendingEntries.remove() in ApplicationCacheGroup::didReceiveResponse() for 304 responses. 128183 3 31855 ap 2009-06-25 07:24:23 -0700 Created attachment 31855 proposed fix 128383 4 ap 2009-06-25 21:46:40 -0700 Committed <http://trac.webkit.org/changeset/45247>. I've slightly changed the code to look more like other code paths. 128479 5 ap 2009-06-26 06:18:50 -0700 Tiger buildbot says this isn't quite fixed. 128480 6 31930 ap 2009-06-26 06:23:14 -0700 Created attachment 31930 improve the fix 128539 7 ap 2009-06-26 12:39:33 -0700 Committed <http://trac.webkit.org/changeset/45275>. 31855 2009-06-25 07:24:23 -0700 2009-06-25 11:59:37 -0700 proposed fix Appcache304Resource.txt text/plain 3844 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTE3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMDktMDYtMjUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjY4MQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNzAwMzQ2MT4gUHJvYmxlbSB1cGRhdGluZyBhcHBsaWNhdGlvbkNhY2hl IHdoZW4gc2VydmVyIHJldHVybnMgMzA0CisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0cy9hcHBj YWNoZS91cGRhdGUtY2FjaGUuaHRtbAorCisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxp Y2F0aW9uQ2FjaGVHcm91cC5jcHA6IChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlR3JvdXA6OmRp ZFJlY2VpdmVSZXNwb25zZSk6CisgICAgICAgIFdlJ3JlIGFscmVhZHkgZG9uZSB3aXRoIHRoZSBy ZXNvdXJjZSwgZG9uJ3QgdHJ5IHRvIGxvYWQgaXQgYWdhaW4uCisKKzIwMDktMDYtMjUgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2Fj aGVHcm91cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlR3JvdXA6OmRp ZFJlY2VpdmVSZXNwb25zZSk6CisKIDIwMDktMDYtMjUgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBl Y2swMkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFuIEFsb256by4KSW5kZXg6 IFdlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3VwLmNw cAkocmV2aXNpb24gNDQ5NzUpCisrKyBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlv bkNhY2hlR3JvdXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTAsNiArNDUwLDcgQEAgdm9pZCBB cHBsaWNhdGlvbkNhY2hlR3JvdXA6OmRpZFJlY2VpdmVSZQogICAgICAgICBpZiAobmV3ZXN0Q2Fj aGVkUmVzb3VyY2UpIHsKICAgICAgICAgICAgIG1fY2FjaGVCZWluZ1VwZGF0ZWQtPmFkZFJlc291 cmNlKEFwcGxpY2F0aW9uQ2FjaGVSZXNvdXJjZTo6Y3JlYXRlKHVybCwgbmV3ZXN0Q2FjaGVkUmVz b3VyY2UtPnJlc3BvbnNlKCksIHR5cGUsIG5ld2VzdENhY2hlZFJlc291cmNlLT5kYXRhKCkpKTsK ICAgICAgICAgICAgIG1fY3VycmVudEhhbmRsZS0+Y2FuY2VsKCk7CisgICAgICAgICAgICBtX3Bl bmRpbmdFbnRyaWVzLnJlbW92ZShtX2N1cnJlbnRIYW5kbGUtPnJlcXVlc3QoKS51cmwoKSk7CiAg ICAgICAgICAgICBtX2N1cnJlbnRIYW5kbGUgPSAwOwogICAgICAgICAgICAgLy8gTG9hZCB0aGUg bmV4dCByZXNvdXJjZSwgaWYgYW55LgogICAgICAgICAgICAgc3RhcnRMb2FkaW5nRW50cnkoKTsK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ1MTc1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDYtMjUgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjY4 MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzAwMzQ2MT4gUHJvYmxlbSB1cGRhdGluZyBhcHBs aWNhdGlvbkNhY2hlIHdoZW4gc2VydmVyIHJldHVybnMgMzA0CisKKyAgICAgICAgKiBodHRwL3Rl c3RzL2FwcGNhY2hlL3Jlc291cmNlcy91bmNhY2hlYWJsZS1yZXNvdXJjZS5waHA6IEFkZGVkLgor ICAgICAgICAqIGh0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL3ZlcnNpb25lZC1tYW5pZmVz dC5waHA6CisgICAgICAgIEFkZGVkIHRoZSBraW5kIG9mIHJlc291cmNlIHRoYXQgd2FzIGNhdXNp bmcgdHJvdWJsZS4KKwogMjAwOS0wNi0yNSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgTm8gcmV2aWV3LCBqdXN0IHNraXBwaW5nIGEgbmV3IHRlc3QuCkluZGV4OiBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy91bmNhY2hlYWJsZS1yZXNv dXJjZS5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9y ZXNvdXJjZXMvdW5jYWNoZWFibGUtcmVzb3VyY2UucGhwCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvdW5jYWNoZWFibGUtcmVzb3VyY2Uu cGhwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEzIEBACis8P3BocAorIyBUaGlzIHJlc291cmNl IHdvbid0IGJlIGNhY2hlZCBieSBuZXR3b3JrIGxheWVyLCBidXQgd2lsbCBiZSBjYWNoZWQgYnkg YXBwY2FjaGUuCitoZWFkZXIoIkxhc3QtTW9kaWZpZWQ6IFRodSwgMDEgRGVjIDIwMDMgMTY6MDA6 MDAgR01UIik7CitoZWFkZXIoIkV4cGlyZXM6IFRodSwgMDEgRGVjIDIwMDMgMTY6MDA6MDAgR01U Iik7CitoZWFkZXIoIkNhY2hlLUNvbnRyb2w6IG5vLWNhY2hlLCBuby1zdG9yZSIpOworaGVhZGVy KCJQcmFnbWE6IG5vLWNhY2hlIik7CitoZWFkZXIoIkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbiIp OworCitpZiAoJF9TRVJWRVJbJ0hUVFBfSUZfTU9ESUZJRURfU0lOQ0UnXSB8fCAkX1NFUlZFUlsn SFRUUF9JRl9OT05FX01BVENIJ10pCisgICAgaGVhZGVyKCJIVFRQLzEuMSAzMDQgTm90IE1vZGlm aWVkIik7CitlbHNlCisgICAgcHJpbnQoIkhlbGxvLCB3b3JsZCFcbiIpOworPz4KSW5kZXg6IExh eW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL3ZlcnNpb25lZC1tYW5pZmVz dC5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9yZXNv dXJjZXMvdmVyc2lvbmVkLW1hbmlmZXN0LnBocAkocmV2aXNpb24gNDQ5NzUpCisrKyBMYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy92ZXJzaW9uZWQtbWFuaWZlc3QucGhw CSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw3IEBAIGlmICgic3RlcCIgPT0gJF9HRVRbJ2Nv bW1hbmQnXSkKIHByaW50KCJDQUNIRSBNQU5JRkVTVFxuIik7CiBwcmludCgiIyB2ZXJzaW9uICIg LiBnZXRDb3VudCgkdG1wRmlsZSkgLiAiXG4iKTsKIHByaW50KCJjb3VudGVyLnBocFxuIik7Citw cmludCgidW5jYWNoZWFibGUtcmVzb3VyY2UucGhwXG4iKTsgLy8gd2l0aCBDYWNoZS1jb250cm9s OiBuby1zdG9yZQogcHJpbnQoIk5FVFdPUks6XG4iKTsKIHByaW50KCJ2ZXJzaW9uZWQtbWFuaWZl c3QucGhwP2NvbW1hbmQ9XG4iKTsKID8+Cg== 31930 2009-06-26 06:23:14 -0700 2009-06-26 10:50:12 -0700 improve the fix Appcache304-2.txt text/plain 2636 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTI1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDYtMjYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjY4MQorICAgICAgICBQ cm9ibGVtIHVwZGF0aW5nIGFwcGxpY2F0aW9uQ2FjaGUgd2hlbiBzZXJ2ZXIgcmV0dXJucyAzMDQK KyAgICAgICAgCisgICAgICAgIEltcHJvdmUgdGhlIGZpeCwgbWFrZSB0aGUgdGVzdCBwYXNzIG9u IFRpZ2VyLgorCisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91 cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlR3JvdXA6OmRpZFJlY2Vp dmVSZXNwb25zZSk6IEZpeCBhbm90aGVyIGNvZGUgcGF0aCB0byByZW1vdmUgdGhlCisgICAgICAg IGN1cnJlbnQgaXRlbSBmcm9tIGxpc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21h Yy9SZXNvdXJjZUhhbmRsZU1hYy5tbTogKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpzdGFydCk6 IE9uIFRpZ2VyLAorICAgICAgICBjb25kaXRpb25hbCByZXF1ZXN0cyB0aGF0IGNhbm5vdCBiZSBj YWNoZWQgYnkgbmV0d29yayBsYXllciBjYXVzZSBlcnJvcnMgd2l0aCBkZWZhdWx0IGNhY2hlCisg ICAgICAgIHBvbGljeS4KKwogMjAwOS0wNi0yNiAgWW9uZ2p1biBaaGFuZyAgPHlvbmdqdW4uemhh bmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDog V2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3VwLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlR3JvdXAuY3Bw CShyZXZpc2lvbiA0NTI1OSkKKysrIFdlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9u Q2FjaGVHcm91cC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3OSw2ICs0NzksNyBAQCB2b2lkIEFw cGxpY2F0aW9uQ2FjaGVHcm91cDo6ZGlkUmVjZWl2ZVJlCiAgICAgICAgICAgICBtX2NhY2hlQmVp bmdVcGRhdGVkLT5hZGRSZXNvdXJjZShBcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2U6OmNyZWF0ZSh1 cmwsIG5ld2VzdENhY2hlZFJlc291cmNlLT5yZXNwb25zZSgpLCB0eXBlLCBuZXdlc3RDYWNoZWRS ZXNvdXJjZS0+ZGF0YSgpKSk7CiAgICAgICAgICAgICBtX2N1cnJlbnRIYW5kbGUtPmNhbmNlbCgp OwogICAgICAgICAgICAgbV9jdXJyZW50SGFuZGxlID0gMDsKKyAgICAgICAgICAgIG1fcGVuZGlu Z0VudHJpZXMucmVtb3ZlKGhhbmRsZS0+cmVxdWVzdCgpLnVybCgpKTsKICAgICAgICAgICAgIC8v IExvYWQgdGhlIG5leHQgcmVzb3VyY2UsIGlmIGFueS4KICAgICAgICAgICAgIHN0YXJ0TG9hZGlu Z0VudHJ5KCk7CiAgICAgICAgIH0KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMv UmVzb3VyY2VIYW5kbGVNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbQkocmV2aXNpb24gNDUyNTkpCisrKyBXZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xODIsNiArMTgyLDEzIEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0KEZyYW1lKiBm cmFtZSkKICAgICBpZiAoIVJlc291cmNlSGFuZGxlOjpkaWRTZW5kQm9keURhdGFEZWxlZ2F0ZUV4 aXN0cygpKQogICAgICAgICBhc3NvY2lhdGVTdHJlYW1XaXRoUmVzb3VyY2VIYW5kbGUoW2QtPm1f cmVxdWVzdC5uc1VSTFJlcXVlc3QoKSBIVFRQQm9keVN0cmVhbV0sIHRoaXMpOwogCisjaWZkZWYg QlVJTERJTkdfT05fVElHRVIKKyAgICAvLyBBIGNvbmRpdGlvbmFsIHJlcXVlc3Qgc2VudCBieSBX ZWJDb3JlIChlLmcuIHRvIHVwZGF0ZSBhcHBjYWNoZSkgY2FuIGJlIGZvciBhIHJlc291cmNlIHRo YXQgaXMgbm90IGNhY2hlYWJsZSBieSBOU1VSTENvbm5lY3Rpb24sCisgICAgLy8gd2hpY2ggY2Fu IGdldCBjb25mdXNlZCBhbmQgZmFpbCB0byBsb2FkIGl0IGluIHRoaXMgY2FzZS4KKyAgICBpZiAo ZC0+bV9yZXF1ZXN0LmlzQ29uZGl0aW9uYWwoKSkKKyAgICAgICAgZC0+bV9yZXF1ZXN0LnNldENh Y2hlUG9saWN5KFJlbG9hZElnbm9yaW5nQ2FjaGVEYXRhKTsKKyNlbmRpZgorCiAgICAgZC0+bV9u ZWVkc1NpdGVTcGVjaWZpY1F1aXJrcyA9IGZyYW1lLT5zZXR0aW5ncygpICYmIGZyYW1lLT5zZXR0 aW5ncygpLT5uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcygpOwogCiAgICAgTlNVUkxDb25uZWN0aW9u ICpjb25uZWN0aW9uOwo=