26675 2009-06-24 05:10:52 -0700 Allow custom memory allocation control for JavaScriptCore's Register class 2009-06-24 18:10:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 26686 0 zoltan webkit-unassigned oldest_to_newest 127895 0 zoltan 2009-06-24 05:10:52 -0700 Inherits Register class from FastAllocBase because it has been instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149. 127896 1 31782 zoltan 2009-06-24 05:14:37 -0700 Created attachment 31782 proposed patch 127932 2 31782 darin 2009-06-24 09:54:23 -0700 Comment on attachment 31782 proposed patch Explicit qualification by WTF:: should not be necessary. The pattern in WTF is that we put "using" statements into the files. It's a bit unusual for C++ code but I've been convinced by the other WTF developers that it's the right pattern. So we should patch FastAllocBase to include: using WTF::FastAllocBase; And call the class just FastAllocBase everywhere we use it. 127943 3 31793 zoltan 2009-06-24 11:25:41 -0700 Created attachment 31793 updated proposed patch 127947 4 zoltan 2009-06-24 11:33:28 -0700 I've filed a bug #26686 with FastAllocBase.h modifications and unnecessary WTF:: removes. I've updated my uploaded bugs also: bug #26676 ; bug #26677 and this also. 127966 5 31793 mjs 2009-06-24 12:15:51 -0700 Comment on attachment 31793 updated proposed patch r=me 128034 6 eric 2009-06-24 16:54:29 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/interpreter/Register.h Committed r45121 http://trac.webkit.org/changeset/45121 128052 7 levin 2009-06-24 18:10:06 -0700 This patch need a fix to build: http://trac.webkit.org/changeset/45128 31782 2009-06-24 05:14:37 -0700 2009-06-24 11:25:41 -0700 proposed patch Register.patch text/plain 1092 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1MDc5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDYtMjQgIFpvbHRhbiBI b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjY2NzUKKworICAgICAgICBJbmhlcml0cyBSZWdpc3RlciBjbGFz cyBmcm9tIEZhc3RBbGxvY0Jhc2UgYmVjYXVzZSBpdCBoYXMgYmVlbgorICAgICAgICBpbnN0YW50 aWF0ZWQgYnkgJ25ldycgaW4gSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1ZhcmlhYmxlT2JqZWN0 Lmg6MTQ5LgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvUmVnaXN0ZXIuaDoKKwogMjAwOS0wNi0y NCAgWm9sdGFuIEhvcnZhdGggIDxoem9sdGFuQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2ludGVy cHJldGVyL1JlZ2lzdGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0 ZXIvUmVnaXN0ZXIuaAkocmV2aXNpb24gNDUwNzkpCisrKyBKYXZhU2NyaXB0Q29yZS9pbnRlcnBy ZXRlci9SZWdpc3Rlci5oCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw3ICs0Nyw3IEBAIG5hbWVzcGFj ZSBKU0MgewogCiAgICAgdHlwZWRlZiBFeGVjU3RhdGUgQ2FsbEZyYW1lOwogCi0gICAgY2xhc3Mg UmVnaXN0ZXIgeworICAgIGNsYXNzIFJlZ2lzdGVyIDogcHVibGljIFdURjo6RmFzdEFsbG9jQmFz ZSB7CiAgICAgcHVibGljOgogICAgICAgICBSZWdpc3RlcigpOwogICAgICAgICBSZWdpc3RlcihK U1ZhbHVlKTsK 31793 2009-06-24 11:25:41 -0700 2009-06-24 12:15:51 -0700 updated proposed patch Register.patch text/plain 1087 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1MDc5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDYtMjQgIFpvbHRhbiBI b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjY2NzUKKworICAgICAgICBJbmhlcml0cyBSZWdpc3RlciBjbGFz cyBmcm9tIEZhc3RBbGxvY0Jhc2UgYmVjYXVzZSBpdCBoYXMgYmVlbgorICAgICAgICBpbnN0YW50 aWF0ZWQgYnkgJ25ldycgaW4gSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1ZhcmlhYmxlT2JqZWN0 Lmg6MTQ5LgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvUmVnaXN0ZXIuaDoKKwogMjAwOS0wNi0y NCAgWm9sdGFuIEhvcnZhdGggIDxoem9sdGFuQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2ludGVy cHJldGVyL1JlZ2lzdGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0 ZXIvUmVnaXN0ZXIuaAkocmV2aXNpb24gNDUwNzkpCisrKyBKYXZhU2NyaXB0Q29yZS9pbnRlcnBy ZXRlci9SZWdpc3Rlci5oCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw3ICs0Nyw3IEBAIG5hbWVzcGFj ZSBKU0MgewogCiAgICAgdHlwZWRlZiBFeGVjU3RhdGUgQ2FsbEZyYW1lOwogCi0gICAgY2xhc3Mg UmVnaXN0ZXIgeworICAgIGNsYXNzIFJlZ2lzdGVyIDogcHVibGljIEZhc3RBbGxvY0Jhc2Ugewog ICAgIHB1YmxpYzoKICAgICAgICAgUmVnaXN0ZXIoKTsKICAgICAgICAgUmVnaXN0ZXIoSlNWYWx1 ZSk7Cg==