26670 2009-06-23 19:49:23 -0700 [Win] REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page 2009-07-02 16:56:41 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All Windows Vista RESOLVED FIXED InRadar P2 Normal --- 1 alice.barraclough oliver hyatt jhoneycutt oliver oldest_to_newest 127796 0 alice.barraclough 2009-06-23 19:49:23 -0700 * SUMMARY If I search for something on Google, then click the back button, I am often shown a "non-interactive" Google - i.e., it behaves like a screenshot of Google. * STEPS TO REPRODUCE (using Safari 4.0 on Windows) 1. Open http://www.google.com/ 2. Type "test" into the search field 3. If Google Suggest comes up, dismiss it by clicking outside of the search field 4. Click the "Google Search" button to search 5. Click the "Back" button in Safari * RESULTS Often, I am given a "non-interactive" page, as if it were just a screenshot of the Google page. * NOTES I can't get this to reproduce if, instead of step 3, I click a search term in Google suggest or click the "Google Search" button in the Google Suggest window - only if I dismiss the search suggestions. Refreshing the page causes Google to load properly. 127797 1 31766 alice.barraclough 2009-06-23 19:50:48 -0700 Created attachment 31766 patch authored by oliver Posting Oliver Hunt's patch for this bug. 127798 2 alice.barraclough 2009-06-23 19:51:32 -0700 <rdar://problem/6939593> 127808 3 mjs 2009-06-23 20:49:04 -0700 Patch needs a ChangeLog, and ideally some form of test case. 127809 4 mjs 2009-06-23 20:50:11 -0700 (I can't tell if the concepts of the patch are correct on the substance.) 129566 5 31766 hyatt 2009-07-02 13:51:32 -0700 Comment on attachment 31766 patch authored by oliver Why is the setNeedsLayout() necessary? I'd have thought the forceLayout would take care of that. 129629 6 32211 oliver 2009-07-02 16:51:13 -0700 Created attachment 32211 fix with changelog 129630 7 32211 andersca 2009-07-02 16:51:59 -0700 Comment on attachment 32211 fix with changelog r=me 129634 8 oliver 2009-07-02 16:56:41 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/win/ChangeLog M WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp Committed r45508 31766 2009-06-23 19:50:48 -0700 2009-07-02 16:51:13 -0700 patch authored by oliver 0001-Patch-to-make-Windows-WebFrameLoaderClient-forceLayo.patch text/plain 1308 alice.barraclough RnJvbSA1MDg2NjZkZWE1NTE3YmU3ZmU5MTQxYzkwMDNlZDliNzJjNjllNDQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogVHVlLCAyIEp1biAyMDA5IDAxOjA0OjM4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gUGF0 Y2ggdG8gbWFrZSBXaW5kb3dzIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojpmb3JjZUxheW91dCgpIGJl aGF2ZSBtb3JlIGxpa2UgTWFjJ3MuCgotLS0KIFdlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVMb2FkZXJDbGllbnQuY3BwIHwgICAxNiArKysrKysrKysrKysrLS0tCiAxIGZpbGVzIGNo YW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAgYi9XZWJLaXQv d2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAppbmRleCBkN2Y4ODRk Li4wYTZhYzMxIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1l TG9hZGVyQ2xpZW50LmNwcAorKysgYi9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1l TG9hZGVyQ2xpZW50LmNwcApAQCAtOTQsOSArOTQsMTkgQEAgYm9vbCBXZWJGcmFtZUxvYWRlckNs aWVudDo6aGFzV2ViVmlldygpIGNvbnN0CiAKIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmZv cmNlTGF5b3V0KCkKIHsKLSAgICBGcmFtZVZpZXcqIHZpZXcgPSBjb3JlKG1fd2ViRnJhbWUpLT52 aWV3KCk7Ci0gICAgaWYgKHZpZXcpCi0gICAgICAgIHZpZXctPmZvcmNlTGF5b3V0KHRydWUpOwor ICAgIEZyYW1lKiBmcmFtZSA9IGNvcmUobV93ZWJGcmFtZSk7CisgICAgaWYgKCFmcmFtZSkKKyAg ICAgICAgcmV0dXJuOworCisgICAgaWYgKGZyYW1lLT5kb2N1bWVudCgpICYmIGZyYW1lLT5kb2N1 bWVudCgpLT5pblBhZ2VDYWNoZSgpKQorICAgICAgICByZXR1cm47CisKKyAgICBGcmFtZVZpZXcq IHZpZXcgPSBmcmFtZS0+dmlldygpOworICAgIGlmICghdmlldykKKyAgICAgICAgcmV0dXJuOwor CisgICAgdmlldy0+c2V0TmVlZHNMYXlvdXQoKTsKKyAgICB2aWV3LT5mb3JjZUxheW91dCh0cnVl KTsKIH0KIAogdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6YXNzaWduSWRlbnRpZmllclRvSW5p dGlhbFJlcXVlc3QodW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBEb2N1bWVudExvYWRlciogbG9h ZGVyLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCi0tIAoxLjYuMy5kaXJ0eQoK 32211 2009-07-02 16:51:13 -0700 2009-07-02 16:51:59 -0700 fix with changelog google-back.patch text/plain 1644 oliver ZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vQ2hhbmdlTG9nIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK aW5kZXggYTlmMDBmZC4uNzViOTdkYSAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNy0wMiAg T2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82OTM5NTkzPiBSRUdSRVNT SU9OIChyMzc3OTMpOiBIaXR0aW5nIGJhY2sgYnV0dG9uIG9uIEdvb2dsZSBvZnRlbiBnaXZlcyBu b24taW50ZXJhY3RpdmUgR29vZ2xlIHBhZ2UgKDI2NjcwKQorICAgICAgICA8aHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NjcwPgorCisgICAgICAgIE1ha2Ugd2luZG93 cyBsb2FkZXIgY2xpZW50IG1hdGNoIG1hYyBiZWhhdmlvdXIgbW9yZSBjbG9zZWx5LgorCisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAo V2ViRnJhbWVMb2FkZXJDbGllbnQ6OmZvcmNlTGF5b3V0KToKKwogMjAwOS0wNy0wMiAgRXJpYyBD YXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggV2luZG93cyBi dWlsZCBieSBpbmNsdWRpbmcgbWlzc2luZyBsb2NhbGl6ZWQgc3RyaW5nIG1ldGhvZHMuCmRpZmYg LS1naXQgYS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNw cCBiL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCmlu ZGV4IGIzN2EwZDEuLmVkMGQ0NGEgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vV2ViQ29yZVN1cHBv cnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCisrKyBiL1dlYktpdC93aW4vV2ViQ29yZVN1cHBv cnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCkBAIC05NCw5ICs5NCwxOSBAQCBib29sIFdlYkZy YW1lTG9hZGVyQ2xpZW50OjpoYXNXZWJWaWV3KCkgY29uc3QKIAogdm9pZCBXZWJGcmFtZUxvYWRl ckNsaWVudDo6Zm9yY2VMYXlvdXQoKQogewotICAgIEZyYW1lVmlldyogdmlldyA9IGNvcmUobV93 ZWJGcmFtZSktPnZpZXcoKTsKLSAgICBpZiAodmlldykKLSAgICAgICAgdmlldy0+Zm9yY2VMYXlv dXQodHJ1ZSk7CisgICAgRnJhbWUqIGZyYW1lID0gY29yZShtX3dlYkZyYW1lKTsKKyAgICBpZiAo IWZyYW1lKQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAoZnJhbWUtPmRvY3VtZW50KCkgJiYg ZnJhbWUtPmRvY3VtZW50KCktPmluUGFnZUNhY2hlKCkpCisgICAgICAgIHJldHVybjsKKworICAg IEZyYW1lVmlldyogdmlldyA9IGZyYW1lLT52aWV3KCk7CisgICAgaWYgKCF2aWV3KQorICAgICAg ICByZXR1cm47CisKKyAgICB2aWV3LT5zZXROZWVkc0xheW91dCgpOworICAgIHZpZXctPmZvcmNl TGF5b3V0KHRydWUpOwogfQogCiB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojphc3NpZ25JZGVu dGlmaWVyVG9Jbml0aWFsUmVxdWVzdCh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIERvY3VtZW50 TG9hZGVyKiBsb2FkZXIsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkK