26669 2009-06-23 18:54:08 -0700 bugzilla-tool land-patches fails to comment in the bug correctly 2009-06-23 23:26:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric oldest_to_newest 127792 0 eric 2009-06-23 18:54:08 -0700 I ran: bugzilla-tool land-patches 26537 --no-build --no-test And it managed to close the bug and land the patch, but the closing comment wasn't correct. Sigh. I'll fix... 127823 1 31770 eric 2009-06-23 23:10:16 -0700 Created attachment 31770 Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run --- 3 files changed, 16 insertions(+), 4 deletions(-) 127826 2 eric 2009-06-23 23:26:19 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/scm.py Committed r45062 http://trac.webkit.org/changeset/45062 31770 2009-06-23 23:10:16 -0700 2009-06-23 23:18:31 -0700 Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run bugzilla_requires_a_filename.patch text/plain 2636 eric MzI4NjI0MTM0MjkyN2E5OWMyYjA3MTliYzYzZGY5N2Q3Nzg4YzY4YgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGZjYzNjMDMu LjRiODIxODQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRU b29scy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAwOS0wNi0yMyAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4IG1pc3NpbmcgY29tbWVudCBtZXNzYWdlIGR1cmluZyBsYW5kLXBhdGNo ZXMgYW5kIFNWTi5jb21taXRfd2l0aF9tZXNzYWdlIHJlc3BlY3RpbmcgLS1kcnktcnVuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjY2OQorCisgICAg ICAgICogU2NyaXB0cy9idWd6aWxsYS10b29sOgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9z Y20ucHk6CisKKzIwMDktMDYtMjMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCiAg ICAgICAgIFJldmlld2VkIGJ5IERhdmUgTGV2aW4uCiAKICAgICAgICAgTWFrZSBTQ00ucnVuX2Nv bW1hbmQgc21hcnRlciwgYW5kIG1ha2UgYWxsIHByZXZpb3VzCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxh LXRvb2wKaW5kZXggN2UwZDk2MS4uYTA1YWRlNCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy9idWd6aWxsYS10b29sCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9v bApAQCAtMjMwLDcgKzIzMCw3IEBAIGNsYXNzIExhbmRQYXRjaGVzRnJvbUJ1ZyhDb21tYW5kKToK IAogICAgICAgICB0cnk6CiAgICAgICAgICAgICBwYXRjaGVzID0gdG9vbC5idWdzLmZldGNoX3Jl dmlld2VkX3BhdGNoZXNfZnJvbV9idWcoYnVnX2lkKQotICAgICAgICAgICAgY29tbWl0X3RleHQg PSAiIgorICAgICAgICAgICAgY29tbWVudF90ZXh0ID0gIiIKIAogICAgICAgICAgICAgb3MuY2hk aXIodG9vbC5zY20oKS5jaGVja291dF9yb290KQogICAgICAgICAgICAgdG9vbC5zY20oKS5lbnN1 cmVfbm9fbG9jYWxfY29tbWl0cyhvcHRpb25zLmZvcmNlX2NsZWFuKQpAQCAtMjUzLDkgKzI1Myw5 IEBAIGNsYXNzIExhbmRQYXRjaGVzRnJvbUJ1ZyhDb21tYW5kKToKICAgICAgICAgICAgICAgICAg ICAgdG9vbC5idWdzLm9ic29sZXRlX2F0dGFjaG1lbnQocGF0Y2hbJ2lkJ10sIGNvbW1lbnRfdGV4 dCkKIAogICAgICAgICAgICAgaWYgbGVuKHBhdGNoZXMpID4gMToKLSAgICAgICAgICAgICAgICBj b21taXRfdGV4dCA9ICJBbGwgcmV2aWV3ZWQgcGF0Y2hlcyBsYW5kZWQsIGNsb3NpbmcuIgorICAg ICAgICAgICAgICAgIGNvbW1lbnRfdGV4dCA9ICJBbGwgcmV2aWV3ZWQgcGF0Y2hlcyBsYW5kZWQs IGNsb3NpbmcuIgogCi0gICAgICAgICAgICB0b29sLmJ1Z3MuY2xvc2VfYnVnX2FzX2ZpeGVkKGJ1 Z19pZCwgY29tbWl0X3RleHQpCisgICAgICAgICAgICB0b29sLmJ1Z3MuY2xvc2VfYnVnX2FzX2Zp eGVkKGJ1Z19pZCwgY29tbWVudF90ZXh0KQogICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGVy cm9yOgogICAgICAgICAgICAgbG9nKGVycm9yKQogICAgICAgICAgICAgIyBXZSBjb3VsZCBhZGQg YSBjb21tZW50IHRvIHRoZSBidWcgYWJvdXQgdGhlIGZhaWx1cmUuCmRpZmYgLS1naXQgYS9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2NtLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL3NjbS5weQppbmRleCAzZWVlN2NlLi5lMjI2OTYyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL21vZHVsZXMvc2NtLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxl cy9zY20ucHkKQEAgLTc1LDcgKzc1LDcgQEAgY2xhc3MgU0NNOgogICAgICAgICAgICAgcHJpbnQg c2VsZi5ydW5fY29tbWFuZChzZWxmLnN0YXR1c19jb21tYW5kKCkpCiAgICAgICAgICAgICBlcnJv cigiV29ya2luZyBkaXJlY3RvcnkgaGFzIG1vZGlmaWNhdGlvbnMsIHBhc3MgLS1mb3JjZS1jbGVh biBvciAtLW5vLWNsZWFuIHRvIGNvbnRpbnVlLiIpCiAgICAgICAgIAotICAgICAgICBsb2coIkNs ZWFuaW5nIHRoZSB3b3JraW5nIGRpcmVjdG9yeSIpCisgICAgICAgIGxvZygiQ2xlYW5pbmcgd29y a2luZyBkaXJlY3RvcnkiKQogICAgICAgICBzZWxmLmNsZWFuX3dvcmtpbmdfZGlyZWN0b3J5KCkK ICAgICAKICAgICBkZWYgZW5zdXJlX25vX2xvY2FsX2NvbW1pdHMoc2VsZiwgZm9yY2UpOgpAQCAt MjA0LDYgKzIwNCw4IEBAIGNsYXNzIFNWTihTQ00pOgogICAgICAgICByZXR1cm4gInN2bi1jcmVh dGUtcGF0Y2giCiAKICAgICBkZWYgY29tbWl0X3dpdGhfbWVzc2FnZShzZWxmLCBtZXNzYWdlKToK KyAgICAgICAgaWYgc2VsZi5kcnlydW46CisgICAgICAgICAgICByZXR1cm4gIkRyeSBydW4sIG5v IHJlbW90ZSBjb21taXQuIgogICAgICAgICByZXR1cm4gc2VsZi5ydW5fY29tbWFuZCgnc3ZuIGNv bW1pdCAtRiAtJywgaW5wdXQ9bWVzc2FnZSkKIAogIyBBbGwgZ2l0LXNwZWNpZmljIGxvZ2ljIHNo b3VsZCBnbyBoZXJlLgo=