26659 2009-06-23 14:03:41 -0700 Support hidding an control bar element from the Media element controller (display:none does not work for media control elements) 2009-06-26 11:01:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 26653 26661 1 pdherbemont webkit-unassigned simon.fraser oldest_to_newest 127683 0 pdherbemont 2009-06-23 14:03:41 -0700 Support hidding an control bar element from the Media element controller. We would then be able to remove the some buttons from <video controls> if the back end doesn't support those actions. This is blocked by https://bugs.webkit.org/show_bug.cgi?id=26653 127684 1 31735 pdherbemont 2009-06-23 14:09:51 -0700 Created attachment 31735 patch v1. Attached a patch that should be applied after the blocker. 127707 2 31745 pdherbemont 2009-06-23 15:28:15 -0700 Created attachment 31745 patch v2. With ChangeLog. 127758 3 31745 eric 2009-06-23 17:37:44 -0700 Comment on attachment 31745 patch v2. You ChangeLog is missing the bug url. Style: + if(m_isHidden) + if(!m_mediaElement || !m_mediaElement->renderer()) + if (!renderer() && !m_isHidden && style->display() != NONE) + { + if (renderer) + { When does this ever return NULL? + RenderObject* renderer = createRenderer(m_mediaElement->renderer()->renderArena(), style); Why don't we just early-return in that case? Why manually set attached instead of calling attach? + setAttached(); 128028 4 pdherbemont 2009-06-24 16:40:54 -0700 (In reply to comment #3) > (From update of attachment 31745 [review]) > You ChangeLog is missing the bug url. Thanks. > Style: > + if(m_isHidden) > + if(!m_mediaElement || !m_mediaElement->renderer()) > + if (!renderer() && !m_isHidden && style->display() != NONE) > + { > + if (renderer) > + { Thanks. > When does this ever return NULL? > + RenderObject* renderer = > createRenderer(m_mediaElement->renderer()->renderArena(), style); That's what previous code does. I guess it will be NULL if malloc fails basically. > Why don't we just early-return in that case? ok. > Why manually set attached instead of calling attach? > + setAttached(); That's what previous code was doing :) Using attach() requires some changes. And I think it deserve a separate bug. (Basically we need to create a renderer with a specific style, so we need a to have styleForRenderer() virtual, along with other changes). I have created https://bugs.webkit.org/show_bug.cgi?id=26697 for that. 128031 5 31817 pdherbemont 2009-06-24 16:50:42 -0700 Created attachment 31817 patch v3. ChangeLog with Bug number, coding style fixes. 128218 6 simon.fraser 2009-06-25 11:00:38 -0700 *** Bug 26228 has been marked as a duplicate of this bug. *** 128224 7 31817 simon.fraser 2009-06-25 11:28:56 -0700 Comment on attachment 31817 patch v3. Let's get rid of the m_isHidden on MediaControlInputElement, and a virtual method shouldBeVisible() on MediaControlInputElement that you can override to ask about fullscreen etc. updateStyle() will then need to handle the detach() case. Also need to clean up update() vs. updateStyle(). 128299 8 31882 pdherbemont 2009-06-25 15:55:02 -0700 Created attachment 31882 patch v4. Updated with Simon's comment. 128301 9 31882 simon.fraser 2009-06-25 16:01:11 -0700 Comment on attachment 31882 patch v4. > + if (renderer() && !rendererIsNeeded(style)) > + detach(); > + else if (!renderer() && rendererIsNeeded(style)) { It's probably worth changing this to call rendererIsNeeded() just once. r=me 128515 10 simon.fraser 2009-06-26 11:01:02 -0700 http://trac.webkit.org/changeset/45271 31735 2009-06-23 14:09:51 -0700 2009-06-23 15:28:15 -0700 patch v1. 003-setHidden-support.diff text/plain 3296 pdherbemont Y29tbWl0IGIwMGFmMWMxYmY4ZjY5MWI0YmViMTMxMDM3MWE3OTAyZGQ3ZTE2YjUKQXV0aG9yOiBQ aWVycmUgZCdIZXJiZW1vbnQgPHBkaGVyYmVtb250QGFwcGxlLmNvbT4KRGF0ZTogICBNb24gSnVu IDIyIDIyOjU4OjQ0IDIwMDkgLTA3MDAKCiAgICBTdXBwb3J0IGhpZGRpbmcgYW4gY29udHJvbCBi YXIgZWxlbWVudCBmcm9tIHRoZSBNZWRpYSBlbGVtZW50IGNvbnRyb2xsZXIuCgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwIGIvV2ViQ29yZS9y ZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCmluZGV4IGQ2NjUxOWEuLjY3YTUwMzcg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAor KysgYi9XZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKQEAgLTEyMywx OCArMTIzLDI1IEBAIE1lZGlhQ29udHJvbElucHV0RWxlbWVudDo6TWVkaWFDb250cm9sSW5wdXRF bGVtZW50KERvY3VtZW50KiBkb2MsIFBzZXVkb0lkIHBzZXVkCiAgICAgLCBtX21lZGlhRWxlbWVu dChtZWRpYUVsZW1lbnQpCiAgICAgLCBtX3BzZXVkb1N0eWxlSWQocHNldWRvKQogICAgICwgbV9k aXNwbGF5VHlwZShkaXNwbGF5VHlwZSkKKyAgICAsIG1faXNIaWRkZW4oZmFsc2UpCiB7CiAgICAg c2V0SW5wdXRUeXBlKHR5cGUpOwotICAgIFJlbmRlclN0eWxlKiBzdHlsZSA9IG1fbWVkaWFFbGVt ZW50LT5yZW5kZXJlcigpLT5nZXRDYWNoZWRQc2V1ZG9TdHlsZShtX3BzZXVkb1N0eWxlSWQpOwot ICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBjcmVhdGVSZW5kZXJlcihtX21lZGlhRWxlbWVu dC0+cmVuZGVyZXIoKS0+cmVuZGVyQXJlbmEoKSwgc3R5bGUpOwotICAgIGlmIChyZW5kZXJlcikg ewotICAgICAgICBzZXRSZW5kZXJlcihyZW5kZXJlcik7Ci0gICAgICAgIHJlbmRlcmVyLT5zZXRT dHlsZShzdHlsZSk7Ci0gICAgfQotICAgIHNldEF0dGFjaGVkKCk7CisgICAgdXBkYXRlU3R5bGUo KTsKICAgICBzZXRJbkRvY3VtZW50KHRydWUpOwogfQogCit2b2lkIE1lZGlhQ29udHJvbElucHV0 RWxlbWVudDo6c2V0SGlkZGVuKGJvb2wgaXNIaWRkZW4pCit7CisgICAgaWYgKG1faXNIaWRkZW4g PT0gaXNIaWRkZW4pCisgICAgICAgIHJldHVybjsKKyAgICBtX2lzSGlkZGVuID0gaXNIaWRkZW47 CisKKyAgICBpZihtX2lzSGlkZGVuKQorICAgICAgICBkZXRhY2goKTsKKyAgICBlbHNlCisgICAg ICAgIHVwZGF0ZVN0eWxlKCk7Cit9CisKIHZvaWQgTWVkaWFDb250cm9sSW5wdXRFbGVtZW50Ojph dHRhY2hUb1BhcmVudChFbGVtZW50KiBwYXJlbnQpCiB7CiAgICAgcGFyZW50LT5hZGRDaGlsZCh0 aGlzKTsKQEAgLTE1MSwxMCArMTU4LDI2IEBAIHZvaWQgTWVkaWFDb250cm9sSW5wdXRFbGVtZW50 Ojp1cGRhdGUoKQogCiB2b2lkIE1lZGlhQ29udHJvbElucHV0RWxlbWVudDo6dXBkYXRlU3R5bGUo KQogewotICAgIGlmIChyZW5kZXJlcigpICYmIG1fbWVkaWFFbGVtZW50LT5yZW5kZXJlcigpKSB7 Ci0gICAgICAgIFJlbmRlclN0eWxlKiBzdHlsZSA9IG1fbWVkaWFFbGVtZW50LT5yZW5kZXJlcigp LT5nZXRDYWNoZWRQc2V1ZG9TdHlsZShtX3BzZXVkb1N0eWxlSWQpOwotICAgICAgICByZW5kZXJl cigpLT5zZXRTdHlsZShzdHlsZSk7CisgICAgaWYoIW1fbWVkaWFFbGVtZW50IHx8ICFtX21lZGlh RWxlbWVudC0+cmVuZGVyZXIoKSkKKyAgICAgICAgcmV0dXJuOworICAgIAorICAgIFJlbmRlclN0 eWxlKiBzdHlsZSA9IG1fbWVkaWFFbGVtZW50LT5yZW5kZXJlcigpLT5nZXRDYWNoZWRQc2V1ZG9T dHlsZShtX3BzZXVkb1N0eWxlSWQpOworICAgIAorICAgIGlmICghcmVuZGVyZXIoKSAmJiAhbV9p c0hpZGRlbiAmJiBzdHlsZS0+ZGlzcGxheSgpICE9IE5PTkUpCisgICAgeworICAgICAgICBSZW5k ZXJPYmplY3QqIHJlbmRlcmVyID0gY3JlYXRlUmVuZGVyZXIobV9tZWRpYUVsZW1lbnQtPnJlbmRl cmVyKCktPnJlbmRlckFyZW5hKCksIHN0eWxlKTsKKyAgICAgICAgaWYgKHJlbmRlcmVyKQorICAg ICAgICB7CisgICAgICAgICAgICByZW5kZXJlci0+c2V0U3R5bGUoc3R5bGUpOworICAgICAgICAg ICAgc2V0UmVuZGVyZXIocmVuZGVyZXIpOworICAgICAgICAgICAgc2V0QXR0YWNoZWQoKTsKKyAg ICAgICAgICAgIGlmKHBhcmVudCgpKQorICAgICAgICAgICAgICAgIHBhcmVudCgpLT5yZW5kZXJl cigpLT5hZGRDaGlsZChyZW5kZXJlciwgbmV4dFNpYmxpbmcoKSA/IG5leHRTaWJsaW5nKCktPnJl bmRlcmVyKCkgOiBOVUxMKTsKKyAgICAgICAgfQogICAgIH0KKyAgICAKKyAgICBpZihyZW5kZXJl cigpKQorICAgICAgICByZW5kZXJlcigpLT5zZXRTdHlsZShzdHlsZSk7CiB9CiAKIGJvb2wgTWVk aWFDb250cm9sSW5wdXRFbGVtZW50OjpoaXRUZXN0KGNvbnN0IEludFBvaW50JiBhYnNQb2ludCkK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmggYi9X ZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5oCmluZGV4IGQzZTAwNDAuLjBj OTU5NzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRz LmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuaApAQCAtOTAs NiArOTAsNyBAQCBjbGFzcyBNZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQgOiBwdWJsaWMgSFRNTElu cHV0RWxlbWVudCB7CiBwdWJsaWM6CiAgICAgTWVkaWFDb250cm9sSW5wdXRFbGVtZW50KERvY3Vt ZW50KiwgUHNldWRvSWQsIGNvbnN0IFN0cmluZyYgdHlwZSwgSFRNTE1lZGlhRWxlbWVudCosIE1l ZGlhQ29udHJvbEVsZW1lbnRUeXBlKTsKICAgICB2b2lkIGF0dGFjaFRvUGFyZW50KEVsZW1lbnQq KTsKKyAgICB2b2lkIHNldEhpZGRlbihib29sKTsKICAgICB2b2lkIHVwZGF0ZSgpOwogICAgIHZv aWQgdXBkYXRlU3R5bGUoKTsKICAgICBib29sIGhpdFRlc3QoY29uc3QgSW50UG9pbnQmIGFic1Bv aW50KTsKQEAgLTEwMiw2ICsxMDMsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgSFRNTE1lZGlhRWxlbWVu dCogbV9tZWRpYUVsZW1lbnQ7ICAgCiAgICAgUHNldWRvSWQgbV9wc2V1ZG9TdHlsZUlkOwogICAg IE1lZGlhQ29udHJvbEVsZW1lbnRUeXBlIG1fZGlzcGxheVR5cGU7ICAvLyBzb21lIGVsZW1lbnRz IGNhbiBzaG93IG11bHRpcGxlIHR5cGVzIChlLmcuIHBsYXkvcGF1c2UpCisgICAgYm9vbCBtX2lz SGlkZGVuOwogfTsKIAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo= 31745 2009-06-23 15:28:15 -0700 2009-06-24 16:50:42 -0700 patch v2. 003-setHidden-support-v2.diff text/plain 3903 pdherbemont ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTMyMmFkYS4uOWZhZmRjMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNi0yMyAgUGllcnJlIGQnSGVy YmVtb250ICA8cGRoZXJiZW1vbnRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1cHBvcnQgaGlkZGluZyBhbiBjb250cm9sIGJhciBl bGVtZW50IGZyb20gdGhlIE1lZGlhIGVsZW1lbnQgY29udHJvbGxlci4KKworICAgICAgICBObyBs YXlvdXQgdGVzdCBjYW4gYmUgZG9uZSBzbyBmYXIsIGFzIHRoaXMgaXMgbm90IHJlYWNoYWJsZSB0 aHJvdWdoIHRoZSBET00uCisKKyAgICAgICAgKiByZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVu dHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sSW5wdXRFbGVtZW50OjpNZWRp YUNvbnRyb2xJbnB1dEVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sSW5w dXRFbGVtZW50OjpzZXRIaWRkZW4pOiBuZXcgZnVuY3Rpb24uCisgICAgICAgIChXZWJDb3JlOjpN ZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQ6OnVwZGF0ZVN0eWxlKTogQWN0dWFsbHkgaW1wbGVtZW50 IGhpZGRpbmcuCisgICAgICAgICogcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmg6CisK IDIwMDktMDYtMjIgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5n L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJv bEVsZW1lbnRzLmNwcAppbmRleCBkNjY1MTlhLi42N2E1MDM3IDEwMDY0NAotLS0gYS9XZWJDb3Jl L3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJp bmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCkBAIC0xMjMsMTggKzEyMywyNSBAQCBNZWRpYUNv bnRyb2xJbnB1dEVsZW1lbnQ6Ok1lZGlhQ29udHJvbElucHV0RWxlbWVudChEb2N1bWVudCogZG9j LCBQc2V1ZG9JZCBwc2V1ZAogICAgICwgbV9tZWRpYUVsZW1lbnQobWVkaWFFbGVtZW50KQogICAg ICwgbV9wc2V1ZG9TdHlsZUlkKHBzZXVkbykKICAgICAsIG1fZGlzcGxheVR5cGUoZGlzcGxheVR5 cGUpCisgICAgLCBtX2lzSGlkZGVuKGZhbHNlKQogewogICAgIHNldElucHV0VHlwZSh0eXBlKTsK LSAgICBSZW5kZXJTdHlsZSogc3R5bGUgPSBtX21lZGlhRWxlbWVudC0+cmVuZGVyZXIoKS0+Z2V0 Q2FjaGVkUHNldWRvU3R5bGUobV9wc2V1ZG9TdHlsZUlkKTsKLSAgICBSZW5kZXJPYmplY3QqIHJl bmRlcmVyID0gY3JlYXRlUmVuZGVyZXIobV9tZWRpYUVsZW1lbnQtPnJlbmRlcmVyKCktPnJlbmRl ckFyZW5hKCksIHN0eWxlKTsKLSAgICBpZiAocmVuZGVyZXIpIHsKLSAgICAgICAgc2V0UmVuZGVy ZXIocmVuZGVyZXIpOwotICAgICAgICByZW5kZXJlci0+c2V0U3R5bGUoc3R5bGUpOwotICAgIH0K LSAgICBzZXRBdHRhY2hlZCgpOworICAgIHVwZGF0ZVN0eWxlKCk7CiAgICAgc2V0SW5Eb2N1bWVu dCh0cnVlKTsKIH0KIAordm9pZCBNZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQ6OnNldEhpZGRlbihi b29sIGlzSGlkZGVuKQoreworICAgIGlmIChtX2lzSGlkZGVuID09IGlzSGlkZGVuKQorICAgICAg ICByZXR1cm47CisgICAgbV9pc0hpZGRlbiA9IGlzSGlkZGVuOworCisgICAgaWYobV9pc0hpZGRl bikKKyAgICAgICAgZGV0YWNoKCk7CisgICAgZWxzZQorICAgICAgICB1cGRhdGVTdHlsZSgpOwor fQorCiB2b2lkIE1lZGlhQ29udHJvbElucHV0RWxlbWVudDo6YXR0YWNoVG9QYXJlbnQoRWxlbWVu dCogcGFyZW50KQogewogICAgIHBhcmVudC0+YWRkQ2hpbGQodGhpcyk7CkBAIC0xNTEsMTAgKzE1 OCwyNiBAQCB2b2lkIE1lZGlhQ29udHJvbElucHV0RWxlbWVudDo6dXBkYXRlKCkKIAogdm9pZCBN ZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQ6OnVwZGF0ZVN0eWxlKCkKIHsKLSAgICBpZiAocmVuZGVy ZXIoKSAmJiBtX21lZGlhRWxlbWVudC0+cmVuZGVyZXIoKSkgewotICAgICAgICBSZW5kZXJTdHls ZSogc3R5bGUgPSBtX21lZGlhRWxlbWVudC0+cmVuZGVyZXIoKS0+Z2V0Q2FjaGVkUHNldWRvU3R5 bGUobV9wc2V1ZG9TdHlsZUlkKTsKLSAgICAgICAgcmVuZGVyZXIoKS0+c2V0U3R5bGUoc3R5bGUp OworICAgIGlmKCFtX21lZGlhRWxlbWVudCB8fCAhbV9tZWRpYUVsZW1lbnQtPnJlbmRlcmVyKCkp CisgICAgICAgIHJldHVybjsKKyAgICAKKyAgICBSZW5kZXJTdHlsZSogc3R5bGUgPSBtX21lZGlh RWxlbWVudC0+cmVuZGVyZXIoKS0+Z2V0Q2FjaGVkUHNldWRvU3R5bGUobV9wc2V1ZG9TdHlsZUlk KTsKKyAgICAKKyAgICBpZiAoIXJlbmRlcmVyKCkgJiYgIW1faXNIaWRkZW4gJiYgc3R5bGUtPmRp c3BsYXkoKSAhPSBOT05FKQorICAgIHsKKyAgICAgICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9 IGNyZWF0ZVJlbmRlcmVyKG1fbWVkaWFFbGVtZW50LT5yZW5kZXJlcigpLT5yZW5kZXJBcmVuYSgp LCBzdHlsZSk7CisgICAgICAgIGlmIChyZW5kZXJlcikKKyAgICAgICAgeworICAgICAgICAgICAg cmVuZGVyZXItPnNldFN0eWxlKHN0eWxlKTsKKyAgICAgICAgICAgIHNldFJlbmRlcmVyKHJlbmRl cmVyKTsKKyAgICAgICAgICAgIHNldEF0dGFjaGVkKCk7CisgICAgICAgICAgICBpZihwYXJlbnQo KSkKKyAgICAgICAgICAgICAgICBwYXJlbnQoKS0+cmVuZGVyZXIoKS0+YWRkQ2hpbGQocmVuZGVy ZXIsIG5leHRTaWJsaW5nKCkgPyBuZXh0U2libGluZygpLT5yZW5kZXJlcigpIDogTlVMTCk7Cisg ICAgICAgIH0KICAgICB9CisgICAgCisgICAgaWYocmVuZGVyZXIoKSkKKyAgICAgICAgcmVuZGVy ZXIoKS0+c2V0U3R5bGUoc3R5bGUpOwogfQogCiBib29sIE1lZGlhQ29udHJvbElucHV0RWxlbWVu dDo6aGl0VGVzdChjb25zdCBJbnRQb2ludCYgYWJzUG9pbnQpCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvTWVk aWFDb250cm9sRWxlbWVudHMuaAppbmRleCBkM2UwMDQwLi4wYzk1OTc2IDEwMDY0NAotLS0gYS9X ZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5oCisrKyBiL1dlYkNvcmUvcmVu ZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmgKQEAgLTkwLDYgKzkwLDcgQEAgY2xhc3MgTWVk aWFDb250cm9sSW5wdXRFbGVtZW50IDogcHVibGljIEhUTUxJbnB1dEVsZW1lbnQgewogcHVibGlj OgogICAgIE1lZGlhQ29udHJvbElucHV0RWxlbWVudChEb2N1bWVudCosIFBzZXVkb0lkLCBjb25z dCBTdHJpbmcmIHR5cGUsIEhUTUxNZWRpYUVsZW1lbnQqLCBNZWRpYUNvbnRyb2xFbGVtZW50VHlw ZSk7CiAgICAgdm9pZCBhdHRhY2hUb1BhcmVudChFbGVtZW50Kik7CisgICAgdm9pZCBzZXRIaWRk ZW4oYm9vbCk7CiAgICAgdm9pZCB1cGRhdGUoKTsKICAgICB2b2lkIHVwZGF0ZVN0eWxlKCk7CiAg ICAgYm9vbCBoaXRUZXN0KGNvbnN0IEludFBvaW50JiBhYnNQb2ludCk7CkBAIC0xMDIsNiArMTAz LDcgQEAgcHJvdGVjdGVkOgogICAgIEhUTUxNZWRpYUVsZW1lbnQqIG1fbWVkaWFFbGVtZW50OyAg IAogICAgIFBzZXVkb0lkIG1fcHNldWRvU3R5bGVJZDsKICAgICBNZWRpYUNvbnRyb2xFbGVtZW50 VHlwZSBtX2Rpc3BsYXlUeXBlOyAgLy8gc29tZSBlbGVtZW50cyBjYW4gc2hvdyBtdWx0aXBsZSB0 eXBlcyAoZS5nLiBwbGF5L3BhdXNlKQorICAgIGJvb2wgbV9pc0hpZGRlbjsKIH07CiAKIC8vIC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K 31817 2009-06-24 16:50:42 -0700 2009-06-25 15:55:02 -0700 patch v3. 003-setHidden-support-v3.diff text/plain 3817 pdherbemont ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTMyMmFkYS4uMmJlZmU5NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wNi0yNCAgUGllcnJlIGQnSGVy YmVtb250ICA8cGRoZXJiZW1vbnRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1cHBvcnQgaGlkZGluZyBhIGNvbnRyb2wgYmFyIGVs ZW1lbnQgZnJvbSB0aGUgTWVkaWEgZWxlbWVudCBjb250cm9sbGVyLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjY1OQorCisgICAgICAgIE5vIGxh eW91dCB0ZXN0IGNhbiBiZSBkb25lIHNvIGZhciwgYXMgdGhpcyBpcyBub3QgcmVhY2hhYmxlIHRo cm91Z2ggdGhlIERPTS4KKworICAgICAgICAqIHJlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50 cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQ6Ok1lZGlh Q29udHJvbElucHV0RWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xJbnB1 dEVsZW1lbnQ6OnNldEhpZGRlbik6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xJbnB1 dEVsZW1lbnQ6OnVwZGF0ZVN0eWxlKToKKyAgICAgICAgKiByZW5kZXJpbmcvTWVkaWFDb250cm9s RWxlbWVudHMuaDoKKwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9s RWxlbWVudHMuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3Bw CmluZGV4IGQ2NjUxOWEuLjA4ZTYzNmMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL01l ZGlhQ29udHJvbEVsZW1lbnRzLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRy b2xFbGVtZW50cy5jcHAKQEAgLTEyMywxOCArMTIzLDI1IEBAIE1lZGlhQ29udHJvbElucHV0RWxl bWVudDo6TWVkaWFDb250cm9sSW5wdXRFbGVtZW50KERvY3VtZW50KiBkb2MsIFBzZXVkb0lkIHBz ZXVkCiAgICAgLCBtX21lZGlhRWxlbWVudChtZWRpYUVsZW1lbnQpCiAgICAgLCBtX3BzZXVkb1N0 eWxlSWQocHNldWRvKQogICAgICwgbV9kaXNwbGF5VHlwZShkaXNwbGF5VHlwZSkKKyAgICAsIG1f aXNIaWRkZW4oZmFsc2UpCiB7CiAgICAgc2V0SW5wdXRUeXBlKHR5cGUpOwotICAgIFJlbmRlclN0 eWxlKiBzdHlsZSA9IG1fbWVkaWFFbGVtZW50LT5yZW5kZXJlcigpLT5nZXRDYWNoZWRQc2V1ZG9T dHlsZShtX3BzZXVkb1N0eWxlSWQpOwotICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBjcmVh dGVSZW5kZXJlcihtX21lZGlhRWxlbWVudC0+cmVuZGVyZXIoKS0+cmVuZGVyQXJlbmEoKSwgc3R5 bGUpOwotICAgIGlmIChyZW5kZXJlcikgewotICAgICAgICBzZXRSZW5kZXJlcihyZW5kZXJlcik7 Ci0gICAgICAgIHJlbmRlcmVyLT5zZXRTdHlsZShzdHlsZSk7Ci0gICAgfQotICAgIHNldEF0dGFj aGVkKCk7CisgICAgdXBkYXRlU3R5bGUoKTsKICAgICBzZXRJbkRvY3VtZW50KHRydWUpOwogfQog Cit2b2lkIE1lZGlhQ29udHJvbElucHV0RWxlbWVudDo6c2V0SGlkZGVuKGJvb2wgaXNIaWRkZW4p Cit7CisgICAgaWYgKG1faXNIaWRkZW4gPT0gaXNIaWRkZW4pCisgICAgICAgIHJldHVybjsKKyAg ICBtX2lzSGlkZGVuID0gaXNIaWRkZW47CisKKyAgICBpZiAobV9pc0hpZGRlbikKKyAgICAgICAg ZGV0YWNoKCk7CisgICAgZWxzZQorICAgICAgICB1cGRhdGVTdHlsZSgpOworfQorCiB2b2lkIE1l ZGlhQ29udHJvbElucHV0RWxlbWVudDo6YXR0YWNoVG9QYXJlbnQoRWxlbWVudCogcGFyZW50KQog ewogICAgIHBhcmVudC0+YWRkQ2hpbGQodGhpcyk7CkBAIC0xNTEsMTAgKzE1OCwyNSBAQCB2b2lk IE1lZGlhQ29udHJvbElucHV0RWxlbWVudDo6dXBkYXRlKCkKIAogdm9pZCBNZWRpYUNvbnRyb2xJ bnB1dEVsZW1lbnQ6OnVwZGF0ZVN0eWxlKCkKIHsKLSAgICBpZiAocmVuZGVyZXIoKSAmJiBtX21l ZGlhRWxlbWVudC0+cmVuZGVyZXIoKSkgewotICAgICAgICBSZW5kZXJTdHlsZSogc3R5bGUgPSBt X21lZGlhRWxlbWVudC0+cmVuZGVyZXIoKS0+Z2V0Q2FjaGVkUHNldWRvU3R5bGUobV9wc2V1ZG9T dHlsZUlkKTsKLSAgICAgICAgcmVuZGVyZXIoKS0+c2V0U3R5bGUoc3R5bGUpOworICAgIGlmICgh bV9tZWRpYUVsZW1lbnQgfHwgIW1fbWVkaWFFbGVtZW50LT5yZW5kZXJlcigpKQorICAgICAgICBy ZXR1cm47CisgICAgCisgICAgUmVuZGVyU3R5bGUqIHN0eWxlID0gbV9tZWRpYUVsZW1lbnQtPnJl bmRlcmVyKCktPmdldENhY2hlZFBzZXVkb1N0eWxlKG1fcHNldWRvU3R5bGVJZCk7CisgICAgCisg ICAgaWYgKCFyZW5kZXJlcigpICYmICFtX2lzSGlkZGVuICYmIHN0eWxlLT5kaXNwbGF5KCkgIT0g Tk9ORSkKKyAgICB7CisgICAgICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBjcmVhdGVSZW5k ZXJlcihtX21lZGlhRWxlbWVudC0+cmVuZGVyZXIoKS0+cmVuZGVyQXJlbmEoKSwgc3R5bGUpOwor ICAgICAgICBpZiAoIXJlbmRlcmVyKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICByZW5k ZXJlci0+c2V0U3R5bGUoc3R5bGUpOworICAgICAgICBzZXRSZW5kZXJlcihyZW5kZXJlcik7Cisg ICAgICAgIHNldEF0dGFjaGVkKCk7CisgICAgICAgIGlmIChwYXJlbnQoKSkKKyAgICAgICAgICAg IHBhcmVudCgpLT5yZW5kZXJlcigpLT5hZGRDaGlsZChyZW5kZXJlciwgbmV4dFNpYmxpbmcoKSA/ IG5leHRTaWJsaW5nKCktPnJlbmRlcmVyKCkgOiBOVUxMKTsKICAgICB9CisgICAgCisgICAgaWYg KHJlbmRlcmVyKCkpCisgICAgICAgIHJlbmRlcmVyKCktPnNldFN0eWxlKHN0eWxlKTsKIH0KIAog Ym9vbCBNZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQ6OmhpdFRlc3QoY29uc3QgSW50UG9pbnQmIGFi c1BvaW50KQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVu dHMuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmgKaW5kZXggZDNl MDA0MC4uMGM5NTk3NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9s RWxlbWVudHMuaAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5o CkBAIC05MCw2ICs5MCw3IEBAIGNsYXNzIE1lZGlhQ29udHJvbElucHV0RWxlbWVudCA6IHB1Ymxp YyBIVE1MSW5wdXRFbGVtZW50IHsKIHB1YmxpYzoKICAgICBNZWRpYUNvbnRyb2xJbnB1dEVsZW1l bnQoRG9jdW1lbnQqLCBQc2V1ZG9JZCwgY29uc3QgU3RyaW5nJiB0eXBlLCBIVE1MTWVkaWFFbGVt ZW50KiwgTWVkaWFDb250cm9sRWxlbWVudFR5cGUpOwogICAgIHZvaWQgYXR0YWNoVG9QYXJlbnQo RWxlbWVudCopOworICAgIHZvaWQgc2V0SGlkZGVuKGJvb2wpOwogICAgIHZvaWQgdXBkYXRlKCk7 CiAgICAgdm9pZCB1cGRhdGVTdHlsZSgpOwogICAgIGJvb2wgaGl0VGVzdChjb25zdCBJbnRQb2lu dCYgYWJzUG9pbnQpOwpAQCAtMTAyLDYgKzEwMyw3IEBAIHByb3RlY3RlZDoKICAgICBIVE1MTWVk aWFFbGVtZW50KiBtX21lZGlhRWxlbWVudDsgICAKICAgICBQc2V1ZG9JZCBtX3BzZXVkb1N0eWxl SWQ7CiAgICAgTWVkaWFDb250cm9sRWxlbWVudFR5cGUgbV9kaXNwbGF5VHlwZTsgIC8vIHNvbWUg ZWxlbWVudHMgY2FuIHNob3cgbXVsdGlwbGUgdHlwZXMgKGUuZy4gcGxheS9wYXVzZSkKKyAgICBi b29sIG1faXNIaWRkZW47CiB9OwogCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCg== 31882 2009-06-25 15:55:02 -0700 2009-06-25 16:01:11 -0700 patch v4. 003-setHidden-support-v4.diff text/plain 3791 pdherbemont ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTMyMmFkYS4uMzdjNTM4NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0wNi0yNSAgUGllcnJlIGQnSGVy YmVtb250ICA8cGRoZXJiZW1vbnRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1cHBvcnQgaGlkZGluZyBhIGNvbnRyb2wgYmFyIGVs ZW1lbnQgZnJvbSB0aGUgTWVkaWEgZWxlbWVudCBjb250cm9sbGVyLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjY1OQorCisgICAgICAgIE5vIGxh eW91dCB0ZXN0IGNhbiBiZSBkb25lIHNvIGZhciwgYXMgdGhpcyBpcyBub3QgcmVhY2hhYmxlIHRo cm91Z2ggdGhlIERPTS4KKworICAgICAgICAqIHJlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50 cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVRleHREaXNwbGF5RWxlbWVudDo6dXBkYXRl KTogY2FsbCB1cGRhdGVTdHlsZSgpIHNvIGV2ZXJ5dGhpbmcKKyAgICAgICAgaXMgdXBkYXRlZCBw cm9wZXJseS4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbElucHV0RWxlbWVudDo6TWVk aWFDb250cm9sSW5wdXRFbGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbElu cHV0RWxlbWVudDo6dXBkYXRlKTogY2FsbCB1cGRhdGVTdHlsZSgpCisgICAgICAgIChXZWJDb3Jl OjpNZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQ6OnVwZGF0ZVN0eWxlKTogY3JlYXRlIHRoZSByZW5k ZXJlciBwcm9wZXJseQorICAgICAgICBvciBub3QgZGVwZW5kaW5nIG9uIHdoYXQgcmVuZGVyZXJJ c05lZWRlZCgpIHJldHVybi4KKyAgICAgICAgKiByZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVu dHMuaDoKKwogMjAwOS0wNi0yMiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9y ZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvTWVk aWFDb250cm9sRWxlbWVudHMuY3BwCmluZGV4IGQ2NjUxOWEuLmFmYjllZmYgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAorKysgYi9XZWJDb3Jl L3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKQEAgLTEwMSw2ICsxMDEsNyBAQCB2 b2lkIE1lZGlhVGV4dERpc3BsYXlFbGVtZW50Ojp1cGRhdGUoKQogewogICAgIGlmIChyZW5kZXJl cigpKQogICAgICAgICByZW5kZXJlcigpLT51cGRhdGVGcm9tRWxlbWVudCgpOworICAgIHVwZGF0 ZVN0eWxlKCk7CiB9CiAKIHZvaWQgTWVkaWFUZXh0RGlzcGxheUVsZW1lbnQ6OnVwZGF0ZVN0eWxl KCkKQEAgLTEyNSwxMyArMTI2LDcgQEAgTWVkaWFDb250cm9sSW5wdXRFbGVtZW50OjpNZWRpYUNv bnRyb2xJbnB1dEVsZW1lbnQoRG9jdW1lbnQqIGRvYywgUHNldWRvSWQgcHNldWQKICAgICAsIG1f ZGlzcGxheVR5cGUoZGlzcGxheVR5cGUpCiB7CiAgICAgc2V0SW5wdXRUeXBlKHR5cGUpOwotICAg IFJlbmRlclN0eWxlKiBzdHlsZSA9IG1fbWVkaWFFbGVtZW50LT5yZW5kZXJlcigpLT5nZXRDYWNo ZWRQc2V1ZG9TdHlsZShtX3BzZXVkb1N0eWxlSWQpOwotICAgIFJlbmRlck9iamVjdCogcmVuZGVy ZXIgPSBjcmVhdGVSZW5kZXJlcihtX21lZGlhRWxlbWVudC0+cmVuZGVyZXIoKS0+cmVuZGVyQXJl bmEoKSwgc3R5bGUpOwotICAgIGlmIChyZW5kZXJlcikgewotICAgICAgICBzZXRSZW5kZXJlcihy ZW5kZXJlcik7Ci0gICAgICAgIHJlbmRlcmVyLT5zZXRTdHlsZShzdHlsZSk7Ci0gICAgfQotICAg IHNldEF0dGFjaGVkKCk7CisgICAgdXBkYXRlU3R5bGUoKTsKICAgICBzZXRJbkRvY3VtZW50KHRy dWUpOwogfQogCkBAIC0xNDcsMTQgKzE0MiwyOSBAQCB2b2lkIE1lZGlhQ29udHJvbElucHV0RWxl bWVudDo6dXBkYXRlKCkKICAgICB1cGRhdGVEaXNwbGF5VHlwZSgpOwogICAgIGlmIChyZW5kZXJl cigpKQogICAgICAgICByZW5kZXJlcigpLT51cGRhdGVGcm9tRWxlbWVudCgpOworICAgIHVwZGF0 ZVN0eWxlKCk7CiB9CiAKIHZvaWQgTWVkaWFDb250cm9sSW5wdXRFbGVtZW50Ojp1cGRhdGVTdHls ZSgpCiB7Ci0gICAgaWYgKHJlbmRlcmVyKCkgJiYgbV9tZWRpYUVsZW1lbnQtPnJlbmRlcmVyKCkp IHsKLSAgICAgICAgUmVuZGVyU3R5bGUqIHN0eWxlID0gbV9tZWRpYUVsZW1lbnQtPnJlbmRlcmVy KCktPmdldENhY2hlZFBzZXVkb1N0eWxlKG1fcHNldWRvU3R5bGVJZCk7CisgICAgaWYgKCFtX21l ZGlhRWxlbWVudCB8fCAhbV9tZWRpYUVsZW1lbnQtPnJlbmRlcmVyKCkpCisgICAgICAgIHJldHVy bjsKKyAgICAKKyAgICBSZW5kZXJTdHlsZSogc3R5bGUgPSBtX21lZGlhRWxlbWVudC0+cmVuZGVy ZXIoKS0+Z2V0Q2FjaGVkUHNldWRvU3R5bGUobV9wc2V1ZG9TdHlsZUlkKTsKKyAgICAKKyAgICBp ZiAocmVuZGVyZXIoKSAmJiAhcmVuZGVyZXJJc05lZWRlZChzdHlsZSkpCisgICAgICAgIGRldGFj aCgpOworICAgIGVsc2UgaWYgKCFyZW5kZXJlcigpICYmIHJlbmRlcmVySXNOZWVkZWQoc3R5bGUp KSB7CisgICAgICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBjcmVhdGVSZW5kZXJlcihtX21l ZGlhRWxlbWVudC0+cmVuZGVyZXIoKS0+cmVuZGVyQXJlbmEoKSwgc3R5bGUpOworICAgICAgICBp ZiAoIXJlbmRlcmVyKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICByZW5kZXJlci0+c2V0 U3R5bGUoc3R5bGUpOworICAgICAgICBzZXRSZW5kZXJlcihyZW5kZXJlcik7CisgICAgICAgIHNl dEF0dGFjaGVkKCk7CisgICAgICAgIGlmIChwYXJlbnQoKSkKKyAgICAgICAgICAgIHBhcmVudCgp LT5yZW5kZXJlcigpLT5hZGRDaGlsZChyZW5kZXJlciwgbmV4dFNpYmxpbmcoKSA/IG5leHRTaWJs aW5nKCktPnJlbmRlcmVyKCkgOiBOVUxMKTsKKyAgICB9IGVsc2UgaWYgKHJlbmRlcmVyKCkpCiAg ICAgICAgIHJlbmRlcmVyKCktPnNldFN0eWxlKHN0eWxlKTsKLSAgICB9CiB9CiAKIGJvb2wgTWVk aWFDb250cm9sSW5wdXRFbGVtZW50OjpoaXRUZXN0KGNvbnN0IEludFBvaW50JiBhYnNQb2ludCkK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmggYi9X ZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5oCmluZGV4IGQzZTAwNDAuLmRh NGUyZjMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRz LmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuaApAQCAtOTEs NyArOTEsNyBAQCBwdWJsaWM6CiAgICAgTWVkaWFDb250cm9sSW5wdXRFbGVtZW50KERvY3VtZW50 KiwgUHNldWRvSWQsIGNvbnN0IFN0cmluZyYgdHlwZSwgSFRNTE1lZGlhRWxlbWVudCosIE1lZGlh Q29udHJvbEVsZW1lbnRUeXBlKTsKICAgICB2b2lkIGF0dGFjaFRvUGFyZW50KEVsZW1lbnQqKTsK ICAgICB2b2lkIHVwZGF0ZSgpOwotICAgIHZvaWQgdXBkYXRlU3R5bGUoKTsKKyAgICB2aXJ0dWFs IHZvaWQgdXBkYXRlU3R5bGUoKTsKICAgICBib29sIGhpdFRlc3QoY29uc3QgSW50UG9pbnQmIGFi c1BvaW50KTsKICAgICBNZWRpYUNvbnRyb2xFbGVtZW50VHlwZSBkaXNwbGF5VHlwZSgpIGNvbnN0 IHsgcmV0dXJuIG1fZGlzcGxheVR5cGU7IH0KIAo=