26656 2009-06-23 13:22:34 -0700 [Chromium] Fix crash with inherited font-size in <option> 2009-06-24 14:11:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 agl webkit-unassigned adele oldest_to_newest 127668 0 agl 2009-06-23 13:22:34 -0700 In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed the <select> handing for Chromium to fix a rendering bug. However, although the font-size is correctly ignored, getRowHeight wasn't updated and so was calculating the height of the rows in an inconsistent manner. This can lead to a crash. http://code.google.com/p/chromium/issues/detail?id=14810 127670 1 31729 agl 2009-06-23 13:23:53 -0700 Created attachment 31729 patch 127671 2 31730 agl 2009-06-23 13:25:52 -0700 Created attachment 31730 patch Wrong bug link, should be http://code.google.com/p/chromium/issues/detail?id=14853 127763 3 31730 eric 2009-06-23 17:40:33 -0700 Comment on attachment 31730 patch If you're intending the test change to test the crash, you need to add a comment to both the test and the ChangeLog. Since you're a committer, you can do that when you land. Is it not possible to test this change with LayoutTest instead of a manual-test? 127794 4 agl 2009-06-23 19:34:23 -0700 > Is it not possible to test this change with LayoutTest instead of a > manual-test? I tried all manner of window.eventSender ticks to try and get it to trigger the crash, but none of them worked. Testing doesn't work very well with <selects>. 31729 2009-06-23 13:23:53 -0700 2009-06-23 13:25:52 -0700 patch patch text/plain 2166 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDgxOTUyNy4uYTAxNGVhOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0wNi0yMyAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hyb21pdW06IEZpeCBjcmFzaCB3aXRoIGluaGVyaXRlZCBmb250LXNpemUg aW4gPG9wdGlvbj4KKworICAgICAgICBJbiByNDI1OTcgKGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNTI0NCksIEkgY2hhbmdlZAorICAgICAgICB0aGUgPHNlbGVjdD4g aGFuZGluZyBmb3IgQ2hyb21pdW0gdG8gZml4IGEgcmVuZGVyaW5nIGJ1Zy4gSG93ZXZlciwKKyAg ICAgICAgYWx0aG91Z2ggdGhlIGZvbnQtc2l6ZSBpcyBjb3JyZWN0bHkgaWdub3JlZCwgZ2V0Um93 SGVpZ2h0IHdhc24ndAorICAgICAgICB1cGRhdGVkIGFuZCBzbyB3YXMgY2FsY3VsYXRpbmcgdGhl IGhlaWdodCBvZiB0aGUgcm93cyBpbiBhbgorICAgICAgICBpbmNvbnNpc3RlbnQgbWFubmVyLiBU aGlzIGNhbiBsZWFkIHRvIGEgY3Jhc2guCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI2NjU2CisgICAgICAgIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20v cC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTE0ODEwCisKKyAgICAgICAgKiBtYW51YWwtdGVz dHMvb3B0Z3JvdXAtZW1wdHktYW5kLW5lc3RlZC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2No cm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlz dEJveDo6Z2V0Um93SGVpZ2h0KToKKwogMjAwOS0wNi0yMyAgS2V2aW4gTWNDdWxsb3VnaCAgPGtt Y2N1bGxvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNv bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbWFudWFsLXRlc3RzL29wdGdyb3VwLWVtcHR5LWFuZC1u ZXN0ZWQuaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL29wdGdyb3VwLWVtcHR5LWFuZC1uZXN0 ZWQuaHRtbAppbmRleCAwNjI5OTZiLi40MTljMjJkIDEwMDY0NAotLS0gYS9XZWJDb3JlL21hbnVh bC10ZXN0cy9vcHRncm91cC1lbXB0eS1hbmQtbmVzdGVkLmh0bWwKKysrIGIvV2ViQ29yZS9tYW51 YWwtdGVzdHMvb3B0Z3JvdXAtZW1wdHktYW5kLW5lc3RlZC5odG1sCkBAIC0yMSw3ICsyMSw3IEBA CiAgICAgPCEtLSBmb3IgYW4gb3B0Z3JvdXAgd2l0aG91dCBhIGxhYmVsLCBJRSB3aWxsIHNob3cg YW4gZW1wdHksIHVuc2VsZWN0YWJsZSByb3cuCiAgICAgICAgICBGaXJlZm94IGRvZXNuJ3Qgc2hv dyBpdC4gV2UgL2RvLyBzaG93IGl0IGJlY2F1c2Ugc29tZW9uZSBtaWdodCBiZSB1c2luZwogICAg ICAgICAgaXQgYXMgYSBzcGFjZXIuIC0tPgotICAgIDxvcHRncm91cD4KKyAgICA8b3B0Z3JvdXAg c3R5bGU9ImZvbnQtc2l6ZTogeC1sYXJnZTsiPgogICAgICAgPG9wdGlvbiB2YWx1ZT0iMiI+SXRl bSBpbnNpZGUgYW4gb3B0Z3JvdXAgd2l0aG91dCBhIGxhYmVsPC9vcHRpb24+CiAgICAgPC9vcHRn cm91cD4KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVD aHJvbWl1bS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt LmNwcAppbmRleCBlMzQ5MjM5Li5lOWNmYzBmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcApAQCAtOTI1LDcgKzkyNSw3IEBAIGludCBQb3B1 cExpc3RCb3g6OmdldFJvd0hlaWdodChpbnQgaW5kZXgpCiAgICAgaWYgKGluZGV4IDwgMCkKICAg ICAgICAgcmV0dXJuIDA7CiAKLSAgICByZXR1cm4gbV9wb3B1cENsaWVudC0+aXRlbVN0eWxlKGlu ZGV4KS5mb250KCkuaGVpZ2h0KCk7CisgICAgcmV0dXJuIGdldFJvd0ZvbnQoaW5kZXgpLmhlaWdo dCgpOwogfQogCiBJbnRSZWN0IFBvcHVwTGlzdEJveDo6Z2V0Um93Qm91bmRzKGludCBpbmRleCkK 31730 2009-06-23 13:25:52 -0700 2009-06-23 17:40:33 -0700 patch patch text/plain 2166 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDgxOTUyNy4uZWZlYjI0YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0wNi0yMyAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hyb21pdW06IEZpeCBjcmFzaCB3aXRoIGluaGVyaXRlZCBmb250LXNpemUg aW4gPG9wdGlvbj4KKworICAgICAgICBJbiByNDI1OTcgKGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNTI0NCksIEkgY2hhbmdlZAorICAgICAgICB0aGUgPHNlbGVjdD4g aGFuZGluZyBmb3IgQ2hyb21pdW0gdG8gZml4IGEgcmVuZGVyaW5nIGJ1Zy4gSG93ZXZlciwKKyAg ICAgICAgYWx0aG91Z2ggdGhlIGZvbnQtc2l6ZSBpcyBjb3JyZWN0bHkgaWdub3JlZCwgZ2V0Um93 SGVpZ2h0IHdhc24ndAorICAgICAgICB1cGRhdGVkIGFuZCBzbyB3YXMgY2FsY3VsYXRpbmcgdGhl IGhlaWdodCBvZiB0aGUgcm93cyBpbiBhbgorICAgICAgICBpbmNvbnNpc3RlbnQgbWFubmVyLiBU aGlzIGNhbiBsZWFkIHRvIGEgY3Jhc2guCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI2NjU2CisgICAgICAgIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20v cC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTE0ODUzCisKKyAgICAgICAgKiBtYW51YWwtdGVz dHMvb3B0Z3JvdXAtZW1wdHktYW5kLW5lc3RlZC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2No cm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlz dEJveDo6Z2V0Um93SGVpZ2h0KToKKwogMjAwOS0wNi0yMyAgS2V2aW4gTWNDdWxsb3VnaCAgPGtt Y2N1bGxvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNv bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbWFudWFsLXRlc3RzL29wdGdyb3VwLWVtcHR5LWFuZC1u ZXN0ZWQuaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL29wdGdyb3VwLWVtcHR5LWFuZC1uZXN0 ZWQuaHRtbAppbmRleCAwNjI5OTZiLi40MTljMjJkIDEwMDY0NAotLS0gYS9XZWJDb3JlL21hbnVh bC10ZXN0cy9vcHRncm91cC1lbXB0eS1hbmQtbmVzdGVkLmh0bWwKKysrIGIvV2ViQ29yZS9tYW51 YWwtdGVzdHMvb3B0Z3JvdXAtZW1wdHktYW5kLW5lc3RlZC5odG1sCkBAIC0yMSw3ICsyMSw3IEBA CiAgICAgPCEtLSBmb3IgYW4gb3B0Z3JvdXAgd2l0aG91dCBhIGxhYmVsLCBJRSB3aWxsIHNob3cg YW4gZW1wdHksIHVuc2VsZWN0YWJsZSByb3cuCiAgICAgICAgICBGaXJlZm94IGRvZXNuJ3Qgc2hv dyBpdC4gV2UgL2RvLyBzaG93IGl0IGJlY2F1c2Ugc29tZW9uZSBtaWdodCBiZSB1c2luZwogICAg ICAgICAgaXQgYXMgYSBzcGFjZXIuIC0tPgotICAgIDxvcHRncm91cD4KKyAgICA8b3B0Z3JvdXAg c3R5bGU9ImZvbnQtc2l6ZTogeC1sYXJnZTsiPgogICAgICAgPG9wdGlvbiB2YWx1ZT0iMiI+SXRl bSBpbnNpZGUgYW4gb3B0Z3JvdXAgd2l0aG91dCBhIGxhYmVsPC9vcHRpb24+CiAgICAgPC9vcHRn cm91cD4KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVD aHJvbWl1bS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt LmNwcAppbmRleCBlMzQ5MjM5Li5lOWNmYzBmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcApAQCAtOTI1LDcgKzkyNSw3IEBAIGludCBQb3B1 cExpc3RCb3g6OmdldFJvd0hlaWdodChpbnQgaW5kZXgpCiAgICAgaWYgKGluZGV4IDwgMCkKICAg ICAgICAgcmV0dXJuIDA7CiAKLSAgICByZXR1cm4gbV9wb3B1cENsaWVudC0+aXRlbVN0eWxlKGlu ZGV4KS5mb250KCkuaGVpZ2h0KCk7CisgICAgcmV0dXJuIGdldFJvd0ZvbnQoaW5kZXgpLmhlaWdo dCgpOwogfQogCiBJbnRSZWN0IFBvcHVwTGlzdEJveDo6Z2V0Um93Qm91bmRzKGludCBpbmRleCkK