26650 2009-06-23 09:44:17 -0700 Add methods to HistoryItem to support Chromium 2009-06-23 22:01:49 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd oldest_to_newest 127638 0 fishd 2009-06-23 09:44:17 -0700 Add methods to HistoryItem to support Chromium Chromium serializes HistoryItems to store in the browser's session history. To accomplish this requires being able to read the fields of HistoryItem and then later reconstruct a HistoryItem given the same information. The related code would be a lot cleaner if HistoryItem had setFormData and setFormContentType methods. Otherwise, it is necessary to create a dummy ResourceRequest in order to call setFormInfoFromRequest. We also need a way to clear the children of a HistoryItem. That can be done in a hacky fashion by const_cast'ing the const HistoryItemVector& returned from the children() getter, but I think that is a bad idea and should be replaced with a clearChildren method ;-) 127640 1 31722 fishd 2009-06-23 09:49:02 -0700 Created attachment 31722 v1 patch 127644 2 31722 darin 2009-06-23 10:17:52 -0700 Comment on attachment 31722 v1 patch These changes seem OK. I think our future direction is to move history management out of WebKit. r=me 127811 3 fishd 2009-06-23 22:01:49 -0700 Landed as http://trac.webkit.org/changeset/44994 31722 2009-06-23 09:49:02 -0700 2009-06-23 10:17:52 -0700 v1 patch h_1.txt text/plain 2431 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ0OTkz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDYt MjMgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjY2NTAKKworICAgICAgICBBZGQgc2V0Rm9ybUNvbnRlbnRUeXBlIGFu ZCBzZXRGb3JtRGF0YSBzaW5jZSBpdCBpcyBhd2t3YXJkIGZvciBDaHJvbWl1bQorICAgICAgICB0 byB1c2Ugc2V0Rm9ybUluZm9Gcm9tUmVxdWVzdCB0byBzZXQgdGhlIHVuZGVybHlpbmcgbWVtYmVy cy4gIEFsc28sIGFkZAorICAgICAgICBhIGNsZWFyQ2hpbGRyZW4gbWV0aG9kIHRoYXQgQ2hyb21p dW0gbmVlZHMuICBUaGVzZSBtZXRob2RzIGFyZSB1c2VkIGFzCisgICAgICAgIHBhcnQgb2YgdGhl IENocm9taXVtIGNvZGUgdGhhdCBzZXJpYWxpemVzIGEgSGlzdG9yeUl0ZW0gZm9yIHN0b3Jpbmcg aW4KKyAgICAgICAgdGhlIGJyb3dzZXIncyBzZXNzaW9uIGhpc3RvcnkuCisKKyAgICAgICAgKiBo aXN0b3J5L0hpc3RvcnlJdGVtLmNwcDoKKyAgICAgICAgKiBoaXN0b3J5L0hpc3RvcnlJdGVtLmg6 CisKIDIwMDktMDYtMjMgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBoaXN0b3J5L0hpc3RvcnlJ dGVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBoaXN0b3J5L0hpc3RvcnlJdGVtLmNwcAkocmV2aXNpb24g NDQ5OTMpCisrKyBoaXN0b3J5L0hpc3RvcnlJdGVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDM1 LDYgKzQzNSwxMSBAQCBib29sIEhpc3RvcnlJdGVtOjpoYXNDaGlsZHJlbigpIGNvbnN0CiAgICAg cmV0dXJuICFtX2NoaWxkcmVuLmlzRW1wdHkoKTsKIH0KIAordm9pZCBIaXN0b3J5SXRlbTo6Y2xl YXJDaGlsZHJlbigpCit7CisgICAgbV9jaGlsZHJlbi5jbGVhcigpOworfQorCiBTdHJpbmcgSGlz dG9yeUl0ZW06OmZvcm1Db250ZW50VHlwZSgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fZm9ybUNv bnRlbnRUeXBlOwpAQCAtNDU1LDYgKzQ2MCwxNiBAQCB2b2lkIEhpc3RvcnlJdGVtOjpzZXRGb3Jt SW5mb0Zyb21SZXF1ZXN0CiAgICAgfQogfQogCit2b2lkIEhpc3RvcnlJdGVtOjpzZXRGb3JtRGF0 YShQYXNzUmVmUHRyPEZvcm1EYXRhPiBmb3JtRGF0YSkKK3sKKyAgICBtX2Zvcm1EYXRhID0gZm9y bURhdGE7Cit9CisKK3ZvaWQgSGlzdG9yeUl0ZW06OnNldEZvcm1Db250ZW50VHlwZShjb25zdCBT dHJpbmcmIGZvcm1Db250ZW50VHlwZSkKK3sKKyAgICBtX2Zvcm1Db250ZW50VHlwZSA9IGZvcm1D b250ZW50VHlwZTsKK30KKwogRm9ybURhdGEqIEhpc3RvcnlJdGVtOjpmb3JtRGF0YSgpCiB7CiAg ICAgcmV0dXJuIG1fZm9ybURhdGEuZ2V0KCk7CkluZGV4OiBoaXN0b3J5L0hpc3RvcnlJdGVtLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gaGlzdG9yeS9IaXN0b3J5SXRlbS5oCShyZXZpc2lvbiA0NDk5MykKKysr IGhpc3RvcnkvSGlzdG9yeUl0ZW0uaAkod29ya2luZyBjb3B5KQpAQCAtMTIyLDYgKzEyMiw4IEBA IHB1YmxpYzogCiAgICAgdm9pZCBzZXRJc1RhcmdldEl0ZW0oYm9vbCk7CiAgICAgCiAgICAgdm9p ZCBzZXRGb3JtSW5mb0Zyb21SZXF1ZXN0KGNvbnN0IFJlc291cmNlUmVxdWVzdCYpOworICAgIHZv aWQgc2V0Rm9ybURhdGEoUGFzc1JlZlB0cjxGb3JtRGF0YT4pOworICAgIHZvaWQgc2V0Rm9ybUNv bnRlbnRUeXBlKGNvbnN0IFN0cmluZyYpOwogCiAgICAgdm9pZCByZWNvcmRJbml0aWFsVmlzaXQo KTsKIApAQCAtMTM1LDYgKzEzNyw3IEBAIHB1YmxpYzogCiAgICAgSGlzdG9yeUl0ZW0qIHRhcmdl dEl0ZW0oKTsKICAgICBjb25zdCBIaXN0b3J5SXRlbVZlY3RvciYgY2hpbGRyZW4oKSBjb25zdDsK ICAgICBib29sIGhhc0NoaWxkcmVuKCkgY29uc3Q7CisgICAgdm9pZCBjbGVhckNoaWxkcmVuKCk7 CiAKICAgICAvLyBUaGlzIHNob3VsZCBub3QgYmUgY2FsbGVkIGRpcmVjdGx5IGZvciBIaXN0b3J5 SXRlbXMgdGhhdCBhcmUgYWxyZWFkeSBpbmNsdWRlZAogICAgIC8vIGluIEdsb2JhbEhpc3Rvcnku IFRoZSBXZWJLaXQgYXBpIGZvciB0aGlzIGlzIHRvIHVzZSAtW1dlYkhpc3Rvcnkgc2V0TGFzdFZp c2l0ZWRUaW1lSW50ZXJ2YWw6Zm9ySXRlbTpdIGluc3RlYWQuCg==