266359 2023-12-13 12:00:02 -0800 [ews] revert-pull-request-changes step does not appear to delete the build directory 2024-05-13 08:28:06 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235825 InRadar P2 Normal --- 1 emw jbedard aakash_jain ap emw jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1999349 0 emw 2023-12-13 12:00:02 -0800 In builds like https://ews-build.webkit.org/#/builders/14/builds/31777, I see it running `git clean -f -d` only, which is not enough to delete the WebKitBuild directory, since it's gitignore'd. 2001134 1 webkit-bug-importer 2023-12-20 12:00:13 -0800 <rdar://problem/119947440> 2013229 2 aakash_jain 2024-02-13 11:32:36 -0800 In patch workflow we run the step UnApplyPatch which runs Tools/Scripts/clean-webkit. Whereas in PR workflow we run RevertPullRequestChanges step which run this git clean command. I wonder in PR workflow, we un-intentionally stopped doing proper clean build. Note that the same UnApplyPatch wasn't used in PR workflow for reason mentioned in https://bugs.webkit.org/show_bug.cgi?id=235825#c0 , but maybe we can have both UnApplyPatch as well as RevertPullRequestChanges step in PR workflow. 2013231 3 aakash_jain 2024-02-13 11:34:54 -0800 > both UnApplyPatch as well as RevertPullRequestChanges I mean both CleanWorkingDirectory and RevertPullRequestChanges steps. 2034627 4 jbedard 2024-05-10 15:13:47 -0700 I didn't realize we intended to delete the WebKitBuild directory, in this circumstance. 2034632 5 jbedard 2024-05-10 15:25:20 -0700 Pull request: https://github.com/WebKit/WebKit/pull/28412 2034936 6 ews-feeder 2024-05-13 08:28:04 -0700 Committed 278689@main (55a78ab59e0a): <https://commits.webkit.org/278689@main> Reviewed commits have been landed. Closing PR #28412 and removing active labels.