266260 2023-12-11 16:35:41 -0800 Inline SVGTextLayoutAttributes::emptyValue 2024-09-15 10:57:00 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ahmad.saleem792 ahmad.saleem792 rbuis sabouhallawa simon.fraser webkit-bug-importer zimmermann oldest_to_newest 1998829 0 ahmad.saleem792 2023-12-11 16:35:41 -0800 Hi Team, While looking into Blink's commit, I came across another potential merge: Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=195555 "This function just returns a simple float - inlining it allows the compiler to generate more efficient code (and smaller - ~.5k) code since the relatively high overhead call can be eliminated. Take the opportunity to change the "empty value" into NaN (instead of "max() - 1"), with corresponding semantic changes required by that." Just wanted to raise to get input, if it is worthwhile change to merge. Thanks! 2000578 1 webkit-bug-importer 2023-12-18 16:36:16 -0800 <rdar://problem/119839011> 2000746 2 ahmad.saleem792 2023-12-19 09:51:18 -0800 NOTE - It leads to regress following test case: https://web.archive.org/web/20150712020900/http://output.jsbin.com/imajow/1/quiet ^ It start showing nothing. Tested on local build. It is via following changes only: Source/WebCore/rendering/svg/SVGTextLayoutAttributes.cpp <- Source/WebCore/rendering/svg/SVGTextLayoutAttributes.h <- PR Attempt: https://github.com/WebKit/WebKit/pull/22031 2002384 3 ahmad.saleem792 2023-12-31 22:03:19 -0800 It needs some tinkering here in rotation code: https://searchfox.org/wubkat/rev/af9971e796398c1d012ef5df9a09ed580d19bd17/Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp#195 To make the below failing test fixed. NOTE - I closed my PR because again my Git setup screwed-up rebase. 2053567 4 ahmad.saleem792 2024-08-18 06:17:05 -0700 SVN link is gone, so this is link - https://github.com/chromium/chromium/commit/d501a4d0cecb30041be93e549c909f8b3517a3fc 2060305 5 ahmad.saleem792 2024-09-15 06:31:14 -0700 Pull request: https://github.com/WebKit/WebKit/pull/33674 2060322 6 ews-feeder 2024-09-15 10:56:58 -0700 Committed 283684@main (5f8c05ccb28f): <https://commits.webkit.org/283684@main> Reviewed commits have been landed. Closing PR #33674 and removing active labels.