266244 2023-12-11 11:40:52 -0800 REGRESSION(271419@main): [GTK][WPE] Build fails if clang <= 14 2023-12-12 04:48:14 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino webkit-bug-importer oldest_to_newest 1998731 0 dpino 2023-12-11 11:40:52 -0800 WebKitGTK and WPE are failing to build when using clang 14 after 271419@main. This changeset introduced a change that makes use of `std::views::values` in the files: - Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp - Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h It seems clang-14 doesn't support `std::views:values`. Here is a small example that fails to build with clang-14: ``` #include <iostream> #include <map> #include <ranges> int main() { std::map<int, std::string> myMap{ {1, "one"}, {2, "two"}, {3, "three"} }; for (const auto& value : std::views::values(myMap)) { std::cout << "Value: " << value << std::endl; } return 0; } ``` Since this feature is only used in these two files in the entire WebKit codebase, I'd like to revert the changes in those two files, so WebKitGTK and WPE can still be built with clang-14. 1998733 1 dpino 2023-12-11 11:44:08 -0800 Pull request: https://github.com/webkit/webkit/pull/21645 1998933 2 ews-feeder 2023-12-12 04:47:13 -0800 Committed 271921@main (0a646f68779a): <https://commits.webkit.org/271921@main> Reviewed commits have been landed. Closing PR #21645 and removing active labels. 1998934 3 webkit-bug-importer 2023-12-12 04:48:14 -0800 <rdar://problem/119549397>