266199 2023-12-10 17:20:34 -0800 [WTF] Distinguish SerialFunctionDispatcher that are refcounted 2023-12-11 01:20:56 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard webkit-bug-importer oldest_to_newest 1998528 0 jean-yves.avenard 2023-12-10 17:20:34 -0800 Right now, SerialFunctionDispatcher is designed to have an explicit lifetime. All SerialFunctionDispatcher but one are currently ref counted. We need to be able to easily determine if a SerialFunctionDispatcher is refounted by having a RefCountedSerialFunctionDispatcher This change isn't aimed at resolving the SerialFunctionDispatcher API contact, which is there's no guarantee currently that the dispatched runnable will actually be run and that the SerialFunctionDispatcher got shutdown. RefCountedSerialFunctionDispatcher is just about enforcing the lifetime of the object, not the lifetime of the API contract. 1998542 1 jean-yves.avenard 2023-12-10 21:14:54 -0800 Correction: RefCountedSerialFunctionDispatcher will enforce that the function dispatched is guaranteed to run. 1998543 2 webkit-bug-importer 2023-12-10 21:17:38 -0800 <rdar://problem/119476929> 1998544 3 jean-yves.avenard 2023-12-10 21:17:45 -0800 <rdar://problem/119476929> 1998545 4 jean-yves.avenard 2023-12-10 21:22:43 -0800 Pull request: https://github.com/WebKit/WebKit/pull/21617 1998558 5 ews-feeder 2023-12-11 01:20:54 -0800 Committed 271860@main (cfe5a3b9ba53): <https://commits.webkit.org/271860@main> Reviewed commits have been landed. Closing PR #21617 and removing active labels.