266167 2023-12-09 23:01:22 -0800 [Wasm-GC] Fix returned reference in br_on_null in LLInt/B3 2023-12-12 19:50:12 -0800 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 247394 1 asumu webkit-unassigned webkit-bug-importer oldest_to_newest 1998402 0 asumu 2023-12-09 23:01:22 -0800 The following test case using `br_on_null` crashes on some tiers: ``` //@ runWebAssemblySuite("--useWebAssemblyTypedFunctionReferences=true", "--useWebAssemblyGC=true") import * as assert from "../assert.js"; import { compile, instantiate } from "./wast-wrapper.js"; instantiate(` (module (type (struct (field i32))) (func (export "f") (block (struct.new 0 (i32.const 42)) (br_on_null 0) (struct.get 0 0) drop )) ) `).exports.f(); ``` It works fine in BBQJIT, but seems to have issues in LLInt (possibly OMG). The problem is the returned reference on a non-taken branch case is not handled quite right. 1999032 1 asumu 2023-12-12 10:46:57 -0800 Pull request: https://github.com/WebKit/WebKit/pull/21692 1999175 2 ews-feeder 2023-12-12 19:48:47 -0800 Committed 271964@main (4c063193fca3): <https://commits.webkit.org/271964@main> Reviewed commits have been landed. Closing PR #21692 and removing active labels. 1999176 3 webkit-bug-importer 2023-12-12 19:50:12 -0800 <rdar://problem/119590935>