26602 2009-06-22 02:47:56 -0700 Web Inspector: caret moves past prompt in javascript console 2010-03-19 16:07:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 pfeldman apavlov adele commit-queue joepeck justin.garcia timothy oldest_to_newest 127333 0 pfeldman 2009-06-22 02:47:56 -0700 1. Open javascript console 2. Start typing "document" until auto-complete shows up, but don't finish the word 3. Hold backspace What is the expected output? What do you see instead? The caret should stop at the prompt character ">" I'm seeing the caret jump past the prompt character. If you start typing it goes back to normal, but it's a little strange! (upstreaming http://code.google.com/p/chromium/issues/detail?id=14710). 137878 1 joepeck 2009-08-07 08:05:44 -0700 The style on the console-prompt is: -webkit-user-modify: read-write-plaintext-only; min-height: 16px; padding: 1px 22px 1px 24px; position: relative; white-space: pre-wrap; So there is always 24px of padding on the left. I'm guessing that the proprietary "-webkit-user-modify: read-write-plaintext-only" could be causing the problem by incorrectly working with backspace and padding? Attempting to change to margin-left didn't work either. 138161 2 timothy 2009-08-07 14:41:20 -0700 This smells like an editing bug. I actually hit this today doing a demo. 201271 3 51022 apavlov 2010-03-18 07:02:56 -0700 Created attachment 51022 [PATCH] Proposed solution 201335 4 timothy 2010-03-18 09:23:50 -0700 Can you explain how this fixes the bug in the ChangeLog? 201348 5 51037 apavlov 2010-03-18 09:45:57 -0700 Created attachment 51037 [PATCH] Manual removal of empty Text nodes 201353 6 51037 timothy 2010-03-18 09:52:27 -0700 Comment on attachment 51037 [PATCH] Manual removal of empty Text nodes > + var sibling = this.element.firstChild; > + while (sibling) { > + var nextSibling = sibling.nextSibling; > + if (sibling.nodeName === "#text" && sibling.nodeValue === "") > + sibling.parentNode.removeChild(sibling); > + sibling = nextSibling; > + } > + > prefixTextNode.parentNode.insertBefore(this.autoCompleteElement, prefixTextNode.nextSibling); What prevent prefixTextNode from being one of the pruned nodes? Maybe this can be put into a helper function in utilities. Is this the only place it needs to be called? 201354 7 51037 pfeldman 2010-03-18 09:54:05 -0700 Comment on attachment 51037 [PATCH] Manual removal of empty Text nodes > + if (sibling.nodeName === "#text" && sibling.nodeValue === "") Use nodeType === Node.TEXT_NODE instead. 201368 8 51042 apavlov 2010-03-18 10:14:27 -0700 Created attachment 51042 [PATCH] Comments addressed, explanation added to ChangeLog 201369 9 apavlov 2010-03-18 10:16:41 -0700 (In reply to comment #6) > (From update of attachment 51037 [details]) > > + var sibling = this.element.firstChild; > > + while (sibling) { > > + var nextSibling = sibling.nextSibling; > > + if (sibling.nodeName === "#text" && sibling.nodeValue === "") > > + sibling.parentNode.removeChild(sibling); > > + sibling = nextSibling; > > + } > > + > > prefixTextNode.parentNode.insertBefore(this.autoCompleteElement, prefixTextNode.nextSibling); > > What prevent prefixTextNode from being one of the pruned nodes? Maybe this can (a) we never show completions for an empty prefix, (b) an empty prefix can either be there from the outset (which is not the case) or after a deletion of succeeding characters (which is the case we already sanitize) > be put into a helper function in utilities. A good idea, done. > Is this the only place it needs to be called? Added a pruning call next to the other deleteContents(), to be on the safe side. 202072 10 51042 commit-queue 2010-03-19 16:07:13 -0700 Comment on attachment 51042 [PATCH] Comments addressed, explanation added to ChangeLog Clearing flags on attachment: 51042 Committed r56280: <http://trac.webkit.org/changeset/56280> 202073 11 commit-queue 2010-03-19 16:07:18 -0700 All reviewed patches have been landed. Closing bug. 51022 2010-03-18 07:02:56 -0700 2010-03-18 08:02:16 -0700 [PATCH] Proposed solution fixcaret.patch text/plain 1627 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzA1YjAwMi4uNjlhMDI2NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMy0xOCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNhcmV0IG1vdmVzIHBhc3QgcHJv bXB0IGluIGphdmFzY3JpcHQgY29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjY2MDIKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv VGV4dFByb21wdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlw ZS5jbGVhckF1dG9Db21wbGV0ZSk6CisKIDIwMTAtMDMtMTcgIFl1cnkgU2VtaWtoYXRza3kgIDx5 dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKaW5kZXggODU1NGEyOC4u OTEzOTUwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9t cHQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKQEAg LTE0MSw4ICsxNDEsMTAgQEAgV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlID0gewog ICAgICAgICBpZiAoIXRoaXMuYXV0b0NvbXBsZXRlRWxlbWVudCkKICAgICAgICAgICAgIHJldHVy bjsKIAotICAgICAgICBpZiAodGhpcy5hdXRvQ29tcGxldGVFbGVtZW50LnBhcmVudE5vZGUpCi0g ICAgICAgICAgICB0aGlzLmF1dG9Db21wbGV0ZUVsZW1lbnQucGFyZW50Tm9kZS5yZW1vdmVDaGls ZCh0aGlzLmF1dG9Db21wbGV0ZUVsZW1lbnQpOworICAgICAgICBjb25zdCBwcm9tcHRFbGVtZW50 ID0gdGhpcy5hdXRvQ29tcGxldGVFbGVtZW50LnBhcmVudE5vZGU7CisKKyAgICAgICAgaWYgKHBy b21wdEVsZW1lbnQpCisgICAgICAgICAgICBwcm9tcHRFbGVtZW50LnJlbW92ZUNoaWxkKHRoaXMu YXV0b0NvbXBsZXRlRWxlbWVudCk7CiAgICAgICAgIGRlbGV0ZSB0aGlzLmF1dG9Db21wbGV0ZUVs ZW1lbnQ7CiAKICAgICAgICAgaWYgKCF0aGlzLl91c2VyRW50ZXJlZFJhbmdlIHx8ICF0aGlzLl91 c2VyRW50ZXJlZFRleHQpCkBAIC0xNjEsNiArMTYzLDkgQEAgV2ViSW5zcGVjdG9yLlRleHRQcm9t cHQucHJvdG90eXBlID0gewogICAgICAgICBzZWxlY3Rpb24ucmVtb3ZlQWxsUmFuZ2VzKCk7CiAg ICAgICAgIHNlbGVjdGlvbi5hZGRSYW5nZShzZWxlY3Rpb25SYW5nZSk7CiAKKyAgICAgICAgaWYg KHByb21wdEVsZW1lbnQpCisgICAgICAgICAgICBwcm9tcHRFbGVtZW50Lm5vcm1hbGl6ZSgpOwor CiAgICAgICAgIGRlbGV0ZSB0aGlzLl91c2VyRW50ZXJlZFJhbmdlOwogICAgICAgICBkZWxldGUg dGhpcy5fdXNlckVudGVyZWRUZXh0OwogICAgIH0sCg== 51037 2010-03-18 09:45:57 -0700 2010-03-18 10:14:27 -0700 [PATCH] Manual removal of empty Text nodes fixcaret.patch text/plain 1515 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzA1YjAwMi4uZjI5NjA2YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMy0xOCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNhcmV0IG1vdmVzIHBhc3QgcHJv bXB0IGluIGphdmFzY3JpcHQgY29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjY2MDIKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv VGV4dFByb21wdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlw ZS5fY29tcGxldGlvbnNSZWFkeSk6CisKIDIwMTAtMDMtMTcgIFl1cnkgU2VtaWtoYXRza3kgIDx5 dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKaW5kZXggODU1NGEyOC4u YjRlMTNiNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9t cHQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKQEAg LTIzNyw2ICsyMzcsMTQgQEAgV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlID0gewog ICAgICAgICAgICAgdGhpcy5hdXRvQ29tcGxldGVFbGVtZW50LmNsYXNzTmFtZSA9ICJhdXRvLWNv bXBsZXRlLXRleHQiOwogICAgICAgICAgICAgdGhpcy5hdXRvQ29tcGxldGVFbGVtZW50LnRleHRD b250ZW50ID0gc3VmZml4VGV4dDsKIAorICAgICAgICAgICAgdmFyIHNpYmxpbmcgPSB0aGlzLmVs ZW1lbnQuZmlyc3RDaGlsZDsKKyAgICAgICAgICAgIHdoaWxlIChzaWJsaW5nKSB7CisgICAgICAg ICAgICAgICAgdmFyIG5leHRTaWJsaW5nID0gc2libGluZy5uZXh0U2libGluZzsKKyAgICAgICAg ICAgICAgICBpZiAoc2libGluZy5ub2RlTmFtZSA9PT0gIiN0ZXh0IiAmJiBzaWJsaW5nLm5vZGVW YWx1ZSA9PT0gIiIpCisgICAgICAgICAgICAgICAgICAgIHNpYmxpbmcucGFyZW50Tm9kZS5yZW1v dmVDaGlsZChzaWJsaW5nKTsKKyAgICAgICAgICAgICAgICBzaWJsaW5nID0gbmV4dFNpYmxpbmc7 CisgICAgICAgICAgICB9CisKICAgICAgICAgICAgIHByZWZpeFRleHROb2RlLnBhcmVudE5vZGUu aW5zZXJ0QmVmb3JlKHRoaXMuYXV0b0NvbXBsZXRlRWxlbWVudCwgcHJlZml4VGV4dE5vZGUubmV4 dFNpYmxpbmcpOwogCiAgICAgICAgICAgICBmaW5hbFNlbGVjdGlvblJhbmdlLnNldFN0YXJ0KHBy ZWZpeFRleHROb2RlLCB3b3JkUHJlZml4TGVuZ3RoKTsK 51042 2010-03-18 10:14:27 -0700 2010-03-19 16:07:13 -0700 [PATCH] Comments addressed, explanation added to ChangeLog fixcaret.patch text/plain 2573 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzA1YjAwMi4uYWMzNDY5OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMy0xOCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNhcmV0IG1vdmVzIHBhc3QgcHJv bXB0IGluIGphdmFzY3JpcHQgY29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjY2MDIKKworICAgICAgICBIYXZpbmcgbm90aWNlZCBhbnkgRWxl bWVudCBjaGlsZHJlbiBiZXNpZGVzIGEgbGVhZGluZyA8YnI+ICh3aGljaCBhcmUgZW1wdHkKKyAg ICAgICAgdGV4dCBub2RlcyksIFdlYkNvcmUgZWRpdGluZyBmYWNpbGl0eSB0aGlua3MgaXQgc2hv dWxkIGRlbGV0ZSB0aGUgPGJyPiwKKyAgICAgICAgdGh1cyBjbGVhcmluZyBhd2F5IHRoZSB0ZXh0 IHByb21wdCBjb250ZW50cy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGV4dFBy b21wdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZS5jbGVh ckF1dG9Db21wbGV0ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5 cGUuX2NvbXBsZXRpb25zUmVhZHkpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdXRp bGl0aWVzLmpzOgorICAgICAgICAoRWxlbWVudC5wcm90b3R5cGUucHJ1bmVFbXB0eVRleHROb2Rl cyk6CisKIDIwMTAtMDMtMTcgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKaW5kZXggODU1NGEyOC4uOGRlMzY1YSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKKysrIGIvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKQEAgLTE0OSw2ICsxNDksNyBAQCBX ZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm47 CiAKICAgICAgICAgdGhpcy5fdXNlckVudGVyZWRSYW5nZS5kZWxldGVDb250ZW50cygpOworICAg ICAgICB0aGlzLmVsZW1lbnQucHJ1bmVFbXB0eVRleHROb2RlcygpOwogCiAgICAgICAgIHZhciB1 c2VyVGV4dE5vZGUgPSBkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSh0aGlzLl91c2VyRW50ZXJlZFRl eHQpOwogICAgICAgICB0aGlzLl91c2VyRW50ZXJlZFJhbmdlLmluc2VydE5vZGUodXNlclRleHRO b2RlKTsKQEAgLTIyMyw2ICsyMjQsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5 cGUgPSB7CiAgICAgICAgIHRoaXMuX3VzZXJFbnRlcmVkVGV4dCA9IGZ1bGxXb3JkUmFuZ2UudG9T dHJpbmcoKTsKIAogICAgICAgICBmdWxsV29yZFJhbmdlLmRlbGV0ZUNvbnRlbnRzKCk7CisgICAg ICAgIHRoaXMuZWxlbWVudC5wcnVuZUVtcHR5VGV4dE5vZGVzKCk7CiAKICAgICAgICAgdmFyIGZp bmFsU2VsZWN0aW9uUmFuZ2UgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpOwogCmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcwppbmRleCBmMzBhYjlmLi45ZjdkYWFhIDEwMDY0 NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzCisrKyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKQEAgLTIxOSw2ICsyMTksMTcg QEAgRWxlbWVudC5wcm90b3R5cGUucG9zaXRpb25BdCA9IGZ1bmN0aW9uKHgsIHkpCiAgICAgdGhp cy5zdHlsZS50b3AgPSB5ICsgInB4IjsKIH0KIAorRWxlbWVudC5wcm90b3R5cGUucHJ1bmVFbXB0 eVRleHROb2RlcyA9IGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgc2libGluZyA9IHRoaXMuZmlyc3RD aGlsZDsKKyAgICB3aGlsZSAoc2libGluZykgeworICAgICAgICB2YXIgbmV4dFNpYmxpbmcgPSBz aWJsaW5nLm5leHRTaWJsaW5nOworICAgICAgICBpZiAoc2libGluZy5ub2RlVHlwZSA9PT0gdGhp cy5URVhUX05PREUgJiYgc2libGluZy5ub2RlVmFsdWUgPT09ICIiKQorICAgICAgICAgICAgdGhp cy5yZW1vdmVDaGlsZChzaWJsaW5nKTsKKyAgICAgICAgc2libGluZyA9IG5leHRTaWJsaW5nOwor ICAgIH0KK30KKwogTm9kZS5wcm90b3R5cGUuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhOb2RlTmFt ZUluQXJyYXkgPSBmdW5jdGlvbihuYW1lQXJyYXkpCiB7CiAgICAgZm9yICh2YXIgbm9kZSA9IHRo aXM7IG5vZGUgJiYgbm9kZSAhPT0gdGhpcy5vd25lckRvY3VtZW50OyBub2RlID0gbm9kZS5wYXJl bnROb2RlKQo=