26600 2009-06-22 00:54:30 -0700 StringImpl::copy() no longer copies empty string correctly 2009-06-25 21:27:02 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Critical --- 1 ap ap darin mbelshe oldest_to_newest 127317 0 ap 2009-06-22 00:54:30 -0700 StringImpl::copy() should not ever return per-thread empty string, because this function's result is for using on other threads. This was broken in <http://trac.webkit.org/changeset/41917> - StringImpl::create() has a special case for empty strings, so calling it is not appropriate. 127420 1 31663 ap 2009-06-22 12:11:52 -0700 Created attachment 31663 proposed fix 127432 2 ap 2009-06-22 13:14:51 -0700 Committed revision 44952. 128382 3 ap 2009-06-25 21:27:02 -0700 See <rdar://6964477> and its duplicates. 31663 2009-06-22 12:11:52 -0700 2009-06-22 12:46:54 -0700 proposed fix CopyEmptyString.txt text/plain 1669 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDk0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDYtMjIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjYwMAorICAgICAgICBT dHJpbmdJbXBsOjpjb3B5KCkgbm8gbG9uZ2VyIGNvcGllcyBlbXB0eSBzdHJpbmcgY29ycmVjdGx5 CisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L1N0cmluZ0ltcGwuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U3RyaW5nSW1wbDo6dXN0cmluZyk6IENoYW5nZWQgbWV0aG9kIGNhbGxpbmcgc3ludGF4 IHRvIGxvb2sgbGVzcyBsaWtlIGNhbGxpbmcgYQorICAgICAgICBzdGF0aWMgbWV0aG9kLgorICAg ICAgICAoV2ViQ29yZTo6U3RyaW5nSW1wbDo6Y29weSk6IFJldmVydGVkIHBhcnQgb2YgcjQxOTE3 IHRoYXQgY2F1c2VkIHRoZSBwcm9ibGVtLgorCiAyMDA5LTA2LTIyICBYaWFvbWVpIEppICA8eGpp QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbApJbmRleDog V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmluZ0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vdGV4dC9TdHJpbmdJbXBsLmNwcAkocmV2aXNpb24gNDQ5NDIpCisrKyBXZWJD b3JlL3BsYXRmb3JtL3RleHQvU3RyaW5nSW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNDgs NyArMTA0OCw3IEBAIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6Y3JlYXQKIAog SlNDOjpVU3RyaW5nIFN0cmluZ0ltcGw6OnVzdHJpbmcoKQogewotICAgIFNoYXJlZFVDaGFyKiBz aGFyZWRCdWZmZXIgPSBTdHJpbmdJbXBsOjpzaGFyZWRCdWZmZXIoKTsKKyAgICBTaGFyZWRVQ2hh ciogc2hhcmVkQnVmZmVyID0gdGhpcy0+c2hhcmVkQnVmZmVyKCk7CiAgICAgaWYgKHNoYXJlZEJ1 ZmZlcikKICAgICAgICAgcmV0dXJuIEpTQzo6VVN0cmluZzo6UmVwOjpjcmVhdGUoY29uc3RfY2Fz dDxVQ2hhcio+KG1fZGF0YSksIG1fbGVuZ3RoLCBzaGFyZWRCdWZmZXIpOwogCkBAIC0xMDYzLDcg KzEwNjMsOCBAQCBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IFN0cmluZ0ltcGw6OmNyZWF0CiAKIFBh c3NSZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6Y29weSgpCiB7Ci0gICAgcmV0dXJuIGNy ZWF0ZShtX2RhdGEsIG1fbGVuZ3RoKTsKKyAgICAvLyBVc2luZyB0aGUgY29uc3RydWN0b3IgZGly ZWN0bHkgdG8gbWFrZSBzdXJlIHRoYXQgcGVyLXRocmVhZCBlbXB0eSBzdHJpbmcgaW5zdGFuY2Ug aXNuJ3QgcmV0dXJuZWQuCisgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTdHJpbmdJbXBsKG1fZGF0 YSwgbV9sZW5ndGgpKTsKIH0KIAogU3RyaW5nSW1wbDo6U2hhcmVkVUNoYXIqIFN0cmluZ0ltcGw6 OnNoYXJlZEJ1ZmZlcigpCg==