265749 2023-12-03 01:55:01 -0800 REGRESSION(268561@main): generate-bindings-all.pl: [CMake] doesn't account for certain IDL changes 2023-12-04 16:48:43 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=261364 InRadar P2 Normal --- 1 annevk fujii bugs-noreply fujii mcatanzaro webkit-bug-importer oldest_to_newest 1996535 0 annevk 2023-12-03 01:55:01 -0800 https://github.com/WebKit/WebKit/pull/21232 is failing to compile across the Linux bots due to what appears to be the incremental build not realizing the IDL changes are significant. For instance: In file included from /app/webkit/WebKitBuild/WPE/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-109.cpp:2: /app/webkit/WebKitBuild/WPE/Release/WebCore/DerivedSources/JSPerformanceNavigationTiming.cpp: In function ‘JSC::EncodedJSValue WebCore::jsPerformanceNavigationTimingPrototypeFunction_toJSONBody(JSC::JSGlobalObject*, JSC::CallFrame*, JSPerformanceNavigationTiming*)’: /app/webkit/WebKitBuild/WPE/Release/WebCore/DerivedSources/JSPerformanceNavigationTiming.cpp:437:35: error: ‘serverTimingEnabled’ is not a member of ‘WebCore::DeprecatedGlobalSettings’ 1996858 1 fujii 2023-12-04 13:55:56 -0800 The generated JSPerformanceNavigationTiming.dep contains the following line: > JSPerformanceNavigationTiming.h : PerformanceResourceTiming.idl PerformanceEntry.idl If PerformanceResourceTiming.idl is modified, JSPerformanceNavigationTiming.{h,cpp} should be regenerated. This is a regression of 268561@main (bug#261364). 1996863 2 fujii 2023-12-04 14:04:32 -0800 Pull request: https://github.com/WebKit/WebKit/pull/21299 1996866 3 mcatanzaro 2023-12-04 14:22:09 -0800 Is there a reason the dependency file doesn't simply also contain JSPerformanceNavigationTiming.cpp? Why only regenerate the header and not also the generated source file? 1996869 4 ews-feeder 2023-12-04 14:28:58 -0800 Committed 271510@main (e4ad7f1cf28a): <https://commits.webkit.org/271510@main> Reviewed commits have been landed. Closing PR #21299 and removing active labels. 1996870 5 webkit-bug-importer 2023-12-04 14:30:18 -0800 <rdar://problem/119153459> 1996875 6 fujii 2023-12-04 14:35:34 -0800 (In reply to Michael Catanzaro from comment #3) > Is there a reason the dependency file doesn't simply also contain > JSPerformanceNavigationTiming.cpp? Why only regenerate the header and not > also the generated source file? Oh, I missed your comment. generate-bindings.pl gerenates both .cpp and .h at the same time. So, it doesn't need .cpp line in the .dep file. And, generate-bindings-all.pl process only the file line of .dep files at the moment. https://github.com/WebKit/WebKit/blob/906329430eb27e345bf525433f393e8a3912936a/Source/WebCore/bindings/scripts/generate-bindings-all.pl#L201