26570 2009-06-20 01:15:29 -0700 webkit fails to respect :empty with display: none; 2014-06-27 07:36:24 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 79734 1 jerome webkit-unassigned ap bohwaz charette.s frederic.scherma ivovlnni noel.gordon rik simon.fraser webkit.review.bot oldest_to_newest 127118 0 jerome 2009-06-20 01:15:29 -0700 Very easy to reproduce: <style type="text/css"> .e { background-color: red; margin: 5px; width: 90%; } .e:empty { border: display: none; } </style> <div class="e">This is not empty</div> See attached url for a more detailed testcase. 127119 1 31590 jerome 2009-06-20 01:16:15 -0700 Created attachment 31590 Testcase 195791 2 49956 bohwaz 2010-03-03 15:27:14 -0800 Created attachment 49956 Simple test case 195793 3 bohwaz 2010-03-03 15:27:48 -0800 Bug confirmed, :empty is bogus when used with display: none; (see my testcase) 195795 4 rik 2010-03-03 15:35:15 -0800 The two attached testcases confirmed this behavior. The testcase inlined in the first comment is wrong (border: display: none;) but confirm too by removing "border:" 253799 5 charette.s 2010-07-20 10:30:51 -0700 *** Bug 42614 has been marked as a duplicate of this bug. *** 271486 6 ap 2010-08-30 10:13:48 -0700 *** Bug 44871 has been marked as a duplicate of this bug. *** 407417 7 jerome 2011-05-20 17:01:38 -0700 Looks fixed WebKit 534.36 (trunk@86496) 407503 8 ap 2011-05-20 22:34:57 -0700 Thank you for following up! I'm wondering if we should land a regression test for this. 439677 9 noel.gordon 2011-07-20 01:08:46 -0700 (In reply to comment #8) > I'm wondering if we should land a regression test for this. Does fast/css/empty-display-none.html suffice? 440206 10 101547 noel.gordon 2011-07-20 19:38:58 -0700 Created attachment 101547 Patch Add a specific test case for variety. 442100 11 noel.gordon 2011-07-25 21:26:59 -0700 (In reply to comment #8) > Thank you for following up! > > I'm wondering if we should land a regression test for this. Yes we should. Could you review please? 442118 12 101547 ap 2011-07-25 23:09:01 -0700 Comment on attachment 101547 Patch Nice! 442132 13 101547 webkit.review.bot 2011-07-26 00:06:05 -0700 Comment on attachment 101547 Patch Clearing flags on attachment: 101547 Committed r91744: <http://trac.webkit.org/changeset/91744> 442133 14 webkit.review.bot 2011-07-26 00:06:10 -0700 All reviewed patches have been landed. Closing bug. 1018943 15 frederic.scherma 2014-06-27 06:57:32 -0700 In chromium 34 on linux and 35 on osx I've have an issue with a similar case but a bit more complex (see the following jsfiddle): http://jsfiddle.net/YprUV/47/ When 'remove' button is clicked, 'is empty' should appears, but it doesn't without the workaround I've added (the first empty css 'ul:empty {}'). Try to comment it, and then 'is empty' would not appears. 1018955 16 noel.gordon 2014-06-27 07:36:24 -0700 Different because of the combinator perhaps. >In chromium 34 on linux and 35 on osx Please do file a bug at crbug.com 31590 2009-06-20 01:16:15 -0700 2009-06-20 01:16:15 -0700 Testcase css-empty2.html text/html 946 jerome PGh0bWw+PGhlYWQ+PHN0eWxlIHR5cGU9InRleHQvY3NzIj4KYm9keSB7CgliYWNrZ3JvdW5kLWNv bG9yOiAjMWQxZDFkOwoJY29sb3I6IHdoaXRlOwp9Cgoubm90aWNlIHsKCWJhY2tncm91bmQtY29s b3I6IHJlZDsKCW1hcmdpbjogNXB4IGF1dG87Cgl0ZXh0LWFsaWduOiBjZW50ZXI7Cgl3aWR0aDog OTAlOwp9Ci5ub3RpY2U6ZW1wdHkgewoJYm9yZGVyOiAxMHB4IHNvbGlkIGJsdWU7Cn0KCi5ub3Rp Y2UyIHsKCWJhY2tncm91bmQtY29sb3I6IGdyZWVuOwoJYm9yZGVyOiAzcHggc29saWQgcmVkOwoJ bWFyZ2luOiA1cHggYXV0bzsKCXRleHQtYWxpZ246IGNlbnRlcjsKCXdpZHRoOiA5MCU7Cn0KLm5v dGljZTI6ZW1wdHkgewoJZGlzcGxheTogbm9uZTsKfQoKPC9zdHlsZT4KPC9oZWFkPjxib2R5Pgo8 ZGl2IHN0eWxlPSJwYWRkaW5nLWJvdHRvbTogMzBweDsiPjwvZGl2PgpUaGVyZSBzaG91bGQgYmUg YSBicmlnaHQgcmVkIGJveCB1bmRlcm5lYXRoLgo8ZGl2IGNsYXNzPSJub3RpY2UiPgpUaGlzIGJv eCBzaG91bGQgYmUgYnJpZ2h0IHJlZCEKPC9kaXY+Cgo8ZGl2IHN0eWxlPSJwYWRkaW5nLWJvdHRv bTogMzBweDsiPjwvZGl2PgpUaGVyZSBzaG91bGQgYmUgYSBicmlnaHQgYmx1ZSBib3ggdW5kZXJu ZWF0aAo8ZGl2IGNsYXNzPSJub3RpY2UiPjwvZGl2PgoKPGRpdiBzdHlsZT0icGFkZGluZy1ib3R0 b206IDMwcHg7Ij48L2Rpdj4KVGhlcmUgc2hvdWxkIGJlIGEgYnJpZ2h0IGdyZWVuIGJveCB3aXRo IHRoaWNrIHJlZCBib3JkZXJzIHVuZGVybmVhdGguCjxkaXYgY2xhc3M9Im5vdGljZTIiPlRoaXMg Ym94IGlzIGJyaWdodCBncmVlbiE8L2Rpdj4KCjxkaXYgc3R5bGU9InBhZGRpbmctYm90dG9tOiAz MHB4OyI+PC9kaXY+ClRoZXJlIHNob3VsZCBub3RoaW5nIHVuZGVybmVhdGguCjxkaXYgY2xhc3M9 Im5vdGljZTIiPjwvZGl2PgoKCjwvYm9keT4KPC9odG1sPg== 49956 2010-03-03 15:27:14 -0800 2010-03-03 15:27:14 -0800 Simple test case test.html text/html 580 bohwaz PGh0bWw+Cgo8aGVhZD4KICAgIDx0aXRsZT5XZWJraXQgYnVnPC90aXRsZT4KICAgIDxzdHlsZSB0 eXBlPSJ0ZXh0L2NzcyI+CiAgICAucmVkIHsKICAgICAgICBiYWNrZ3JvdW5kOiByZWQ7CiAgICAg ICAgaGVpZ2h0OiAyMHB4OwogICAgfQoKICAgIC5yZWQ6ZW1wdHkgewogICAgICAgIGJhY2tncm91 bmQ6IGdyZWVuOwogICAgfQoKICAgIC53dGY6ZW1wdHkgewogICAgICAgIGRpc3BsYXk6IG5vbmU7 CiAgICB9CiAgICA8L3N0eWxlPgo8L2hlYWQ+Cgo8Ym9keT4KCjxwIGNsYXNzPSJyZWQiPgogICAg VGhpcyBzaG91bGQgYmUgcmVkLiBBbmQgYmVsb3cgaXQgc2hvdWxkIGJlIGdyZWVuLgo8L3A+Cgo8 cCBjbGFzcz0icmVkIj48L3A+Cgo8cD4KICAgIE5vdGhpbmcuCjwvcD4KCjxwIGNsYXNzPSJyZWQg d3RmIj4KICAgIFRoaXMgc2hvdWxkIGJlIHJlZC4gQW5kIGJlbG93IHlvdSBzaG91bGQgc2VlIG5v dGhpbmcuIEJ1dCBhY3R1YWxseSB5b3Ugd29uJ3Qgc2VlIHRoYXQgaW4gd2Via2l0Lgo8L3A+Cgo8 cCBjbGFzcz0icmVkIHd0ZiI+PC9wPgoKPHA+CiAgICBFbmQgb2YgcGFnZS4KPC9wPgoKPC9ib2R5 PgoKPC9odG1sPg== 101547 2011-07-20 19:38:58 -0700 2011-07-26 00:06:05 -0700 Patch empty-display-none.git.diff text/plain 2008 noel.gordon ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZGFmYzQ1Li43OTVlNmVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDct MjAgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisgICAgICAgIEFkZCBy ZWdyZXNzaW9uIHRlc3QgZm9yIDplbXB0eSB7IGRpc3BsYXk6IG5vbmUgfQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY1NzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY3NzL3BzZXVkby1lbXB0 eS1kaXNwbGF5LW5vbmUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9w c2V1ZG8tZW1wdHktZGlzcGxheS1ub25lLmh0bWw6IEFkZGVkLgorCiAyMDExLTA3LTEzICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFtTaGFkb3dDb250ZW50 RWxlbWVudF0gZm9yd2FyZGVkIG5vZGUgc2hvdWxkIGJlIGFibGUgdG8gYWNjZXNzIGl0cyBob3N0 aW5nIGNvbnRlbnQgZWxlbWVudC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Bz ZXVkby1lbXB0eS1kaXNwbGF5LW5vbmUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9j c3MvcHNldWRvLWVtcHR5LWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMC4uZTRiYTliYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvY3NzL3BzZXVkby1lbXB0eS1kaXNwbGF5LW5vbmUtZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEsMyBAQAorVGVzdCBmb3IgYnVnIDI2NTcwLiBUaGVyZSBzaG91bGQgYmUgdHdvIGdyZWVu IGJveGVzIG9uIHRoaXMgcGFnZS4KKworUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9jc3MvcHNldWRvLWVtcHR5LWRpc3BsYXktbm9uZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9j c3MvcHNldWRvLWVtcHR5LWRpc3BsYXktbm9uZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAuLjM0ZGFiMWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9wc2V1ZG8tZW1wdHktZGlzcGxheS1ub25lLmh0bWwKQEAgLTAsMCArMSwyNiBAQAorPHN0 eWxlPgorICBwIHsgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47IHdpZHRoOiAxMDBweDsgaGVpZ2h0 OiAxMDBweCB9CisgIHA6ZW1wdHkgeyBkaXNwbGF5OiBub25lIH0KKzwvc3R5bGU+CisKKzxib2R5 PgorIFRlc3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNjU3MCI+IGJ1ZyAyNjU3MDwvYT4uCisgVGhlcmUgc2hvdWxkIGJlIHR3byBncmVlbiBi b3hlcyBvbiB0aGlzIHBhZ2UuPGJyPgorIDxwPjwvcD4KKyA8cD4mIzA5OzwvcD4KKyA8cD48L3A+ CisgPHA+PHNwYW4+PC9zcGFuPjwvcD4KKyA8cD48L3A+Cis8L2JvZHk+CisKKzxzY3JpcHQ+Cisg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisKKyAgdmFyIGxpc3QgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9y QWxsKCJwIik7CisgIGZvciAodmFyIHJlc3VsdCA9ICIiLCBpID0gMDsgaSA8IGxpc3QubGVuZ3Ro OyArK2kpCisgICAgICByZXN1bHQgKz0gbGlzdC5pdGVtKGkpLm9mZnNldFdpZHRoID09ICgxMDAg KiAoaSAmIDEpKSA/ICJQQVNTICIgOiAiRkFJTCAiOworCisgIHJlc3VsdCA9IGxpc3QubGVuZ3Ro ID09IHJlc3VsdC5tYXRjaCgvUEFTUyAvZykubGVuZ3RoID8gIlBBU1MiIDogIkZBSUwiOworICBk b2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKHJlc3VsdCkp OworPC9zY3JpcHQ+Cg==