26561 2009-06-19 16:40:01 -0700 Remove memcpy from ScriptSourceCode::source() 2009-06-20 02:21:40 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth darin dglazkov levin oldest_to_newest 127064 0 abarth 2009-06-19 16:40:01 -0700 Darin worries that this memcpy might be slow. Patch forthcoming. 127066 1 31574 abarth 2009-06-19 16:44:10 -0700 Created attachment 31574 patch Notice that the string is kept alive anyway because the ScriptSourceCode holds a JSC::SourceCode which holds a RefPtr<SourceProvider> which holds String m_source (via StringSourceProvider : public JSC::SourceProvider). 127069 2 31576 abarth 2009-06-19 16:46:17 -0700 Created attachment 31576 patch Oops. Forgot the const. 127089 3 31574 darin 2009-06-19 18:12:13 -0700 Comment on attachment 31574 patch > + // This same string is actually buried in m_code, but there isn't a clean > + // want to write an accessor for it, so we cache a refernce to it. > + String m_source; "clean want"? How about "clean way"? But I do think there is a clean way to get at it. Just add a source() member to StringSourceProvider, then call static_cast<StringSourceProvider*>(m_code->provider())->source(). 127090 4 31576 darin 2009-06-19 18:12:47 -0700 Comment on attachment 31576 patch It's not really buried all that deeply. I seriously think you could just do static_cast<StringSourceProvider*>(m_code->provider())->source(). r=me 127117 5 abarth 2009-06-20 01:14:24 -0700 > It's not really buried all that deeply. I seriously think you could just do > static_cast<StringSourceProvider*>(m_code->provider())->source(). r=me Ah. I hadn't considered using a static_cast. That should work. 127124 6 abarth 2009-06-20 02:21:40 -0700 Sending WebCore/ChangeLog Sending WebCore/bindings/js/ScriptSourceCode.h Sending WebCore/bindings/js/StringSourceProvider.h Transmitting file data ... Committed revision 44894. 31574 2009-06-19 16:44:10 -0700 2009-06-19 16:46:17 -0700 patch memcpy.patch text/plain 1788 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDg4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDYtMTkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY1NjEKKworICAgICAgICBSZW1v dmUgbWVtY3B5IGJ5IGNhY2hpbmcgYSBjb3B5IG9mIHRoZSBzb3VyY2UgY29kZSBTdHJpbmcuICBU aGlzCisgICAgICAgIGRvZXNuJ3QgYWRkIG1lbW9yeSBvdmVyaGVhZCBiZWNhdXNlIHRoZSBzdHJp bmcgaXMgYWxyZWFkeSBzdG9yZWQgaW4KKyAgICAgICAgdGhpcyBvYmplY3QsIGp1c3QgaW4gYSB3 YXkgdGhhdCdzIG5vdCBhY2Nlc3NpYmxlIGNsZWFubHkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9q cy9TY3JpcHRTb3VyY2VDb2RlLmg6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRTb3VyY2VDb2Rl OjpTY3JpcHRTb3VyY2VDb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFNvdXJjZUNvZGU6 OnNvdXJjZSk6CisKIDIwMDktMDYtMTkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBXZWJDb3Jl L2JpbmRpbmdzL2pzL1NjcmlwdFNvdXJjZUNvZGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL2pzL1NjcmlwdFNvdXJjZUNvZGUuaAkocmV2aXNpb24gNDQ4NzUpCisrKyBXZWJDb3Jl L2JpbmRpbmdzL2pzL1NjcmlwdFNvdXJjZUNvZGUuaAkod29ya2luZyBjb3B5KQpAQCAtNDEsNiAr NDEsNyBAQCBjbGFzcyBTY3JpcHRTb3VyY2VDb2RlIHsKIHB1YmxpYzoKICAgICBTY3JpcHRTb3Vy Y2VDb2RlKGNvbnN0IFN0cmluZyYgc291cmNlLCBjb25zdCBLVVJMJiB1cmwgPSBLVVJMKCksIGlu dCBzdGFydExpbmUgPSAxKQogICAgICAgICA6IG1fY29kZShtYWtlU291cmNlKHNvdXJjZSwgdXJs LmlzTnVsbCgpID8gU3RyaW5nKCkgOiB1cmwuc3RyaW5nKCksIHN0YXJ0TGluZSkpCisgICAgICAg ICwgbV9zb3VyY2Uoc291cmNlKQogICAgIHsKICAgICB9CiAKQEAgLTUzLDExICs1NCwxNCBAQCBw dWJsaWM6CiAKICAgICBjb25zdCBKU0M6OlNvdXJjZUNvZGUmIGpzU291cmNlQ29kZSgpIGNvbnN0 IHsgcmV0dXJuIG1fY29kZTsgfQogCi0gICAgLy8gTm90ZSB0aGUgbWVtY3B5IQotICAgIFN0cmlu ZyBzb3VyY2UoKSBjb25zdCB7IHJldHVybiBTdHJpbmcobV9jb2RlLmRhdGEoKSwgbV9jb2RlLmxl bmd0aCgpKTsgfQorICAgIGNvbnN0IFN0cmluZyYgc291cmNlKCkgeyByZXR1cm4gbV9zb3VyY2U7 IH0KIAogcHJpdmF0ZToKICAgICBKU0M6OlNvdXJjZUNvZGUgbV9jb2RlOworCisgICAgLy8gVGhp cyBzYW1lIHN0cmluZyBpcyBhY3R1YWxseSBidXJpZWQgaW4gbV9jb2RlLCBidXQgdGhlcmUgaXNu J3QgYSBjbGVhbgorICAgIC8vIHdhbnQgdG8gd3JpdGUgYW4gYWNjZXNzb3IgZm9yIGl0LCBzbyB3 ZSBjYWNoZSBhIHJlZmVybmNlIHRvIGl0LgorICAgIFN0cmluZyBtX3NvdXJjZTsKIH07CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYkNvcmUK 31576 2009-06-19 16:46:17 -0700 2009-06-19 18:12:47 -0700 patch memcpy.patch text/plain 1794 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDg4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDYtMTkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY1NjEKKworICAgICAgICBSZW1v dmUgbWVtY3B5IGJ5IGNhY2hpbmcgYSBjb3B5IG9mIHRoZSBzb3VyY2UgY29kZSBTdHJpbmcuICBU aGlzCisgICAgICAgIGRvZXNuJ3QgYWRkIG1lbW9yeSBvdmVyaGVhZCBiZWNhdXNlIHRoZSBzdHJp bmcgaXMgYWxyZWFkeSBzdG9yZWQgaW4KKyAgICAgICAgdGhpcyBvYmplY3QsIGp1c3QgaW4gYSB3 YXkgdGhhdCdzIG5vdCBhY2Nlc3NpYmxlIGNsZWFubHkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9q cy9TY3JpcHRTb3VyY2VDb2RlLmg6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRTb3VyY2VDb2Rl OjpTY3JpcHRTb3VyY2VDb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFNvdXJjZUNvZGU6 OnNvdXJjZSk6CisKIDIwMDktMDYtMTkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBXZWJDb3Jl L2JpbmRpbmdzL2pzL1NjcmlwdFNvdXJjZUNvZGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL2pzL1NjcmlwdFNvdXJjZUNvZGUuaAkocmV2aXNpb24gNDQ4NzUpCisrKyBXZWJDb3Jl L2JpbmRpbmdzL2pzL1NjcmlwdFNvdXJjZUNvZGUuaAkod29ya2luZyBjb3B5KQpAQCAtNDEsNiAr NDEsNyBAQCBjbGFzcyBTY3JpcHRTb3VyY2VDb2RlIHsKIHB1YmxpYzoKICAgICBTY3JpcHRTb3Vy Y2VDb2RlKGNvbnN0IFN0cmluZyYgc291cmNlLCBjb25zdCBLVVJMJiB1cmwgPSBLVVJMKCksIGlu dCBzdGFydExpbmUgPSAxKQogICAgICAgICA6IG1fY29kZShtYWtlU291cmNlKHNvdXJjZSwgdXJs LmlzTnVsbCgpID8gU3RyaW5nKCkgOiB1cmwuc3RyaW5nKCksIHN0YXJ0TGluZSkpCisgICAgICAg ICwgbV9zb3VyY2Uoc291cmNlKQogICAgIHsKICAgICB9CiAKQEAgLTUzLDExICs1NCwxNCBAQCBw dWJsaWM6CiAKICAgICBjb25zdCBKU0M6OlNvdXJjZUNvZGUmIGpzU291cmNlQ29kZSgpIGNvbnN0 IHsgcmV0dXJuIG1fY29kZTsgfQogCi0gICAgLy8gTm90ZSB0aGUgbWVtY3B5IQotICAgIFN0cmlu ZyBzb3VyY2UoKSBjb25zdCB7IHJldHVybiBTdHJpbmcobV9jb2RlLmRhdGEoKSwgbV9jb2RlLmxl bmd0aCgpKTsgfQorICAgIGNvbnN0IFN0cmluZyYgc291cmNlKCkgY29uc3QgeyByZXR1cm4gbV9z b3VyY2U7IH0KIAogcHJpdmF0ZToKICAgICBKU0M6OlNvdXJjZUNvZGUgbV9jb2RlOworCisgICAg Ly8gVGhpcyBzYW1lIHN0cmluZyBpcyBhY3R1YWxseSBidXJpZWQgaW4gbV9jb2RlLCBidXQgdGhl cmUgaXNuJ3QgYSBjbGVhbgorICAgIC8vIHdhbnQgdG8gd3JpdGUgYW4gYWNjZXNzb3IgZm9yIGl0 LCBzbyB3ZSBjYWNoZSBhIHJlZmVybmNlIHRvIGl0LgorICAgIFN0cmluZyBtX3NvdXJjZTsKIH07 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK