265484 2023-11-28 15:30:43 -0800 URLParser should parse URLs including authority and a backslash after the host 2024-02-17 07:06:30 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build All All RESOLVED FIXED BrowserCompat, InRadar P2 Trivial --- 1 account annevk achristensen annevk karlcow mike webkit-bug-importer oldest_to_newest 1995432 0 account 2023-11-28 15:30:43 -0800 WTF:URLParser is unable to parse the text ` `, specifically due to the backslash. In Safari/JSC you can run `new URL` with this string to see an error. Chrome/firefox/node.js all allow parsing this url. The specification defines one case in host state (https://url.spec.whatwg.org/#host-state) where backslash is allowed when using special urls. WTF::URLParser::parse does not seem to handle that. I suspect this is a one line fix around line 1486, but I have not tested the patch. - if (*c == '/' || *c == '?' || *c == '#') { + if (*c == '/' || (m_urlIsSpecial && *c == '\\') || *c == '?' || *c == '#') { 1995488 1 karlcow 2023-11-28 17:59:00 -0800 Dave, thanks for the report. Is there a missing string in the bug report? > the text ` > `, 1995490 2 account 2023-11-28 18:12:06 -0800 Yes it seems the url may have been auto-redacted due to it containing authorization. "http:// a : b @ c \ hello" i've rewritten the url with spaces. it is any "special" (protocol http/https/file and some others) but there is a backslash instead of a forward slash after the host and starting the path name. the url can also have no path but end in a backslash. 1995505 3 karlcow 2023-11-28 18:50:24 -0800 https://searchfox.org/wubkat/rev/c20f54808bd9cd41e49a640e8c20923340e4d14b/Source/WTF/wtf/URLParser.cpp#1480-1500 1995622 4 achristensen 2023-11-29 09:31:57 -0800 I think you're right, Dave. Would you like to make a PR or two, or would you like me to? Either way it should have a test with a special scheme and a test with a non-special scheme. Our tests for this are in LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json and ideally it would have a PR to the WPT repo as well. 1995654 5 account 2023-11-29 11:05:09 -0800 I can work on a PR this weekend. Thanks for pointing me to the tests. 1995659 6 achristensen 2023-11-29 11:14:49 -0800 Sounds good! Let's just make a WebKit PR for now. WPT will be updated with this in due time. This command will help in updating the test results: Tools/Scripts/run-webkit-tests imported/w3c/web-platform-tests/url --reset --no-build 1997249 7 webkit-bug-importer 2023-12-05 15:31:12 -0800 <rdar://problem/119219832> 2014667 8 annevk 2024-02-16 15:08:11 -0800 Pull request: https://github.com/WebKit/WebKit/pull/24657 2014809 9 ews-feeder 2024-02-17 07:06:28 -0800 Committed 274915@main (953476de5074): <https://commits.webkit.org/274915@main> Reviewed commits have been landed. Closing PR #24657 and removing active labels.