265442 2023-11-28 01:44:50 -0800 [TextureMapper] Remove TextureMapperGLHeaders.h 2023-12-05 01:45:16 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=175313 Gtk, InRadar P2 Normal --- 1 cgarcia cgarcia alex fujii webkit-bug-importer oldest_to_newest 1995221 0 cgarcia 2023-11-28 01:44:50 -0800 Just include the GL headers from cpp files only, since it can conflict between epoxy, angle and system headers. 1995224 1 cgarcia 2023-11-28 01:47:22 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20983 1995547 2 cgarcia 2023-11-29 00:39:13 -0800 Grouping the includes in a single header is not the problem, it just makes easier to make a mistake and include the common header from another header. For example, in angle we have ANGLEHeaders.h and it's not a problem as long as it's only included from cpp files and not unified with others, see the comment in the header: // Note: this file can't be compiled in the same unified source file // as others which include the system's OpenGL headers. I can keep the common header if you prefer, but we need to make sure it's never included in headers and cpp files including it are not unified. 1997039 3 webkit-bug-importer 2023-12-05 01:45:16 -0800 <rdar://problem/119176822>