<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>26543</bug_id>
          
          <creation_ts>2009-06-19 09:38:39 -0700</creation_ts>
          <short_desc>WINCE should use &apos;GetLastError&apos; in RegisterFile.h</short_desc>
          <delta_ts>2009-06-19 10:02:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>23154</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Treat">manyoso</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>126945</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Treat">manyoso</who>
    <bug_when>2009-06-19 09:38:39 -0700</bug_when>
    <thetext>WINCE does not use errno, but rather &apos;GetLastError.&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>126948</commentid>
    <comment_count>1</comment_count>
      <attachid>31548</attachid>
    <who name="Adam Treat">manyoso</who>
    <bug_when>2009-06-19 09:52:21 -0700</bug_when>
    <thetext>Created attachment 31548
Use GetLastError on WINCE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>126949</commentid>
    <comment_count>2</comment_count>
      <attachid>31548</attachid>
    <who name="George Staikos">staikos</who>
    <bug_when>2009-06-19 09:54:45 -0700</bug_when>
    <thetext>Comment on attachment 31548
Use GetLastError on WINCE

I think this patch is fine, but I think a future change we should make is to create a WebKitErrno define which will map to the appropriate variable or function call</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>126950</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Treat">manyoso</who>
    <bug_when>2009-06-19 10:02:22 -0700</bug_when>
    <thetext>Landed with r44857.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>31548</attachid>
            <date>2009-06-19 09:52:21 -0700</date>
            <delta_ts>2009-06-19 09:54:45 -0700</delta_ts>
            <desc>Use GetLastError on WINCE</desc>
            <filename>26543.patch</filename>
            <type>text/plain</type>
            <size>2938</size>
            <attacher name="Adam Treat">manyoso</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCBmYjhhOThmLi43Yjc3ZDJhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg
QEAKKzIwMDktMDYtMTkgIFlvbmcgTGkgIDx5b25nLmxpQHRvcmNobW9iaWxlLmNvbT4KKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY1NDMKKyAgICAgICAgV2luZG93cyBDRSB1c2Vz
ICdHZXRMYXN0RXJyb3InIGluc3RlYWQgb2YgJ2Vycm5vLicKKworICAgICAgICAqIGludGVycHJl
dGVyL1JlZ2lzdGVyRmlsZS5oOgorICAgICAgICAoSlNDOjpSZWdpc3RlckZpbGU6OlJlZ2lzdGVy
RmlsZSk6CisgICAgICAgIChKU0M6OlJlZ2lzdGVyRmlsZTo6Z3Jvdyk6CisKIDIwMDktMDYtMTgg
IFlvbmcgTGkgIDx5b25nLmxpQHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVy
L1JlZ2lzdGVyRmlsZS5oIGIvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxl
LmgKaW5kZXggMDlhMzk2My4uM2E2ZTYzYiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvaW50
ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIv
UmVnaXN0ZXJGaWxlLmgKQEAgLTE3NiwxOSArMTc2LDMxIEBAIG5hbWVzcGFjZSBKU0MgewogICAg
ICNpZiBIQVZFKE1NQVApCiAgICAgICAgIG1fYnVmZmVyID0gc3RhdGljX2Nhc3Q8UmVnaXN0ZXIq
PihtbWFwKDAsIGJ1ZmZlckxlbmd0aCwgUFJPVF9SRUFEfFBST1RfV1JJVEUsIE1BUF9QUklWQVRF
fE1BUF9BTk9OLCBWTV9UQUdfRk9SX1JFR0lTVEVSRklMRV9NRU1PUlksIDApKTsKICAgICAgICAg
aWYgKG1fYnVmZmVyID09IE1BUF9GQUlMRUQpIHsKKyNpZiBQTEFURk9STShXSU5DRSkKKyAgICAg
ICAgICAgIGZwcmludGYoc3RkZXJyLCAiQ291bGQgbm90IGFsbG9jYXRlIHJlZ2lzdGVyIGZpbGU6
ICVkXG4iLCBHZXRMYXN0RXJyb3IoKSk7CisjZWxzZQogICAgICAgICAgICAgZnByaW50ZihzdGRl
cnIsICJDb3VsZCBub3QgYWxsb2NhdGUgcmVnaXN0ZXIgZmlsZTogJWRcbiIsIGVycm5vKTsKKyNl
bmRpZgogICAgICAgICAgICAgQ1JBU0goKTsKICAgICAgICAgfQogICAgICNlbGlmIEhBVkUoVklS
VFVBTEFMTE9DKQogICAgICAgICBtX2J1ZmZlciA9IHN0YXRpY19jYXN0PFJlZ2lzdGVyKj4oVmly
dHVhbEFsbG9jKDAsIHJvdW5kVXBBbGxvY2F0aW9uU2l6ZShidWZmZXJMZW5ndGgsIGNvbW1pdFNp
emUpLCBNRU1fUkVTRVJWRSwgUEFHRV9SRUFEV1JJVEUpKTsKICAgICAgICAgaWYgKCFtX2J1ZmZl
cikgeworI2lmIFBMQVRGT1JNKFdJTkNFKQorICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJD
b3VsZCBub3QgYWxsb2NhdGUgcmVnaXN0ZXIgZmlsZTogJWRcbiIsIEdldExhc3RFcnJvcigpKTsK
KyNlbHNlCiAgICAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIkNvdWxkIG5vdCBhbGxvY2F0ZSBy
ZWdpc3RlciBmaWxlOiAlZFxuIiwgZXJybm8pOworI2VuZGlmCiAgICAgICAgICAgICBDUkFTSCgp
OwogICAgICAgICB9CiAgICAgICAgIHNpemVfdCBjb21taXR0ZWRTaXplID0gcm91bmRVcEFsbG9j
YXRpb25TaXplKG1heEdsb2JhbHMgKiBzaXplb2YoUmVnaXN0ZXIpLCBjb21taXRTaXplKTsKICAg
ICAgICAgdm9pZCogY29tbWl0Q2hlY2sgPSBWaXJ0dWFsQWxsb2MobV9idWZmZXIsIGNvbW1pdHRl
ZFNpemUsIE1FTV9DT01NSVQsIFBBR0VfUkVBRFdSSVRFKTsKICAgICAgICAgaWYgKGNvbW1pdENo
ZWNrICE9IG1fYnVmZmVyKSB7CisjaWYgUExBVEZPUk0oV0lOQ0UpCisgICAgICAgICAgICBmcHJp
bnRmKHN0ZGVyciwgIkNvdWxkIG5vdCBhbGxvY2F0ZSByZWdpc3RlciBmaWxlOiAlZFxuIiwgR2V0
TGFzdEVycm9yKCkpOworI2Vsc2UKICAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiQ291bGQg
bm90IGFsbG9jYXRlIHJlZ2lzdGVyIGZpbGU6ICVkXG4iLCBlcnJubyk7CisjZW5kaWYKICAgICAg
ICAgICAgIENSQVNIKCk7CiAgICAgICAgIH0KICAgICAgICAgbV9jb21taXRFbmQgPSByZWludGVy
cHJldF9jYXN0PFJlZ2lzdGVyKj4ocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4obV9idWZmZXIpICsg
Y29tbWl0dGVkU2l6ZSk7CkBAIC0yMjIsNyArMjM0LDExIEBAIG5hbWVzcGFjZSBKU0MgewogICAg
ICAgICBpZiAobmV3RW5kID4gbV9jb21taXRFbmQpIHsKICAgICAgICAgICAgIHNpemVfdCBzaXpl
ID0gcm91bmRVcEFsbG9jYXRpb25TaXplKHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KG5ld0VuZCkg
LSByZWludGVycHJldF9jYXN0PGNoYXIqPihtX2NvbW1pdEVuZCksIGNvbW1pdFNpemUpOwogICAg
ICAgICAgICAgaWYgKCFWaXJ0dWFsQWxsb2MobV9jb21taXRFbmQsIHNpemUsIE1FTV9DT01NSVQs
IFBBR0VfUkVBRFdSSVRFKSkgeworI2lmIFBMQVRGT1JNKFdJTkNFKQorICAgICAgICAgICAgICAg
IGZwcmludGYoc3RkZXJyLCAiQ291bGQgbm90IGFsbG9jYXRlIHJlZ2lzdGVyIGZpbGU6ICVkXG4i
LCBHZXRMYXN0RXJyb3IoKSk7CisjZWxzZQogICAgICAgICAgICAgICAgIGZwcmludGYoc3RkZXJy
LCAiQ291bGQgbm90IGFsbG9jYXRlIHJlZ2lzdGVyIGZpbGU6ICVkXG4iLCBlcnJubyk7CisjZW5k
aWYKICAgICAgICAgICAgICAgICBDUkFTSCgpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAg
bV9jb21taXRFbmQgPSByZWludGVycHJldF9jYXN0PFJlZ2lzdGVyKj4ocmVpbnRlcnByZXRfY2Fz
dDxjaGFyKj4obV9jb21taXRFbmQpICsgc2l6ZSk7Cg==
</data>
<flag name="review"
          id="16187"
          type_id="1"
          status="+"
          setter="staikos"
    />
          </attachment>
      

    </bug>

</bugzilla>