26541 2009-06-19 09:00:27 -0700 CSS property value serialization order is out of whack 2009-10-06 11:31:48 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED http://shopping.pchome.com.tw/?mod=area&func=style_show&RG_NO=DHAC&BB=3c P2 Normal --- 25489 1 dglazkov webkit-unassigned eric hyatt yaar yaar yutak oldest_to_newest 126941 0 dglazkov 2009-06-19 09:00:27 -0700 It appears that color is not in the right order (at the end, instead of in front) when reading node.style.background. Haven't checked other attributes to see if this applies to other things. It looks like CSSOM draft suggests that we follow the same order in which the components are listed in CSS spec. The bug originated here: http://crbug.com/8658 126942 1 31545 dglazkov 2009-06-19 09:01:06 -0700 Created attachment 31545 Test case (almost layout test). 130374 2 32429 yutak 2009-07-07 23:01:31 -0700 Created attachment 32429 Simple fix (which causes test regression) I tried to fix this bug, but I'm facing some difficulties on it. I've got a simple fix (attached) but this causes a test regression that is difficult to handle. LayoutTests/fast/dom/background-shorthand-csstext.html fails, becuase div1's background property value is serialized to "repeat-x, white repeat-y". Apparently this should be "white repeat-x, repeat-y". However, WebKit CSS parser does NOT accept "background: white repeat-x, repeat-y;" as a valid style sheet declaration, so we can't do this. For now, I can't find any resolution that satisfies both CSSOM spec and WebKit parser. It seems too difficult for me to hack the CSS parser (at least for now). By the way, according to CSS2, the value "repeat-x, repeat-y" for background-repeat property is invalid (you can use "repeat" for this purpose). I assume that this is a WebKit extension, but I'm not sure it really is. 130449 3 dglazkov 2009-07-08 10:15:27 -0700 Perhaps you could bring up this issue on #webkit and see if there are ideas that come out of that? 142324 4 38486 yaar 2009-08-24 10:27:08 -0700 Created attachment 38486 A Fix Yuta's fix is correct and the layout test is wrong. WebKit implements CSS3's layered backgrounds, as described here: http://www.w3.org/TR/2008/WD-css3-background-20080910/#layering With layers, repeat-x, repeat-y isn't equivalent to repeat. Rather, it means layer 1 should repeat-x and layer 2 should repeat-y. Also, background-image is by default applied to the last layer. Therefore, the style "background-color:white; background-repeat: repeat-x,repeat-y" should inded serialize into: "repeat-x, white repeat-y". The change list includes Yuta's fix as well as the changes to the layout test that broke. p.s. This is my first submission to WebKit. I hope I adhered to all guidelines. 142395 5 eric 2009-08-24 13:38:54 -0700 In general this looks fine. Could you please point me to the line of the spec where this is required? Ideally your ChangeLog would also include a reference to said line. 142634 6 38486 eric 2009-08-25 10:47:02 -0700 Comment on attachment 38486 A Fix I reviewed another conflicting change to this one yesterday. I believe also from you. Need a spec reference still. r- because this won't apply anymore. 142899 7 yaar 2009-08-26 11:28:34 -0700 See: http://dev.w3.org/csswg/cssom/ Quote: 4.1. Parsing and Serializing CSS Constructs ... 4.1.1. CSS Value Rules ... 8. Where multiple values may appear in any order without changing the meaning of the value (typically represented by a double bar || in the value syntax), user agents are to use the canonical order as given in the syntax (e.g. <border-width> <border-style> <color> for the border short-hand property). 143801 8 yutak 2009-09-01 02:24:24 -0700 Thanks for your follow up, Yaar. I didn't know about layers. I think the patch should be fine if the reference to the CSSOM spec is added. Could you kindly revise the patch? I can do it for you if you don't have enough time. Thanks, 143922 9 yaar 2009-09-01 09:52:46 -0700 Would gladly fix the patch, but where should the reference be placed? 144099 10 yutak 2009-09-01 19:02:13 -0700 In Changelog. Moreover, adding a layout test would be better. 144595 11 yaar 2009-09-03 13:54:02 -0700 As patches that fixes this bug as well as 25489 has been attached to 25489. Once 25489 is closed, this bug can be closed as well. 144658 12 38486 hyatt 2009-09-03 18:17:34 -0700 Comment on attachment 38486 A Fix r=me, totally looks fine. 145085 13 38486 abarth 2009-09-06 21:54:17 -0700 Comment on attachment 38486 A Fix Clearing review flag on obsolete patch 145813 14 yaar 2009-09-09 10:03:36 -0700 Patch to 25489 should have fixed this one as well. 31545 2009-06-19 09:01:06 -0700 2009-06-19 09:01:19 -0700 Test case (almost layout test). css-value-serialization.html text/html 1091 dglazkov PGh0bWw+DQo8aGVhZD4NCjxzY3JpcHQ+DQoNCiAgICBmdW5jdGlvbiB0ZXN0KCkNCiAgICB7DQog ICAgICAgIHZhciBwID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpOw0KICAgICAg ICB2YXIgdGV4dCA9ICJyZ2IoMjU1LCAyNTUsIDI1NSkgbm9uZSByZXBlYXQgc2Nyb2xsIjsNCiAg ICAgICAgcC5zdHlsZS5iYWNrZ3JvdW5kID0gdGV4dDsNCiAgICAgICAgaWYgKHAuc3R5bGUuYmFj a2dyb3VuZCA9PSB0ZXh0KSB7DQogICAgICAgICAgICBwLmlubmVySFRNTCA9ICJUZXN0IFNVQ0NF RURFRCI7DQogICAgICAgIH0gZWxzZSB7DQogICAgICAgICAgICBwLmlubmVySFRNTCA9ICJUZXN0 IEZBSUxFRC4gRXhwZWN0ZWQgPGtiZD4iICsgdGV4dCArICI8L2tiZD4sIGdvdCA8a2JkPiIgKyBw LnN0eWxlLmJhY2tncm91bmQgKyAiPC9rYmQ+IjsNCiAgICAgICAgfQ0KDQogICAgfQ0KDQo8L3Nj cmlwdD4NCjwvaGVhZD4NCjxib2R5IG9ubG9hZD0idGVzdCgpIj4NCjxwPg0KVGhpcyB0ZXN0IHZl cmlmaWVzIHRoZSBvcmRlciBpbiB3aGljaCBDU1MgcHJvcGVydHkgdmFsdWVzIGFyZSBzZXJpYWxp emVkIHVzaW5nIDxjb2RlPmJhY2tncm91bmQ8L2NvZGU+IHByb3BlcnR5Lg0KPHA+DQpBY2NvcmRp bmcgdG8gdGhlIDxhIGhyZWY9Imh0dHA6Ly9kZXYudzMub3JnL2Nzc3dnL2Nzc29tLyNjc3MtdmFs dWUiPkNTU09NPC9hPiBkcmFmdCwgdGhlIG9yZGVyIG9mIHNlcmlhbGl6ZWQgcHJvcGVydHkgdmFs dWUgc2hvdWxkIGJlIHRoZSBzYW1lIGFzDQp0aGUgb3JkZXIgaW4gd2hpY2ggdGhlIGVsZW1lbnRz IGFwcGVhciBpbiBDU1MyIHNwZWMsIHdoaWNoIGZvciB0aGUgDQo8YSBocmVmPSJodHRwOi8vd3d3 LnczLm9yZy9UUi9DU1MyL2NvbG9ycy5odG1sI2JhY2tncm91bmQiPmJhY2tncm91bmQ8L2E+IHBy b3BlcnR5IGlzOg0KPHVsPg0KPGxpPmJhY2tncm91bmQtY29sb3INCjxsaT5iYWNrZ3JvdW5kLWlt YWdlDQo8bGk+YmFja2dyb3VuZC1yZXBlYXQNCjwvbGk+YmFja2dyb3VuZC1hdHRhY2htZW50DQo8 L2xpPmJhY2tncm91bmQtcG9zaXRpb24NCjwvdWw+DQo8cCBpZD0icmVzdWx0Ij4NCjwvYm9keT4N CjwvaHRtbD4= 32429 2009-07-07 23:01:31 -0700 2009-09-03 12:07:51 -0700 Simple fix (which causes test regression) 26541-v1.patch text/plain 1089 yutak ZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU011dGFibGVTdHlsZURlY2xhcmF0aW9uLmNwcCBi L1dlYkNvcmUvY3NzL0NTU011dGFibGVTdHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCA2N2I3ZGEx Li5hZDU2MzJlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NNdXRhYmxlU3R5bGVEZWNsYXJh dGlvbi5jcHAKKysrIGIvV2ViQ29yZS9jc3MvQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uY3Bw CkBAIC0xMTUsOSArMTE1LDkgQEAgU3RyaW5nIENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uOjpn ZXRQcm9wZXJ0eVZhbHVlKGludCBwcm9wZXJ0eUlEKSBjb25zdAogICAgICAgICAgICAgcmV0dXJu IGdldExheWVyZWRTaG9ydGhhbmRWYWx1ZShwcm9wZXJ0aWVzLCAyKTsKICAgICAgICAgfQogICAg ICAgICBjYXNlIENTU1Byb3BlcnR5QmFja2dyb3VuZDogewotICAgICAgICAgICAgY29uc3QgaW50 IHByb3BlcnRpZXNbN10gPSB7IENTU1Byb3BlcnR5QmFja2dyb3VuZEltYWdlLCBDU1NQcm9wZXJ0 eUJhY2tncm91bmRSZXBlYXQsIAorICAgICAgICAgICAgY29uc3QgaW50IHByb3BlcnRpZXNbN10g PSB7IENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yLCBDU1NQcm9wZXJ0eUJhY2tncm91bmRJbWFn ZSwgQ1NTUHJvcGVydHlCYWNrZ3JvdW5kUmVwZWF0LCAKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBDU1NQcm9wZXJ0eUJhY2tncm91bmRBdHRhY2htZW50LCBDU1NQcm9w ZXJ0eUJhY2tncm91bmRQb3NpdGlvbiwgQ1NTUHJvcGVydHlXZWJraXRCYWNrZ3JvdW5kQ2xpcCwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBDU1NQcm9wZXJ0eVdlYmtp dEJhY2tncm91bmRPcmlnaW4sIENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yIH07CisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQ1NTUHJvcGVydHlXZWJraXRCYWNrZ3Jv dW5kT3JpZ2luIH07CiAgICAgICAgICAgICByZXR1cm4gZ2V0TGF5ZXJlZFNob3J0aGFuZFZhbHVl KHByb3BlcnRpZXMsIDcpOwogICAgICAgICB9CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlCb3Jk ZXI6IHsK 38486 2009-08-24 10:27:08 -0700 2009-10-06 11:31:48 -0700 A Fix BackgroundOrderFix.txt text/plain 3921 yaar SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzcxNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDgtMjQgIFlhYXIgU2Nobml0bWFuICA8eWFhckBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1h ZGUgQ1NTIGJhY2tncm91bmQtY29sb3IgYmUgc2VyaWFsaXplZCBiZWZvcmUgb3RoZXIgYmFja2dy b3VuZCBwcm9wZXJ0aWVzLCBhcyBDU1Mgc3BlY2lmaWNhdGlvbiByZXF1aXJlcy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NTQxCisKKyAgICAgICAg KiBjc3MvQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb246OmdldFByb3BlcnR5VmFsdWUpOgorCiAyMDA5LTA4 LTI0ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KSW5kZXg6IFdlYkNvcmUvY3NzL0NTU011dGFibGVT dHlsZURlY2xhcmF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NNdXRhYmxl U3R5bGVEZWNsYXJhdGlvbi5jcHAJKHJldmlzaW9uIDQ3NjQ3KQorKysgV2ViQ29yZS9jc3MvQ1NT TXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTUsOSArMTE1 LDkgQEAgU3RyaW5nIENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uOjpnZXRQcgogICAgICAgICAg ICAgcmV0dXJuIGdldExheWVyZWRTaG9ydGhhbmRWYWx1ZShwcm9wZXJ0aWVzLCAyKTsKICAgICAg ICAgfQogICAgICAgICBjYXNlIENTU1Byb3BlcnR5QmFja2dyb3VuZDogewotICAgICAgICAgICAg Y29uc3QgaW50IHByb3BlcnRpZXNbN10gPSB7IENTU1Byb3BlcnR5QmFja2dyb3VuZEltYWdlLCBD U1NQcm9wZXJ0eUJhY2tncm91bmRSZXBlYXQsIAorICAgICAgICAgICAgY29uc3QgaW50IHByb3Bl cnRpZXNbN10gPSB7IENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yLCBDU1NQcm9wZXJ0eUJhY2tn cm91bmRJbWFnZSwgQ1NTUHJvcGVydHlCYWNrZ3JvdW5kUmVwZWF0LCAKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBDU1NQcm9wZXJ0eUJhY2tncm91bmRBdHRhY2htZW50 LCBDU1NQcm9wZXJ0eUJhY2tncm91bmRQb3NpdGlvbiwgQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ2xp cCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBDU1NQcm9wZXJ0eUJh Y2tncm91bmRPcmlnaW4sIENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yIH07CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQ1NTUHJvcGVydHlCYWNrZ3JvdW5kT3JpZ2lu IH07CiAgICAgICAgICAgICByZXR1cm4gZ2V0TGF5ZXJlZFNob3J0aGFuZFZhbHVlKHByb3BlcnRp ZXMsIDcpOwogICAgICAgICB9CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlCb3JkZXI6IHsKSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDQ3NzE3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDgtMjQgIFlhYXIgU2Nobml0bWFuICA8eWFh ckBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1hZGUgQ1NTIGJhY2tncm91bmQtY29sb3IgYmUgc2VyaWFsaXplZCBiZWZvcmUgb3Ro ZXIgYmFja2dyb3VuZCBwcm9wZXJ0aWVzLCBhcyBDU1Mgc3BlY2lmaWNhdGlvbiByZXF1aXJlcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NTQxCisK KyAgICAgICAgKiBmYXN0L2RvbS9iYWNrZ3JvdW5kLXNob3J0aGFuZC1jc3N0ZXh0LWV4cGVjdGVk LnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9iYWNrZ3JvdW5kLXNob3J0aGFuZC1jc3N0ZXh0Lmh0 bWw6CisKIDIwMDktMDgtMjQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9iYWNrZ3JvdW5kLXNob3J0aGFuZC1jc3N0ZXh0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9iYWNrZ3JvdW5kLXNob3J0aGFuZC1jc3N0ZXh0LWV4cGVj dGVkLnR4dAkocmV2aXNpb24gNDc2NDcpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9iYWNrZ3Jv dW5kLXNob3J0aGFuZC1jc3N0ZXh0LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw1 ICsxLDUgQEAKIFRoaXMgcGFnZSB0ZXN0cyB3aGV0aGVyIG9yIG5vdCB0aGUgYmFja2dyb3VuZCBz aG9ydGhhbmQgcHJvcGVybHkgb21pdHMgaW5pdGlhbCB2YWx1ZXMuCiAKIFBBU1M6IGRvY3VtZW50 LmJvZHkuc3R5bGUuYmFja2dyb3VuZCA9PSAnZ3JlZW4nIHNob3VsZCBiZSB0cnVlIGFuZCBpcy4K LVBBU1M6IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdkaXYxJykuc3R5bGUuYmFja2dyb3VuZCA9 PSAncmVwZWF0LXgsIHJlcGVhdC15IHdoaXRlJyBzaG91bGQgYmUgdHJ1ZSBhbmQgaXMuCitQQVNT OiBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZGl2MScpLnN0eWxlLmJhY2tncm91bmQgPT0gJ3Jl cGVhdC14LCB3aGl0ZSByZXBlYXQteScgc2hvdWxkIGJlIHRydWUgYW5kIGlzLgogRkFJTDogZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2RpdjInKS5zdHlsZS5iYWNrZ3JvdW5kID09ICc1MCUgNTAl IGJsdWUnIHNob3VsZCBiZSB0cnVlIGJ1dCBpbnN0ZWFkIGlzIGZhbHNlLgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9kb20vYmFja2dyb3VuZC1zaG9ydGhhbmQtY3NzdGV4dC5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2JhY2tncm91bmQtc2hvcnRoYW5kLWNzc3RleHQu aHRtbAkocmV2aXNpb24gNDc2NDcpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9iYWNrZ3JvdW5k LXNob3J0aGFuZC1jc3N0ZXh0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDcgQEAg ZnVuY3Rpb24gdGVzdCgpIAogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7CiAgICAgCiAgICAgc2hvdWxkQmUoImRvY3VtZW50LmJvZHkuc3R5bGUuYmFja2dyb3VuZCA9 PSAnZ3JlZW4nIiwgdHJ1ZSk7Ci0gICAgc2hvdWxkQmUoImRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdkaXYxJykuc3R5bGUuYmFja2dyb3VuZCA9PSAncmVwZWF0LXgsIHJlcGVhdC15IHdoaXRlJyIs IHRydWUpOworICAgIHNob3VsZEJlKCJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZGl2MScpLnN0 eWxlLmJhY2tncm91bmQgPT0gJ3JlcGVhdC14LCB3aGl0ZSByZXBlYXQteSciLCB0cnVlKTsKICAg ICBzaG91bGRCZSgiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2RpdjInKS5zdHlsZS5iYWNrZ3Jv dW5kID09ICc1MCUgNTAlIGJsdWUnIiwgdHJ1ZSk7CiB9CiA8L3NjcmlwdD4K