<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>265363</bug_id>
          
          <creation_ts>2023-11-26 22:41:54 -0800</creation_ts>
          <short_desc>Decouple BitmapImage sources and main functions into separate classes</short_desc>
          <delta_ts>2024-09-05 13:33:38 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Images</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=271979</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=271977</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=274478</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=275999</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=277495</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=278593</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=279221</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>268127</dependson>
    
    <dependson>267254</dependson>
    
    <dependson>267570</dependson>
    
    <dependson>267571</dependson>
    
    <dependson>267607</dependson>
    
    <dependson>268184</dependson>
    
    <dependson>269626</dependson>
    
    <dependson>271977</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Said Abou-Hallawa">sabouhallawa</reporter>
          <assigned_to name="Said Abou-Hallawa">sabouhallawa</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>sabouhallawa</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1994866</commentid>
    <comment_count>0</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2023-11-26 22:41:54 -0800</bug_when>
    <thetext>This class is needlessly complicated which makes it difficult to hack. It handles

1. NativeImage and ImageSource images
2. Static and animated images
3. Async and sync image decoding

It also supports lots of testing APIs and tuning and corner cases. What we need is a simple and clear design interface which splits these cases and tuning nicely. This will make changing the class a lot easier in the future.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1994867</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-11-26 22:42:32 -0800</bug_when>
    <thetext>&lt;rdar://problem/118819338&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1994868</commentid>
    <comment_count>2</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2023-11-26 22:48:59 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/20916</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2014019</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-02-15 11:04:09 -0800</bug_when>
    <thetext>Committed 274746@main (055031e5c8a8): &lt;https://commits.webkit.org/274746@main&gt;

Reviewed commits have been landed. Closing PR #20916 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2014715</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2024-02-16 16:21:14 -0800</bug_when>
    <thetext>Re-opened since this is blocked by bug 269626</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2014776</commentid>
    <comment_count>5</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2024-02-16 21:49:20 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/24678</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2024722</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-03-29 06:50:53 -0700</bug_when>
    <thetext>Committed 276827@main (8b78e07f7be5): &lt;https://commits.webkit.org/276827@main&gt;

Reviewed commits have been landed. Closing PR #24678 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025155</commentid>
    <comment_count>7</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2024-04-01 12:17:14 -0700</bug_when>
    <thetext>*** Bug 268184 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>