265320 2023-11-24 09:35:12 -0800 Fix WebLocalFrameLoaderClient debug build with gcc 2023-12-01 10:22:48 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=258551 InRadar P2 Normal --- 1 olivier.blin webkit-unassigned achristensen pgorszkowski webkit-bug-importer oldest_to_newest 1994682 0 olivier.blin 2023-11-24 09:35:12 -0800 Like done in 265546@main for bug 258551 /app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: In member function ‘virtual void WebKit::WebLocalFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()’: /app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:115:27: error: format ‘%hhu’ expects argument of type ‘int’, but argument 10 has type ‘WebCore::FrameState’ [-Werror=format=] 115 | #define PREFIX_PARAMETERS "%p - [webFrame=%p, webFrameID=%" PRIu64 ", webPage=%p, webPageID=%" PRIu64 "] WebLocalFrameLoaderClient::" | ^ /app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/Assertions.h:514:80: note: in definition of macro ‘LOG_ERROR’ 514 | #define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__) | ^~~~~~~~~~~ /app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:122:72: note: in expansion of macro ‘RELEASE_LOG_FAULT’ 122 | #define WebLocalFrameLoaderClient_RELEASE_LOG_FAULT(channel, fmt, ...) RELEASE_LOG_FAULT(channel, PREFIX_PARAMETERS fmt, this, WEBFRAME, WEBFRAMEID, WEBPAGE, WEBPAGEID, ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~~ /app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:122:99: note: in expansion of macro ‘PREFIX_PARAMETERS’ 122 | #define WebLocalFrameLoaderClient_RELEASE_LOG_FAULT(channel, fmt, ...) RELEASE_LOG_FAULT(channel, PREFIX_PARAMETERS fmt, this, WEBFRAME, WEBFRAMEID, WEBPAGE, WEBPAGEID, ##__VA_ARGS__) | ^~~~~~~~~~~~~~~~~ /app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:365:9: note: in expansion of macro ‘WebLocalFrameLoaderClient_RELEASE_LOG_FAULT’ 365 | WebLocalFrameLoaderClient_RELEASE_LOG_FAULT(Loading, "dispatchDidReceiveServerRedirectForProvisionalLoad: Called with no provisional DocumentLoader (frameState=%hhu, stateForDebugging=%i)", m_frame->coreLocalFrame()->loader().state(), m_frame->coreLocalFrame()->loader().stateMachine().stateForDebugging()); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1994686 1 olivier.blin 2023-11-24 09:54:52 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20877 1996256 2 webkit-bug-importer 2023-12-01 09:36:19 -0800 <rdar://problem/119038138> 1996268 3 ews-feeder 2023-12-01 10:22:46 -0800 Committed 271390@main (6ec18aaa5cc9): <https://commits.webkit.org/271390@main> Reviewed commits have been landed. Closing PR #20877 and removing active labels.