26531 2009-06-18 21:56:53 -0700 Timezone calculation incorrect in Venezuela. 2009-06-18 22:07:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 126878 0 barraclough 2009-06-18 21:56:53 -0700 The problem is that we're calculating the timezone relative to 01/01/2000, but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007. According to the spec, section 15.9.1.9 states "the time since the beginning of the year", presumably meaning the *current* year. Change the calculation to be based on whatever the current year is, rather than a canned date. 126879 1 31532 barraclough 2009-06-18 21:58:48 -0700 Created attachment 31532 The patch 126880 2 31532 ggaren 2009-06-18 22:02:48 -0700 Comment on attachment 31532 The patch r=me assuming all JSC tests pass 126881 3 barraclough 2009-06-18 22:07:24 -0700 Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/wtf/DateMath.cpp Transmitting file data .. Committed revision 44842. 31532 2009-06-18 21:58:48 -0700 2009-06-18 22:02:48 -0700 The patch patch.caracas.txt text/plain 2196 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ0ODM4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMDktMDYt MTggIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRpbWV6b25lIGNhbGN1bGF0 aW9uIGluY29ycmVjdCBpbiBWZW5lenVlbGEuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NTMxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NjQ2 MTY5PiBUaW1lIGlzIGluY29ycmVjdGx5IHJlcG9ydGVkIHRvIEphdmFTY3JpcHQgaW4gYm90aCBT YWZhcmkgMyBhbmQgRmlyZWZveCAzCisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgdGhhdCB3ZSdy ZSBjYWxjdWxhdGluZyB0aGUgdGltZXpvbmUgcmVsYXRpdmUgdG8gMDEvMDEvMjAwMCwKKyAgICAg ICAgYnV0IHRoZSBWRVQgdGltZXpvbmUgY2hhbmdlZCBmcm9tIC00IGhvdXJzIHRvIC00OjMwIGhv dXJzIG9uIDEyLzA5LzIwMDcuCisgICAgICAgIEFjY29yZGluZyB0byB0aGUgc3BlYywgc2VjdGlv biAxNS45LjEuOSBzdGF0ZXMgInRoZSB0aW1lIHNpbmNlIHRoZSBiZWdpbm5pbmcKKyAgICAgICAg b2YgdGhlIHllYXIiLCBwcmVzdW1hYmx5IG1lYW5pbmcgdGhlICpjdXJyZW50KiB5ZWFyLiAgQ2hh bmdlIHRoZSBjYWxjdWxhdGlvbgorICAgICAgICB0byBiZSBiYXNlZCBvbiB3aGF0ZXZlciB0aGUg Y3VycmVudCB5ZWFyIGlzLCByYXRoZXIgdGhhbiBhIGNhbm5lZCBkYXRlLgorCisgICAgICAgIE5v IHBlcmZvcm1hbmNlIGltcGFjdC4KKworICAgICAgICAqIHd0Zi9EYXRlTWF0aC5jcHA6CisgICAg ICAgIChXVEY6OmNhbGN1bGF0ZVVUQ09mZnNldCk6CisKIDIwMDktMDYtMTggIEdhdmluIEJhcnJh Y2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlciBTdGFtcGVk IGJ5IE1hcmsgUm93ZSAob3JpZ2luYWxseSByZXZpZXdlZCBieSBTYW0gV2VpbmlnKS4KSW5kZXg6 IHd0Zi9EYXRlTWF0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gd3RmL0RhdGVNYXRoLmNwcAkocmV2aXNp b24gNDQ4MzcpCisrKyB3dGYvRGF0ZU1hdGguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjEsMTMg KzM2MSwyMyBAQCBpbnQgZXF1aXZhbGVudFllYXJGb3JEU1QoaW50IHllYXIpCiAKIHN0YXRpYyBp bnQzMl90IGNhbGN1bGF0ZVVUQ09mZnNldCgpCiB7CisgICAgdGltZV90IGxvY2FsVGltZSA9IHRp bWUoMCk7CiAgICAgdG0gbG9jYWx0OwotICAgIG1lbXNldCgmbG9jYWx0LCAwLCBzaXplb2YobG9j YWx0KSk7Ci0gCi0gICAgLy8gZ2V0IHRoZSBkaWZmZXJlbmNlIGJldHdlZW4gdGhpcyB0aW1lIHpv bmUgYW5kIFVUQyBvbiBKYW4gMDEsIDIwMDAgMTI6MDA6MDAgQU0KKyAgICBnZXRMb2NhbFRpbWUo JmxvY2FsVGltZSwgJmxvY2FsdCk7CisKKyAgICAvLyBHZXQgdGhlIGRpZmZlcmVuY2UgYmV0d2Vl biB0aGlzIHRpbWUgem9uZSBhbmQgVVRDIG9uIHRoZSAxc3Qgb2YgSmFudWFyeSBvZiB0aGlzIHll YXIuCisgICAgbG9jYWx0LnRtX3NlYyA9IDA7CisgICAgbG9jYWx0LnRtX21pbiA9IDA7CisgICAg bG9jYWx0LnRtX2hvdXIgPSAwOwogICAgIGxvY2FsdC50bV9tZGF5ID0gMTsKLSAgICBsb2NhbHQu dG1feWVhciA9IDEwMDsKLSAgICB0aW1lX3QgdXRjT2Zmc2V0ID0gOTQ2Njg0ODAwIC0gbWt0aW1l KCZsb2NhbHQpOworICAgIGxvY2FsdC50bV9tb24gPSAwOworICAgIC8vIE5vdCBzZXR0aW5nIGxv Y2FsdC50bV95ZWFyIQorICAgIGxvY2FsdC50bV93ZGF5ID0gMDsKKyAgICBsb2NhbHQudG1feWRh eSA9IDA7CisgICAgbG9jYWx0LnRtX2lzZHN0ID0gMDsKKyAgICBsb2NhbHQudG1fem9uZSA9IDA7 CisgICAgbG9jYWx0LnRtX2dtdG9mZiA9IDA7CisgICAgdGltZV90IHV0Y09mZnNldCA9IHRpbWVn bSgmbG9jYWx0KSAtIG1rdGltZSgmbG9jYWx0KTsKIAogICAgIHJldHVybiBzdGF0aWNfY2FzdDxp bnQzMl90Pih1dGNPZmZzZXQgKiAxMDAwKTsKIH0K