<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>265286</bug_id>
          
          <creation_ts>2023-11-23 06:11:01 -0800</creation_ts>
          <short_desc>[WPE] Upstream the new WPE platform API</short_desc>
          <delta_ts>2023-12-12 08:34:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=266278</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Diego Pino">dpino</assigned_to>
          <cc>aperez</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>dpino</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1994537</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2023-11-23 06:11:01 -0800</bug_when>
    <thetext>We have enough code already to see this is the way we want to go, so we can continue working upstream.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1994538</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2023-11-23 06:34:50 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/20848</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1995839</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-11-30 02:17:19 -0800</bug_when>
    <thetext>Committed 271330@main (b12e7ed2ad3a): &lt;https://commits.webkit.org/271330@main&gt;

Reviewed commits have been landed. Closing PR #20848 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1996181</commentid>
    <comment_count>3</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-12-01 03:53:35 -0800</bug_when>
    <thetext>Bot WPE-Linux-64-bit-Release-Ubuntu-LTS-Build is failing with the following error:

```
/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-LTS-Build/build/Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp:114:12: error: ‘g_unix_fd_list_get’ was not declared in this scope
  114 |     return g_unix_fd_list_get(fdList.get(), handler, nullptr);
      |            ^~~~~~~~~~~~~~~~~~
```

https://build.webkit.org/#/builders/232/builds/24386</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1996182</commentid>
    <comment_count>4</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-12-01 03:54:11 -0800</bug_when>
    <thetext>Re-opening for pull request https://github.com/webkit/webkit/pull/21153</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1996184</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-12-01 04:02:31 -0800</bug_when>
    <thetext>Committed 271376@main (a2701c1ad6e4): &lt;https://commits.webkit.org/271376@main&gt;

Reviewed commits have been landed. Closing PR #21153 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1996698</commentid>
    <comment_count>6</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2023-12-04 05:58:29 -0800</bug_when>
    <thetext>Even with this fix I keep getting a build issue when cross-compiling using Yocto:

| /home/aperez/philips/synergy-mgl-browser/workspace/build/tmp/work/cortexa53-crypto-oe-linux/wpewebkit/2.43.upstream-20231201-r0/git/Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp: In member function &apos;virtual int WPE::DRM::SessionLogind::openDevice(const char*, int)&apos;:
| /home/aperez/philips/synergy-mgl-browser/workspace/build/tmp/work/cortexa53-crypto-oe-linux/wpewebkit/2.43.upstream-20231201-r0/git/Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp:115:12: error: &apos;g_unix_fd_list_get&apos; was not declared in this scope
|   115 |     return g_unix_fd_list_get(fdList.get(), handler, nullptr);
|       |            ^~~~~~~~~~~~~~~~~~
 
I am going to submit a follow-up patch that fixes this for good.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1996704</commentid>
    <comment_count>7</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2023-12-04 06:08:49 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/21275</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1996873</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-12-04 14:34:18 -0800</bug_when>
    <thetext>Committed 271511@main (906329430eb2): &lt;https://commits.webkit.org/271511@main&gt;

Reviewed commits have been landed. Closing PR #21275 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1998937</commentid>
    <comment_count>9</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-12-12 04:59:19 -0800</bug_when>
    <thetext>Re-opening for pull request https://github.com/webkit/webkit/pull/21675</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1998940</commentid>
    <comment_count>10</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-12-12 05:30:05 -0800</bug_when>
    <thetext>Committed 271924@main (8c8709a0194c): &lt;https://commits.webkit.org/271924@main&gt;

Reviewed commits have been landed. Closing PR #21675 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1998980</commentid>
    <comment_count>11</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2023-12-12 08:07:13 -0800</bug_when>
    <thetext>Re-opening for pull request https://github.com/webkit/webkit/pull/21683</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1998986</commentid>
    <comment_count>12</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-12-12 08:34:43 -0800</bug_when>
    <thetext>Committed 271935@main (a37d3931cdb0): &lt;https://commits.webkit.org/271935@main&gt;

Reviewed commits have been landed. Closing PR #21683 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>