26528 2009-06-18 16:39:23 -0700 REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com 2009-06-20 13:37:15 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 darin darin finnur.webkit oldest_to_newest 126813 0 darin 2009-06-18 16:39:23 -0700 To reproduce: 1. visit http://www.apple.com 2. click in Google search field 3. type "a" Assertion fires. When I comment out the assertion there is no visible problem. #0 0x03d5bc04 in WebCore::pushFullyClippedState (stack=@0xbfffe020, node=0x1d3d68e0) at OpenSource/WebCore/editing/TextIterator.cpp:187 #1 0x03d5e39d in WebCore::TextIterator::handleReplacedElement (this=0xbfffe014) at OpenSource/WebCore/editing/TextIterator.cpp:532 #2 0x03d5edae in WebCore::TextIterator::advance (this=0xbfffe014) at OpenSource/WebCore/editing/TextIterator.cpp:339 126814 1 darin 2009-06-18 16:39:38 -0700 <rdar://problem/6985329> 127025 2 mrowe 2009-06-19 13:45:20 -0700 *** Bug 26557 has been marked as a duplicate of this bug. *** 127050 3 darin 2009-06-19 15:56:07 -0700 I've got a fix for this. I hope to post it soon. 127092 4 31583 darin 2009-06-19 18:30:22 -0700 Created attachment 31583 patch, but I haven't written the regression test yet 127153 5 31599 darin 2009-06-20 12:53:32 -0700 Created attachment 31599 patch 127155 6 darin 2009-06-20 13:37:15 -0700 http://trac.webkit.org/changeset/44901 31583 2009-06-19 18:30:22 -0700 2009-06-20 12:53:32 -0700 patch, but I haven't written the regression test yet TextIteratorAssertPatch.txt text/plain 612 darin SW5kZXg6IFdlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCShyZXZpc2lvbiA0NDgxNSkKKysrIFdlYkNv cmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MjgsNyArNTI4 LDcgQEAgYm9vbCBUZXh0SXRlcmF0b3I6OmhhbmRsZVJlcGxhY2VkRWxlbWVudAogICAgIH0KIAog ICAgIGlmIChtX2VudGVyVGV4dENvbnRyb2xzICYmIHJlbmRlcmVyLT5pc1RleHRDb250cm9sKCkp IHsKLSAgICAgICAgbV9ub2RlID0gdG9SZW5kZXJUZXh0Q29udHJvbChyZW5kZXJlciktPmlubmVy VGV4dEVsZW1lbnQoKTsKKyAgICAgICAgbV9ub2RlID0gdG9SZW5kZXJUZXh0Q29udHJvbChyZW5k ZXJlciktPmlubmVyVGV4dEVsZW1lbnQoKS0+c2hhZG93VHJlZVJvb3ROb2RlKCk7CiAgICAgICAg IHB1c2hGdWxseUNsaXBwZWRTdGF0ZShtX2Z1bGx5Q2xpcHBlZFN0YWNrLCBtX25vZGUpOwogICAg ICAgICBtX29mZnNldCA9IDA7CiAgICAgICAgIHJldHVybiBmYWxzZTsK 31599 2009-06-20 12:53:32 -0700 2009-06-20 13:29:32 -0700 patch TextIteratorPatch.txt text/plain 6763 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDkwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDYtMjAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy NjUyODogUkVHUkVTU0lPTiAocjQ0Njc0KTogQXNzZXJ0aW9uIGluIFRleHRJdGVyYXRvcjo6cHVz aEZ1bGx5Q2xpcHBlZFN0YXRlIHdoaWxlIGNvdW50aW5nIG1hdGNoZXMgZm9yICJhIiBvbiBhcHBs ZS5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2 NTI4CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzY5ODUzMjkKKworICAgICAgICAqIGVkaXRpbmcv VGV4dEl0ZXJhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRJdGVyYXRvcjo6aGFuZGxl UmVwbGFjZWRFbGVtZW50KTogV2hlbiBlbnRlcmluZyBhIHRleHQgY29udHJvbCwKKyAgICAgICAg c3RhcnQgYXQgdGhlIHRvcCBvZiB0aGUgc2hhZG93IHRyZWUgKGJ5IGNhbGxpbmcgc2hhZG93VHJl ZVJvb3ROb2RlKS4gQWxzbworICAgICAgICByZW1vdmUgYXNzdW1wdGlvbiB0aGF0IGlubmVyVGV4 dEVsZW1lbnQgd2lsbCBuZXZlciBiZSAwIHNpbmNlIFJlbmRlclRleHRDb250cm9sCisgICAgICAg IGRvZXNuJ3QgcmVhbGx5IGd1YXJhbnRlZSB0aGlzLgorCiAyMDA5LTA2LTIwICBKYW4gTWljaGFl bCBBbG9uem8gIDxqbWFsb256b0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWS4KSW5kZXg6IFdlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCShyZXZpc2lvbiA0NDkwMCkKKysr IFdlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Mjgs MTAgKzUyOCwxMiBAQCBib29sIFRleHRJdGVyYXRvcjo6aGFuZGxlUmVwbGFjZWRFbGVtZW50CiAg ICAgfQogCiAgICAgaWYgKG1fZW50ZXJUZXh0Q29udHJvbHMgJiYgcmVuZGVyZXItPmlzVGV4dENv bnRyb2woKSkgewotICAgICAgICBtX25vZGUgPSB0b1JlbmRlclRleHRDb250cm9sKHJlbmRlcmVy KS0+aW5uZXJUZXh0RWxlbWVudCgpOwotICAgICAgICBwdXNoRnVsbHlDbGlwcGVkU3RhdGUobV9m dWxseUNsaXBwZWRTdGFjaywgbV9ub2RlKTsKLSAgICAgICAgbV9vZmZzZXQgPSAwOwotICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgICAgIGlmIChIVE1MRWxlbWVudCogaW5uZXJUZXh0RWxlbWVu dCA9IHRvUmVuZGVyVGV4dENvbnRyb2wocmVuZGVyZXIpLT5pbm5lclRleHRFbGVtZW50KCkpIHsK KyAgICAgICAgICAgIG1fbm9kZSA9IGlubmVyVGV4dEVsZW1lbnQtPnNoYWRvd1RyZWVSb290Tm9k ZSgpOworICAgICAgICAgICAgcHVzaEZ1bGx5Q2xpcHBlZFN0YXRlKG1fZnVsbHlDbGlwcGVkU3Rh Y2ssIG1fbm9kZSk7CisgICAgICAgICAgICBtX29mZnNldCA9IDA7CisgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgICAgIH0KICAgICB9CiAKICAgICBtX2hhdmVFbWl0dGVkID0gdHJ1ZTsK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ0OTAwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMDYtMjAgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJ1ZyAyNjUyODogUkVHUkVTU0lPTiAocjQ0Njc0KTogQXNzZXJ0aW9uIGluIFRleHRJ dGVyYXRvcjo6cHVzaEZ1bGx5Q2xpcHBlZFN0YXRlIHdoaWxlIGNvdW50aW5nIG1hdGNoZXMgZm9y ICJhIiBvbiBhcHBsZS5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI2NTI4CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzY5ODUzMjkKKworICAgICAg ICAqIGVkaXRpbmcvc2VsZWN0aW9uL2ZpbmQtaW4tdGV4dC1jb250cm9sLWV4cGVjdGVkLnR4dDog VXBkYXRlZCB0byBleHBlY3QKKyAgICAgICAgZmluZGluZyB0ZXh0IGluIDxpbnB1dCB0eXBlPSJ0 ZXh0Ij4gYW5kIDxpbnB1dCB0eXBlPSJzZWFyY2giPiwgYnV0IG5vdAorICAgICAgICBpbiA8aW5w dXQgdHlwZT0icGFzc3dvcmQiPi4KKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL2ZpbmQt aW4tdGV4dC1jb250cm9sLmh0bWw6IEFkZGVkIHRlc3RzIGZvciA8aW5wdXQ+CisgICAgICAgIGVs ZW1lbnRzIGFzIHdlbGwgYXMgPHRleHRhcmVhPiBlbGVtZW50cy4gQWxzbyB0d2Vha2VkIHJlc3Vs dCBvdXRwdXQKKyAgICAgICAgZm9ybWF0IHRvIGFjY29tb2RhdGUgbXVsdGlwbGUgdGV4dCBub2Rl cy4KKwogMjAwOS0wNi0yMCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAg ICAgU2tpcCBuZXcgYWNjZXNzaWJpbGl0eSB0ZXN0LCB3ZSBzdGlsbCBsYWNrIGFuZCBhY2Nlc3Np YmlsaXR5Q29udHJvbGxlci4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2Zp bmQtaW4tdGV4dC1jb250cm9sLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9lZGl0aW5nL3NlbGVjdGlvbi9maW5kLWluLXRleHQtY29udHJvbC1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDQ0OTAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZmluZC1pbi10 ZXh0LWNvbnRyb2wtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDE5ICsxLDM5IEBA CiBUZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAyMyBT ZWFyY2hpbmcgaW4gdGV4dCBhcmVhcy4KIAotTG9yZW0gaXB0IGFtZXQKK0xvcmVtIGlwdCBhbWV0 IExvcmVtIGlwdCBhbWV0IExvcmVtIGlwdCBhbWV0IExvcmVtIGlwdCBhbWV0CiBUYXJnZXQgbSBt YXRjaGVkIGF0OgotICAgIG91dGVyIHRleHQgYmVmb3JlLCBhdCBvZmZzZXQgOQorICAgIG91dGVy IHRleHQgbm9kZSAxLCBhdCBvZmZzZXQgOQogICAgIHRleHQgY29udHJvbCwgYXQgb2Zmc2V0IDIK LSAgICBvdXRlciB0ZXh0IGFmdGVyLCBhdCBvZmZzZXQgMworICAgIG91dGVyIHRleHQgbm9kZSAy LCBhdCBvZmZzZXQgMworICAgIG91dGVyIHRleHQgbm9kZSAyLCBhdCBvZmZzZXQgMTUKKyAgICB0 ZXh0IGNvbnRyb2wsIGF0IG9mZnNldCAyCisgICAgb3V0ZXIgdGV4dCBub2RlIDMsIGF0IG9mZnNl dCAzCisgICAgb3V0ZXIgdGV4dCBub2RlIDMsIGF0IG9mZnNldCAxNQorICAgIHRleHQgY29udHJv bCwgYXQgb2Zmc2V0IDIKKyAgICBvdXRlciB0ZXh0IG5vZGUgNCwgYXQgb2Zmc2V0IDMKKyAgICBv dXRlciB0ZXh0IG5vZGUgNCwgYXQgb2Zmc2V0IDE1CisgICAgb3V0ZXIgdGV4dCBub2RlIDUsIGF0 IG9mZnNldCAzCiBUYXJnZXQgcyBtYXRjaGVkIGF0OgogICAgIHRleHQgY29udHJvbCwgYXQgb2Zm c2V0IDAKICAgICB0ZXh0IGNvbnRyb2wsIGF0IG9mZnNldCAxMAorICAgIHRleHQgY29udHJvbCwg YXQgb2Zmc2V0IDAKKyAgICB0ZXh0IGNvbnRyb2wsIGF0IG9mZnNldCAxMAorICAgIHRleHQgY29u dHJvbCwgYXQgb2Zmc2V0IDAKKyAgICB0ZXh0IGNvbnRyb2wsIGF0IG9mZnNldCAxMAogVGFyZ2V0 IHNpIG1hdGNoZWQgYXQ6CiAgICAgdGV4dCBjb250cm9sLCBhdCBvZmZzZXQgMTAKKyAgICB0ZXh0 IGNvbnRyb2wsIGF0IG9mZnNldCAxMAorICAgIHRleHQgY29udHJvbCwgYXQgb2Zmc2V0IDEwCiBU YXJnZXQgcmVtIG1hdGNoZWQgYXQ6Ci0gICAgb3V0ZXIgdGV4dCBiZWZvcmUsIGF0IG9mZnNldCA3 CisgICAgb3V0ZXIgdGV4dCBub2RlIDEsIGF0IG9mZnNldCA3CisgICAgb3V0ZXIgdGV4dCBub2Rl IDIsIGF0IG9mZnNldCAxMworICAgIG91dGVyIHRleHQgbm9kZSAzLCBhdCBvZmZzZXQgMTMKKyAg ICBvdXRlciB0ZXh0IG5vZGUgNCwgYXQgb2Zmc2V0IDEzCiBUYXJnZXQgaXBzdW0gbm90IG1hdGNo ZWQKIFRhcmdldCBzaXQgbm90IG1hdGNoZWQKIFRhcmdldCBhbWV0IG1hdGNoZWQgYXQ6Ci0gICAg b3V0ZXIgdGV4dCBhZnRlciwgYXQgb2Zmc2V0IDIKKyAgICBvdXRlciB0ZXh0IG5vZGUgMiwgYXQg b2Zmc2V0IDIKKyAgICBvdXRlciB0ZXh0IG5vZGUgMywgYXQgb2Zmc2V0IDIKKyAgICBvdXRlciB0 ZXh0IG5vZGUgNCwgYXQgb2Zmc2V0IDIKKyAgICBvdXRlciB0ZXh0IG5vZGUgNSwgYXQgb2Zmc2V0 IDIKIApJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZmluZC1pbi10ZXh0LWNv bnRyb2wuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9m aW5kLWluLXRleHQtY29udHJvbC5odG1sCShyZXZpc2lvbiA0NDkwMCkKKysrIExheW91dFRlc3Rz L2VkaXRpbmcvc2VsZWN0aW9uL2ZpbmQtaW4tdGV4dC1jb250cm9sLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTMsNiArMyw5IEBACiA8L3A+CiA8ZGl2IGlkPSJkaXYiPgogICAgIExvcmVtIGlwPHRl eHRhcmVhIGlkPSJ0ZXh0YXJlYSI+c3VtIGRvbG9yIHNpPC90ZXh0YXJlYT50IGFtZXQKKyAgICBM b3JlbSBpcDxpbnB1dCB0eXBlPSJ0ZXh0IiB2YWx1ZT0ic3VtIGRvbG9yIHNpIj50IGFtZXQKKyAg ICBMb3JlbSBpcDxpbnB1dCB0eXBlPSJzZWFyY2giIHZhbHVlPSJzdW0gZG9sb3Igc2kiPnQgYW1l dAorICAgIExvcmVtIGlwPGlucHV0IHR5cGU9InBhc3N3b3JkIiB2YWx1ZT0ic3VtIGRvbG9yIHNp Ij50IGFtZXQKIDwvZGl2PgogPHNjcmlwdD4KICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQpAQCAtMTAsMTIgKzEzLDMyIEBACiAKICAgICB2YXIgcmVzdWx0ID0gIiI7CiAKKyAg ICBmdW5jdGlvbiBlbGVtZW50SW5kZXgobm9kZSkKKyAgICB7CisgICAgICAgIHZhciBpbmRleCA9 IDE7CisgICAgICAgIHdoaWxlIChub2RlID0gbm9kZS5wcmV2aW91c1NpYmxpbmcpIHsKKyAgICAg ICAgICAgIGlmIChub2RlLm5vZGVUeXBlID09IE5vZGUuRUxFTUVOVF9OT0RFKQorICAgICAgICAg ICAgICAgICsraW5kZXg7CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuIGluZGV4OworICAgIH0K KworICAgIGZ1bmN0aW9uIHRleHROb2RlSW5kZXgobm9kZSkKKyAgICB7CisgICAgICAgIHZhciBp bmRleCA9IDE7CisgICAgICAgIHdoaWxlIChub2RlID0gbm9kZS5wcmV2aW91c1NpYmxpbmcpIHsK KyAgICAgICAgICAgIGlmIChub2RlLm5vZGVUeXBlID09IE5vZGUuVEVYVF9OT0RFKQorICAgICAg ICAgICAgICAgICsraW5kZXg7CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuIGluZGV4OworICAg IH0KKwogICAgIGZ1bmN0aW9uIGZpbmRBbGwodGFyZ2V0KQogICAgIHsKLSAgICAgICAgZG9jdW1l bnQuYm9keS5vZmZzZXRUb3A7CisgICAgICAgIHZhciByYW5nZXMgPSBbXTsKKwogICAgICAgICB2 YXIgc2VsID0gZ2V0U2VsZWN0aW9uKCk7CiAgICAgICAgIHNlbC5lbXB0eSgpOwotICAgICAgICB2 YXIgcmFuZ2VzID0gW107CiAgICAgICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJGaW5kU3RyaW5n IiwgZmFsc2UsIHRhcmdldCk7CiAgICAgICAgIGlmICghc2VsLnJhbmdlQ291bnQpIHsKICAgICAg ICAgICAgIHJlc3VsdCArPSAiVGFyZ2V0ICIgKyB0YXJnZXQgKyAiIG5vdCBtYXRjaGVkXG4iOwpA QCAtMjcsMTEgKzUwLDEzIEBACiAgICAgICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiRmlu ZFN0cmluZyIsIGZhbHNlLCB0YXJnZXQpOwogICAgICAgICAgICAgcmFuZ2UgPSBzZWwuZ2V0UmFu Z2VBdCgwKTsKICAgICAgICAgfQorICAgICAgICBzZWwuZW1wdHkoKTsKKwogICAgICAgICB2YXIg ZGl2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRpdiIpOwogICAgICAgICByZXN1bHQgKz0g IlRhcmdldCAiICsgdGFyZ2V0ICsgIiBtYXRjaGVkIGF0OlxuIjsKICAgICAgICAgd2hpbGUgKHJh bmdlID0gcmFuZ2VzLnNoaWZ0KCkpIHsKICAgICAgICAgICAgIHJlc3VsdCArPSAiICAgICI7Ci0g ICAgICAgICAgICByZXN1bHQgKz0gcmFuZ2Uuc3RhcnRDb250YWluZXIucGFyZW50Tm9kZSAhPSBk aXYgPyAidGV4dCBjb250cm9sIiA6IHJhbmdlLnN0YXJ0Q29udGFpbmVyLm5leHRTaWJsaW5nID8g Im91dGVyIHRleHQgYmVmb3JlIiA6ICJvdXRlciB0ZXh0IGFmdGVyIjsKKyAgICAgICAgICAgIHJl c3VsdCArPSByYW5nZS5zdGFydENvbnRhaW5lci5wYXJlbnROb2RlICE9IGRpdiA/ICJ0ZXh0IGNv bnRyb2wiIDogIm91dGVyIHRleHQgbm9kZSAiICsgdGV4dE5vZGVJbmRleChyYW5nZS5zdGFydENv bnRhaW5lcik7CiAgICAgICAgICAgICByZXN1bHQgKz0gIiwgYXQgb2Zmc2V0ICIgKyByYW5nZS5z dGFydE9mZnNldCArICJcbiI7CiAgICAgICAgIH0KICAgICB9Cg==