265261 2023-11-22 12:10:31 -0800 Unsupport encodings (e.g., 'x-mac-turkish', 'x-mac-greek' etc.) WPT failures 2025-02-10 06:27:38 -0800 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified REOPENED http://wpt.live/encoding/unsupported-labels.window.html BrowserCompat, InRadar, WPTImpact P2 Normal --- 267969 270658 179303 1 ahmad.saleem792 ahmad.saleem792 annevk ap commit-queue karlcow mmaxfield webkit-bug-importer oldest_to_newest 1994431 0 ahmad.saleem792 2023-11-22 12:10:31 -0800 Hi Team, While going through WPT failures, I came across following failing test in Safari / WebKit. WPT Test Case: https://wpt.fyi/results/encoding/unsupported-labels.window.html?label=master&label=experimental&aligned&q=safari%3Afail Just wanted to raise so we can track it. Adding 'BrowserCompat' since only Safari / WebKit is failing them. ___ Following are not supported by Encoding Standard: > euc-tw > windows-936-2000 > x-mac-ce > x-mac-centraleurroman > x-mac-greek > x-mac-turkish ^ few are mentioned here with comment that they are not in standard: https://searchfox.org/wubkat/source/Source/WebCore/PAL/pal/text/TextCodecICU.cpp#97 ____ Thanks! 1995673 1 webkit-bug-importer 2023-11-29 12:11:20 -0800 <rdar://problem/118944539> 2001348 2 ahmad.saleem792 2023-12-21 06:25:34 -0800 > Source/WebCore/PAL/pal/text/TextCodecCJK.cpp In -- TextCodecCJK::registerEncodingNames -- Remove > "windows-936-2000"_s > Source/WebCore/PAL/pal/text/TextCodecICU.cpp In -- DECLARE_ALIASE -- Remove from '/ Encodings below are not in the standard.' onward: DECLARE_ALIASES(x_mac_greek, "windows-10006"_s, "macgr"_s, "x-MacGreek"_s); DECLARE_ALIASES(x_mac_centraleurroman, "windows-10029"_s, "x-mac-ce"_s, "macce"_s, "maccentraleurope"_s, "x-MacCentralEurope"_s); DECLARE_ALIASES(x_mac_turkish, "windows-10081"_s, "mactr"_s, "x-MacTurkish"_s); and In -- EncodingName -- Remove: // Encodings below are not in the standard. DECLARE_ENCODING_NAME("x-mac-greek"_s, x_mac_greek), DECLARE_ENCODING_NAME("x-mac-centraleurroman"_s, x_mac_centraleurroman), DECLARE_ENCODING_NAME("x-mac-turkish"_s, x_mac_turkish), DECLARE_ENCODING_NAME_NO_ALIASES("EUC-TW"_s), ___ It progresses all failing WPT tests. 2002278 3 ahmad.saleem792 2023-12-29 22:45:08 -0800 @Karl - is there any internal requirement by Apple to retain or I can try to do PR and match other browsers? 2002302 4 ahmad.saleem792 2023-12-30 06:31:17 -0800 Just running through EWS to see how many more tests to modify and if there are anything else platform specific - https://github.com/WebKit/WebKit/pull/22273 (In Draft). 2018951 5 ahmad.saleem792 2024-03-05 19:17:07 -0800 Just to update - looks now ready to go (even if we don't land right now - it will be good for future reference) - https://github.com/WebKit/WebKit/pull/22273 2019376 6 ews-feeder 2024-03-07 10:41:22 -0800 Committed 275797@main (a78cd83130cb): <https://commits.webkit.org/275797@main> Reviewed commits have been landed. Closing PR #22273 and removing active labels. 2019445 7 commit-queue 2024-03-07 13:36:42 -0800 Re-opened since this is blocked by bug 270658 2093471 8 ahmad.saleem792 2025-02-10 06:27:38 -0800 Pull request: https://github.com/WebKit/WebKit/pull/40354