265119 2023-11-19 20:25:21 -0800 FontCascade::glyphDataForCharacter is a somewhat expensive call 2023-11-20 07:18:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan mmaxfield pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1993808 0 zalan 2023-11-19 20:25:21 -0800 ssia 1993809 1 468668 zalan 2023-11-19 20:27:24 -0800 Created attachment 468668 Patch 1993825 2 468668 koivisto 2023-11-19 23:53:57 -0800 Comment on attachment 468668 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=468668&action=review > Source/WebCore/rendering/RenderText.cpp:309 > + std::array<bool, 256> hasSeen = { false }; std::bitset is bit more compact 1993882 3 468677 zalan 2023-11-20 06:04:01 -0800 Created attachment 468677 Patch 1993887 4 468679 zalan 2023-11-20 06:09:03 -0800 Created attachment 468679 [fast-cq]Patch 1993898 5 ews-feeder 2023-11-20 07:16:51 -0800 Committed 270976@main (8b7f6c1f1080): <https://commits.webkit.org/270976@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468679. 1993901 6 webkit-bug-importer 2023-11-20 07:18:29 -0800 <rdar://problem/118652566> 468668 2023-11-19 20:27:24 -0800 2023-11-20 06:03:59 -0800 Patch bug-265119-20231119202723.patch text/plain 1558 zalan RnJvbSA5ZDE2YWRlNGYzZGZlNDMwZTgxZjE2YTlmNzA3NzAwN2YyYzlhZDhjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFN1biwgMTkgTm92IDIwMjMgMjA6MjU6MzAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGb250Q2Fz Y2FkZTo6Z2x5cGhEYXRhRm9yQ2hhcmFjdGVyIGlzIGEgc29tZXdoYXQgZXhwZW5zaXZlCiBjYWxs IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjUxMTkKClJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKTGV0J3Mgbm90IGNhbGwgaXQgb24gZXZlcnkgcmVwZWF0aW5n IGNoYXJhY3RlciBpbiBhIHRleHQgcmVuZGVyZXIuCgoqIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUZXh0LmNwcDoKKFdlYkNvcmU6OmluaXRpYXRlRm9udExvYWRpbmdCeUFjY2Vzc2lu Z0dseXBoRGF0YUlmQXBwbGljYWJsZSk6Ci0tLQogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHQuY3BwIHwgMTAgKysrKysrKysrLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNw cAppbmRleCBjN2QzODk2MGQyZTguLmIyYWFiMTgyMGNiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUZXh0LmNwcApAQCAtMzA1LDggKzMwNSwxNiBAQCBzdGF0aWMgdm9pZCBpbml0 aWF0ZUZvbnRMb2FkaW5nQnlBY2Nlc3NpbmdHbHlwaERhdGFJZkFwcGxpY2FibGUoY29uc3QgU3Ry aW5nJiB0ZQogICAgICAgICBmb250VmFyaWFudCA9IE5vcm1hbFZhcmlhbnQ7CiAgICAgfQogI2Vu ZGlmCi0gICAgZm9yIChVQ2hhcjMyIGNoYXJhY3RlciA6IFN0cmluZ1ZpZXcodGV4dENvbnRlbnQp LmNvZGVQb2ludHMoKSkKKyAgICAvLyBGSVhNRTogUHJlLXdhcm0gZ2x5cGggbG9hZGluZyBpbiBG b250Q2FzY2FkZSB3aXRoIHRoZSBtb3N0IGNvbW1vbiByYW5nZS4KKyAgICBzdGQ6OmFycmF5PGJv b2wsIDI1Nj4gaGFzU2VlbiA9IHsgZmFsc2UgfTsKKyAgICBmb3IgKFVDaGFyMzIgY2hhcmFjdGVy IDogU3RyaW5nVmlldyh0ZXh0Q29udGVudCkuY29kZVBvaW50cygpKSB7CisgICAgICAgIGlmIChj aGFyYWN0ZXIgPCAyNTUpIHsKKyAgICAgICAgICAgIGlmIChoYXNTZWVuW2NoYXJhY3Rlcl0pCisg ICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICBoYXNTZWVuW2NoYXJhY3Rlcl0g PSB0cnVlOworICAgICAgICB9CiAgICAgICAgIGZvbnRDYXNjYWRlLmdseXBoRGF0YUZvckNoYXJh Y3RlcihjaGFyYWN0ZXIsIGZhbHNlLCBmb250VmFyaWFudCk7CisgICAgfQogfQogCiB2b2lkIFJl bmRlclRleHQ6OnN0eWxlRGlkQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5k ZXJTdHlsZSogb2xkU3R5bGUpCg== 468677 2023-11-20 06:04:01 -0800 2023-11-20 06:09:00 -0800 Patch bug-265119-20231120060400.patch text/plain 1764 zalan RnJvbSA5NWJhODdkMmEzOGQzOWU4YWVkNzhkYThjZjcxNzk1NGIwNzc2ZjFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFN1biwgMTkgTm92IDIwMjMgMjA6MjU6MzAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGb250Q2Fz Y2FkZTo6Z2x5cGhEYXRhRm9yQ2hhcmFjdGVyIGlzIGEgc29tZXdoYXQgZXhwZW5zaXZlCiBjYWxs IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjUxMTkKClJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKTGV0J3Mgbm90IGNhbGwgaXQgb24gZXZlcnkgcmVwZWF0aW5n IGNoYXJhY3RlciBpbiBhIHRleHQgcmVuZGVyZXIuCgoqIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUZXh0LmNwcDoKKFdlYkNvcmU6OmluaXRpYXRlRm9udExvYWRpbmdCeUFjY2Vzc2lu Z0dseXBoRGF0YUlmQXBwbGljYWJsZSk6Ci0tLQogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHQuY3BwIHwgMTEgKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQu Y3BwCmluZGV4IGM3ZDM4OTYwZDJlOC4uNjllYmU0MjA0MjU4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRleHQuY3BwCkBAIC02Miw2ICs2Miw3IEBACiAjaW5jbHVkZSAiVGV4dFRy YW5zZm9ybS5oIgogI2luY2x1ZGUgIlZpc2libGVQb3NpdGlvbi5oIgogI2luY2x1ZGUgIldpZHRo SXRlcmF0b3IuaCIKKyNpbmNsdWRlIDxiaXRzZXQ+CiAjaW5jbHVkZSA8d3RmL0lzb01hbGxvY0lu bGluZXMuaD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYv U29ydGVkQXJyYXlNYXAuaD4KQEAgLTMwNSw4ICszMDYsMTYgQEAgc3RhdGljIHZvaWQgaW5pdGlh dGVGb250TG9hZGluZ0J5QWNjZXNzaW5nR2x5cGhEYXRhSWZBcHBsaWNhYmxlKGNvbnN0IFN0cmlu ZyYgdGUKICAgICAgICAgZm9udFZhcmlhbnQgPSBOb3JtYWxWYXJpYW50OwogICAgIH0KICNlbmRp ZgotICAgIGZvciAoVUNoYXIzMiBjaGFyYWN0ZXIgOiBTdHJpbmdWaWV3KHRleHRDb250ZW50KS5j b2RlUG9pbnRzKCkpCisgICAgLy8gRklYTUU6IFByZS13YXJtIGdseXBoIGxvYWRpbmcgaW4gRm9u dENhc2NhZGUgd2l0aCB0aGUgbW9zdCBjb21tb24gcmFuZ2UuCisgICAgc3RkOjpiaXRzZXQ8MjU2 PiBoYXNTZWVuOworICAgIGZvciAoVUNoYXIzMiBjaGFyYWN0ZXIgOiBTdHJpbmdWaWV3KHRleHRD b250ZW50KS5jb2RlUG9pbnRzKCkpIHsKKyAgICAgICAgaWYgKGNoYXJhY3RlciA8IDI1NSkgewor ICAgICAgICAgICAgaWYgKGhhc1NlZW5bY2hhcmFjdGVyXSkKKyAgICAgICAgICAgICAgICBjb250 aW51ZTsKKyAgICAgICAgICAgIGhhc1NlZW4uc2V0KGNoYXJhY3Rlcik7CisgICAgICAgIH0KICAg ICAgICAgZm9udENhc2NhZGUuZ2x5cGhEYXRhRm9yQ2hhcmFjdGVyKGNoYXJhY3RlciwgZmFsc2Us IGZvbnRWYXJpYW50KTsKKyAgICB9CiB9CiAKIHZvaWQgUmVuZGVyVGV4dDo6c3R5bGVEaWRDaGFu Z2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkK 468679 2023-11-20 06:09:03 -0800 2023-11-20 07:16:56 -0800 [fast-cq]Patch bug-265119-20231120060902.patch text/plain 1764 zalan RnJvbSA2NDJjYmYxOTNhZTIwMThjMjFhN2YwNGI0ODY4YjY3M2MyNmQxYjMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFN1biwgMTkgTm92IDIwMjMgMjA6MjU6MzAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGb250Q2Fz Y2FkZTo6Z2x5cGhEYXRhRm9yQ2hhcmFjdGVyIGlzIGEgc29tZXdoYXQgZXhwZW5zaXZlCiBjYWxs IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjUxMTkKClJldmlld2Vk IGJ5IEFudHRpIEtvaXZpc3RvLgoKTGV0J3Mgbm90IGNhbGwgaXQgb24gZXZlcnkgcmVwZWF0aW5n IGNoYXJhY3RlciBpbiBhIHRleHQgcmVuZGVyZXIuCgoqIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUZXh0LmNwcDoKKFdlYkNvcmU6OmluaXRpYXRlRm9udExvYWRpbmdCeUFjY2Vzc2lu Z0dseXBoRGF0YUlmQXBwbGljYWJsZSk6Ci0tLQogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHQuY3BwIHwgMTEgKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQu Y3BwCmluZGV4IGM3ZDM4OTYwZDJlOC4uZjdmN2Q0YWQyOTAxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRleHQuY3BwCkBAIC02Miw2ICs2Miw3IEBACiAjaW5jbHVkZSAiVGV4dFRy YW5zZm9ybS5oIgogI2luY2x1ZGUgIlZpc2libGVQb3NpdGlvbi5oIgogI2luY2x1ZGUgIldpZHRo SXRlcmF0b3IuaCIKKyNpbmNsdWRlIDxiaXRzZXQ+CiAjaW5jbHVkZSA8d3RmL0lzb01hbGxvY0lu bGluZXMuaD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYv U29ydGVkQXJyYXlNYXAuaD4KQEAgLTMwNSw4ICszMDYsMTYgQEAgc3RhdGljIHZvaWQgaW5pdGlh dGVGb250TG9hZGluZ0J5QWNjZXNzaW5nR2x5cGhEYXRhSWZBcHBsaWNhYmxlKGNvbnN0IFN0cmlu ZyYgdGUKICAgICAgICAgZm9udFZhcmlhbnQgPSBOb3JtYWxWYXJpYW50OwogICAgIH0KICNlbmRp ZgotICAgIGZvciAoVUNoYXIzMiBjaGFyYWN0ZXIgOiBTdHJpbmdWaWV3KHRleHRDb250ZW50KS5j b2RlUG9pbnRzKCkpCisgICAgLy8gRklYTUU6IFByZS13YXJtIGdseXBoIGxvYWRpbmcgaW4gRm9u dENhc2NhZGUgd2l0aCB0aGUgbW9zdCBjb21tb24gcmFuZ2UuCisgICAgc3RkOjpiaXRzZXQ8MjU2 PiBoYXNTZWVuOworICAgIGZvciAoVUNoYXIzMiBjaGFyYWN0ZXIgOiBTdHJpbmdWaWV3KHRleHRD b250ZW50KS5jb2RlUG9pbnRzKCkpIHsKKyAgICAgICAgaWYgKGNoYXJhY3RlciA8IDI1Nikgewor ICAgICAgICAgICAgaWYgKGhhc1NlZW5bY2hhcmFjdGVyXSkKKyAgICAgICAgICAgICAgICBjb250 aW51ZTsKKyAgICAgICAgICAgIGhhc1NlZW4uc2V0KGNoYXJhY3Rlcik7CisgICAgICAgIH0KICAg ICAgICAgZm9udENhc2NhZGUuZ2x5cGhEYXRhRm9yQ2hhcmFjdGVyKGNoYXJhY3RlciwgZmFsc2Us IGZvbnRWYXJpYW50KTsKKyAgICB9CiB9CiAKIHZvaWQgUmVuZGVyVGV4dDo6c3R5bGVEaWRDaGFu Z2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkK