265118 2023-11-19 19:03:56 -0800 NativePromise should allow void as reject type. 2023-11-20 18:04:48 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard webkit-bug-importer oldest_to_newest 1993806 0 jean-yves.avenard 2023-11-19 19:03:56 -0800 NativePromise::Result is using `Expected<T, U>` as storage type ; which doesn't allow to have U==void And as such, NativePromise must set a non-void type a RejectValueType. In bug 264028, you can now chain promises of different types together, and if you chain a void promise, that promise gets resolve whenever the original promise gets resolved, regardless of the resolve value. It would be nice to do the same for rejection. And as such, we need for NativePromise to handle RejectValueType == void. This can be achieved by using Expected<T, NativePromise::VoidPlaceholder> 1993844 1 jean-yves.avenard 2023-11-20 03:06:33 -0800 <rdar://problem/117782213> 1993845 2 jean-yves.avenard 2023-11-20 03:07:09 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20738 1993848 3 jean-yves.avenard 2023-11-20 03:20:16 -0800 rdar://118645560 1994037 4 ews-feeder 2023-11-20 18:04:47 -0800 Committed 270995@main (bb71e93437b5): <https://commits.webkit.org/270995@main> Reviewed commits have been landed. Closing PR #20738 and removing active labels.