265101 2023-11-18 18:56:17 -0800 Make a couple more http/tests/security tests use window.internals.isFullyActive(Document&) 2023-12-05 12:41:54 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=263879 https://bugs.webkit.org/show_bug.cgi?id=261889 InRadar P2 Normal --- 1 mike mike webkit-bug-importer oldest_to_newest 1993719 0 mike 2023-11-18 18:56:17 -0800 https://commits.webkit.org/270737@main added a new window.internals.isFullyActive(Document&) function — intended for tests where it’s necessary to ensure whether or not a particular document is fully active — and used that function to update (fix) the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html test, which had been flaky since it was last updated in https://commits.webkit.org/269235@main. And in that https://commits.webkit.org/269235@main change which caused the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html test to become flaky, its companion tests at LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html and LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html had also been updated in the same way as the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html had been before it was subsequently fixed. And while those two other companion tests have not yet been flaky, we should also (re)update them to now use window.internals.isFullyActive(Document&) — in order to ensure they’re actually testing what they’re intended to be testing. 1993720 1 mike 2023-11-18 19:20:38 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20715 1994775 2 webkit-bug-importer 2023-11-25 18:57:13 -0800 <rdar://problem/118796437> 1997189 3 ews-feeder 2023-12-05 12:41:52 -0800 Committed 271565@main (a2d071de9311): <https://commits.webkit.org/271565@main> Reviewed commits have been landed. Closing PR #20715 and removing active labels.