265071 2023-11-17 16:16:58 -0800 Don't fire dblclick on disabled form control elements 2023-11-19 09:12:08 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=265073 InRadar P2 Normal --- 1 ntim ahmad.saleem792 ahmad.saleem792 a_protyasha rniwa webkit-bug-importer oldest_to_newest 1993598 0 ntim 2023-11-17 16:16:58 -0800 See: https://github.com/whatwg/html/issues/2368#issuecomment-1791704780 https://chromium-review.googlesource.com/c/chromium/src/+/5007308 https://github.com/web-platform-tests/wpt/pull/42976 1993599 1 webkit-bug-importer 2023-11-17 16:17:18 -0800 <rdar://problem/118584431> 1993602 2 ahmad.saleem792 2023-11-17 16:31:24 -0800 Something to do here? https://searchfox.org/wubkat/rev/114aa2c8594807cbc34dd5dff48a9e2addfd1e00/Source/WebCore/dom/EventDispatcher.cpp#160 if (node.document().settings().sendMouseEventsToDisabledFormControlsEnabled() && event.isTrusted() && event.isMouseEvent() && (event.type() == eventNames().mousedownEvent || event.type() == eventNames().mouseupEvent || event.type() == eventNames().clickEvent)) { eventPath.adjustForDisabledFormControl(); } 1993603 3 ahmad.saleem792 2023-11-17 16:33:14 -0800 Adding: || event.type() == eventNames().dblclickEvent 1993612 4 ahmad.saleem792 2023-11-17 17:25:31 -0800 NOTE - this compiles and after importing new tests and running on patch build, we pass all tests. @Tim - do you want me to do PR? I might do separate bug first to update all tests. 1993613 5 ahmad.saleem792 2023-11-17 17:26:35 -0800 PASS Testing dblclick events when clicking child of disabled button. PASS Testing dblclick events when clicking child of disabled my-control. PASS Testing dblclick events when clicking disabled button. PASS Testing dblclick events when clicking disabled my-control. ^ All passes. 1993616 6 a_protyasha 2023-11-17 17:44:24 -0800 @ahmad.saleem792@gmail.com go for it. Let's start with a PR syncing `wpt:html/semantics/` and then a PR for the fix you're proposing. 1993617 7 a_protyasha 2023-11-17 17:44:45 -0800 Ah, spoke a minute too late, I see the WPT sync PR is up. 1993757 8 ews-feeder 2023-11-19 09:12:06 -0800 Committed 270951@main (74ae3ea8d68e): <https://commits.webkit.org/270951@main> Reviewed commits have been landed. Closing PR #20723 and removing active labels.