265027 2023-11-17 06:31:51 -0800 Avoid unnecessary extra calls to RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats() 2024-06-04 06:24:02 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned bfulgham koivisto sgill26 simon.fraser webkit-bug-importer zalan oldest_to_newest 1993424 0 ahmad.saleem792 2023-11-17 06:31:51 -0800 Hi Team, While going through Blink's commit, I came across potential performance win (might be little but still avoiding extra calls in good). Blink Commit: https://chromium.googlesource.com/chromium/blink/+/5fd36573c98e79b31d6245d15772e4d0d4eefc8d WebKit Source: https://searchfox.org/wubkat/rev/114aa2c8594807cbc34dd5dff48a9e2addfd1e00/Source/WebCore/rendering/RenderBlockFlow.cpp#244 ___ This compiles (might be wrong or correct - just want to get input): bool parentHasIntrudingFloats = !parentHasFloats && (!previousBlock || (previousBlock->isSelfCollapsingBlock() && parentBlock.lowestFloatLogicalBottom() > logicalTopOffset)); if (parentHasFloats || parentHasIntrudingFloats) addIntrudingFloats(&parentBlock, &parentBlock, parentBlock.logicalLeftOffsetForContent(), logicalTopOffset); // Add overhanging floats from the previous RenderBlock, but only if it has a float that intrudes into our space. if (previousBlock) { logicalTopOffset -= previousBlock->logicalTop(); if (previousBlock->lowestFloatLogicalBottom() > logicalTopOffset) addIntrudingFloats(previousBlock, &parentBlock, 0, logicalTopOffset); } .. ___ Just wanted to raise so if needed, we can fix it. Thanks! 1993442 1 webkit-bug-importer 2023-11-17 07:24:25 -0800 <rdar://problem/118564239> 2039624 2 ews-feeder 2024-06-04 06:24:00 -0700 Committed 279695@main (74e329b07b3e): <https://commits.webkit.org/279695@main> Reviewed commits have been landed. Closing PR #29455 and removing active labels.