26502 2009-06-17 17:13:21 -0700 [Chromium] Use WebCore::multipleFileUploadText() 2009-06-19 11:24:04 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tkent levin levin oldest_to_newest 126607 0 tkent 2009-06-17 17:13:21 -0700 The current code of FileChooserChoromium.cpp doesn't use multipleFileUploadText(). So if a user selects multiple files for a file upload form, Chrome shows the first filename. It should show a text like "N files" like Safari. 126608 1 31470 tkent 2009-06-17 17:14:58 -0700 Created attachment 31470 Proposed patch 126797 2 31470 levin 2009-06-18 15:52:48 -0700 Comment on attachment 31470 Proposed patch > Index: WebCore/ChangeLog > +2009-06-17 Kent Tamura <tkent@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Use WebCore::multipleFileUploadText() in Chromium. > + <https://bugs.webkit.org/show_bug.cgi?id=26502> > + Ideally you would have something about why you are doing the change here? What does the change accomplish? (You have this in the bug.) This change looks good but the changelog needs to be improved, so r- until that is fixed. With a better change log, I'd happily give it an r+. 126855 3 31527 tkent 2009-06-18 18:41:53 -0700 Created attachment 31527 Proposed pattch rev.2 Thank you for the comment. I have updated the ChangeLog. 126856 4 31527 levin 2009-06-18 18:44:19 -0700 Comment on attachment 31527 Proposed pattch rev.2 There are tabs in the changelog. I'll fix this on landing. 126857 5 levin 2009-06-18 18:44:45 -0700 Assigned to levin for landing. 126968 6 levin 2009-06-19 11:24:04 -0700 Committed as http://trac.webkit.org/changeset/44860 31470 2009-06-17 17:14:58 -0700 2009-06-18 18:41:53 -0700 Proposed patch multiple.diff text/plain 1419 tkent SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDc4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDYtMTcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVz ZSBXZWJDb3JlOjptdWx0aXBsZUZpbGVVcGxvYWRUZXh0KCkgaW4gQ2hyb21pdW0uCisgICAgICAg IDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY1MDI+CisKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9GaWxlQ2hvb3NlckNocm9taXVtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZpbGVDaG9vc2VyOjpiYXNlbmFtZUZvcldpZHRoKToKKwogMjAwOS0wNi0xNyAg QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVubmVjZXNz YXJ5IDZ0aCBwYXJhbWV0ZXIgZnJvbSBTT0ZUX0xJTktfT1BUSU9OQUwKSW5kZXg6IFdlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vRmlsZUNob29zZXJDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GaWxlQ2hvb3NlckNocm9taXVtLmNwcAkocmV2aXNp b24gNDQ3ODYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZpbGVDaG9vc2VyQ2hyb21p dW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOSwxMCArMzksMTIgQEAgU3RyaW5nIEZpbGVDaG9v c2VyOjpiYXNlbmFtZUZvcldpZHRoKGNvbgogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAKICAg ICBTdHJpbmcgc3RyaW5nOwotICAgIGlmICghbV9maWxlbmFtZXMuc2l6ZSgpKQorICAgIGlmICht X2ZpbGVuYW1lcy5pc0VtcHR5KCkpCiAgICAgICAgIHN0cmluZyA9IGZpbGVCdXR0b25Ob0ZpbGVT ZWxlY3RlZExhYmVsKCk7Ci0gICAgZWxzZQorICAgIGVsc2UgaWYgKG1fZmlsZW5hbWVzLnNpemUo KSA9PSAxKQogICAgICAgICBzdHJpbmcgPSBwYXRoR2V0RmlsZU5hbWUobV9maWxlbmFtZXNbMF0p OworICAgIGVsc2UKKyAgICAgICAgcmV0dXJuIFN0cmluZ1RydW5jYXRvcjo6cmlnaHRUcnVuY2F0 ZShtdWx0aXBsZUZpbGVVcGxvYWRUZXh0KG1fZmlsZW5hbWVzLnNpemUoKSksIHdpZHRoLCBmb250 LCBmYWxzZSk7CiAKICAgICByZXR1cm4gU3RyaW5nVHJ1bmNhdG9yOjpjZW50ZXJUcnVuY2F0ZShz dHJpbmcsIHN0YXRpY19jYXN0PGZsb2F0Pih3aWR0aCksIGZvbnQsIGZhbHNlKTsKIH0K 31527 2009-06-18 18:41:53 -0700 2009-06-18 18:44:19 -0700 Proposed pattch rev.2 multiple2.diff text/plain 1527 tkent SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NDgzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDYtMTcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCQorICAgICAgICBV c2UgV2ViQ29yZTo6bXVsdGlwbGVGaWxlVXBsb2FkVGV4dCgpIGluIENocm9taXVtIHRvIGZpeCBh IHByb2JsZW0KKwl0aGF0IENocm9taXVtIHNob3dzIG9ubHkgdGhlIGZpcnN0IGZpbGVuYW1lIGV2 ZW4gaWYgYSB1c2VyIHNlbGVjdHMKKwltdWx0aXBsZSBmaWxlcyBmb3IgPGlucHV0IHR5cGU9Zmls ZSBtdWx0aXBsZT4uCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjY1MDI+CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9GaWxlQ2hvb3NlckNo cm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZpbGVDaG9vc2VyOjpiYXNlbmFtZUZvcldp ZHRoKToKKwogMjAwOS0wNi0xNyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBMZXZpbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vRmlsZUNob29zZXJDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9GaWxlQ2hvb3NlckNocm9taXVtLmNwcAkocmV2aXNpb24gNDQ4 MzYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZpbGVDaG9vc2VyQ2hyb21pdW0uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zOSwxMCArMzksMTIgQEAgU3RyaW5nIEZpbGVDaG9vc2VyOjpi YXNlbmFtZUZvcldpZHRoKGNvbgogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAKICAgICBTdHJp bmcgc3RyaW5nOwotICAgIGlmICghbV9maWxlbmFtZXMuc2l6ZSgpKQorICAgIGlmIChtX2ZpbGVu YW1lcy5pc0VtcHR5KCkpCiAgICAgICAgIHN0cmluZyA9IGZpbGVCdXR0b25Ob0ZpbGVTZWxlY3Rl ZExhYmVsKCk7Ci0gICAgZWxzZQorICAgIGVsc2UgaWYgKG1fZmlsZW5hbWVzLnNpemUoKSA9PSAx KQogICAgICAgICBzdHJpbmcgPSBwYXRoR2V0RmlsZU5hbWUobV9maWxlbmFtZXNbMF0pOworICAg IGVsc2UKKyAgICAgICAgcmV0dXJuIFN0cmluZ1RydW5jYXRvcjo6cmlnaHRUcnVuY2F0ZShtdWx0 aXBsZUZpbGVVcGxvYWRUZXh0KG1fZmlsZW5hbWVzLnNpemUoKSksIHdpZHRoLCBmb250LCBmYWxz ZSk7CiAKICAgICByZXR1cm4gU3RyaW5nVHJ1bmNhdG9yOjpjZW50ZXJUcnVuY2F0ZShzdHJpbmcs IHN0YXRpY19jYXN0PGZsb2F0Pih3aWR0aCksIGZvbnQsIGZhbHNlKTsKIH0K