264984 2023-11-16 14:59:15 -0800 [JSC] Refine B3 and masm tests for EXTR pattern detection and application 2024-02-06 09:24:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yijia_huang yijia_huang webkit-bug-importer oldest_to_newest 1993254 0 yijia_huang 2023-11-16 14:59:15 -0800 Also need to add these test cases. --- a/Source/JavaScriptCore/b3/testb3_2.cpp +++ b/Source/JavaScriptCore/b3/testb3_2.cpp @@ -4883,7 +4883,7 @@ void testExtractRegister32() { if (JSC::Options::defaultB3OptLevel() < 2) return; - Vector<uint32_t> lowWidths = { 0, 17, 31 }; + Vector<uint32_t> lowWidths = { 0, 17, 31, 32 }; // Test Pattern: ((n & mask1) << highWidth) | ((m & mask2) >> lowWidth) // Where: highWidth = datasize - lowWidth @@ -4915,7 +4915,7 @@ void testExtractRegister32() root->appendNew<Value>(proc, BitOr, Origin(), left, right)); auto code = compileProc(proc); - if (isARM64() && lowWidth > 0) + if (isARM64() && 0 < lowWidth && lowWidth < 32) checkUsesInstruction(*code, "extr"); return invoke<uint32_t>(*code, n, m); }; @@ -4943,7 +4943,7 @@ void testExtractRegister64() { if (JSC::Options::defaultB3OptLevel() < 2) return; - Vector<uint64_t> lowWidths = { 0, 34, 63 }; + Vector<uint64_t> lowWidths = { 0, 34, 63, 64 }; // Test Pattern: ((n & mask1) << highWidth) | ((m & mask2) >> lowWidth) // Where: highWidth = datasize - lowWidth @@ -4971,7 +4971,7 @@ void testExtractRegister64() root->appendNew<Value>(proc, BitOr, Origin(), left, right)); auto code = compileProc(proc); - if (isARM64() && lowWidth > 0) + if (isARM64() && 0 < lowWidth && lowWidth < 64) checkUsesInstruction(*code, "extr"); return invoke<uint64_t>(*code, n, m); }; 1993256 1 webkit-bug-importer 2023-11-16 14:59:59 -0800 <rdar://problem/118532295> 2010441 2 yijia_huang 2024-02-03 17:09:04 -0800 Pull request: https://github.com/WebKit/WebKit/pull/23820 2011030 3 ews-feeder 2024-02-06 09:24:14 -0800 Committed 274149@main (084df28f4fc4): <https://commits.webkit.org/274149@main> Reviewed commits have been landed. Closing PR #23820 and removing active labels.