26493 2009-06-17 14:35:20 -0700 REGRESSION (r44758): First tab always uses Mac-style form controls 2009-06-17 15:13:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, PlatformOnly, Regression P2 Normal --- 1 aroben aroben oldest_to_newest 126540 0 aroben 2009-06-17 14:35:20 -0700 To reproduce: 1. Launch Safari 2. Go to data:text/html,<button>test 3. Open a new tab 4. Go to data:text/html,<button>test In step 2, a Mac-style button is drawn. In step 4, a Windows-style button is drawn. This regressed in r44758 <http://trac.webkit.org/changeset/44758>. 126542 1 aroben 2009-06-17 14:36:14 -0700 <rdar://problem/6981976> 126543 2 aroben 2009-06-17 14:37:47 -0700 The problem is that RenderTheme::themeForPage is getting called before WebPreferences has communicated its settings to WebCore::Settings. RenderTheme::themeForPage consults Settings to decide whether it should return the RenderThemeWin or RenderThemeSafari instance, but Settings hasn't been initialized yet. 126547 3 31441 aroben 2009-06-17 14:45:47 -0700 Created attachment 31441 patch v1 + ChangeLog 126548 4 31441 darin 2009-06-17 14:49:46 -0700 Comment on attachment 31441 patch v1 + ChangeLog r=me I'm sad we have to work around this instead of fixing it. Too bad we didn't realize this was wrong before landing the per-page theme change! 126549 5 31441 hyatt 2009-06-17 14:51:50 -0700 Comment on attachment 31441 patch v1 + ChangeLog r=me 126557 6 aroben 2009-06-17 15:10:27 -0700 Fixed in r44785 126560 7 aroben 2009-06-17 15:13:19 -0700 I've recorded the desire to fix the real bug in bug 26494. 31441 2009-06-17 14:45:47 -0700 2009-06-17 14:49:46 -0700 patch v1 + ChangeLog 0001--Make-Settings-shouldPaintNativeControls-def.patch text/plain 3459 aroben RnJvbSA2YzQ4ZWI5ZjgyZDQ1MDgzYzFmYjg1ZWUzNjQ5ZTNlNWNkZGM1YjA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBX ZWQsIDE3IEp1biAyMDA5IDE3OjQ1OjE0IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gICAgICAgICBN YWtlIFNldHRpbmdzOjpzaG91bGRQYWludE5hdGl2ZUNvbnRyb2xzIGRlZmF1bHQgdG8gdHJ1ZQoK ICAgICAgICBUaGlzIG1hdGNoZXMgdGhlIGRlZmF1bHQgdXAgaW4gV2ViS2l0ICh0aGF0IHdhcyBj aGFuZ2VkIGluIHI0MzMxOCkuCgogICAgICAgIEZpeGVzIEJ1ZyAyNjQ5MzogUkVHUkVTU0lPTiAo cjQ0NzU4KTogRmlyc3QgdGFiIGFsd2F5cyB1c2VzIE1hYy1zdHlsZQogICAgICAgIGZvcm0gY29u dHJvbHMKICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2 NDkzPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgTm8gdGVz dCBwb3NzaWJsZSBzaW5jZSBEUlQgYWx3YXlzIHVzZXMgTWFjLXN0eWxlIGZvcm0gY29udHJvbHMu CgogICAgICAgICogcGFnZS9TZXR0aW5ncy5jcHA6IENoYW5nZWQgdGhlIGluaXRpYWwgdmFsdWUg b2YKICAgICAgICBnU2hvdWxkUGFpbnROYXRpdmVDb250cm9scyB0byB0cnVlLgoKICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJUaGVtZVNhZmFyaS5jcHA6CiAgICAgICAgKFdlYkNvcmU6OlJlbmRl clRoZW1lOjp0aGVtZUZvclBhZ2UpOiBBZGRlZCBhIEZJWE1FIGFib3V0IHRoZSBkZXNpZ24KICAg ICAgICBmbGF3IGhlcmUgaW52b2x2aW5nIHF1ZXJ5aW5nIFNldHRpbmdzIGJlZm9yZSBpdCdzIGJl ZW4gaW5pdGlhbGl6ZWQuCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgIHwgICAyMSArKysrKysrKysrKysrKysrKysrKysKIFdlYkNvcmUvcGFnZS9TZXR0aW5ncy5j cHAgICAgICAgICAgICAgICB8ICAgIDIgKy0KIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l U2FmYXJpLmNwcCB8ICAgIDQgKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggNGE2NDc5MC4uNGY2YjM2MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNiBAQAogMjAwOS0w Ni0xNyAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBTZXR0 aW5nczo6c2hvdWxkUGFpbnROYXRpdmVDb250cm9scyBkZWZhdWx0IHRvIHRydWUKKworICAgICAg ICBUaGlzIG1hdGNoZXMgdGhlIGRlZmF1bHQgdXAgaW4gV2ViS2l0ICh0aGF0IHdhcyBjaGFuZ2Vk IGluIHI0MzMxOCkuCisKKyAgICAgICAgRml4ZXMgQnVnIDI2NDkzOiBSRUdSRVNTSU9OIChyNDQ3 NTgpOiBGaXJzdCB0YWIgYWx3YXlzIHVzZXMgTWFjLXN0eWxlCisgICAgICAgIGZvcm0gY29udHJv bHMKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjQ5 Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyB0 ZXN0IHBvc3NpYmxlIHNpbmNlIERSVCBhbHdheXMgdXNlcyBNYWMtc3R5bGUgZm9ybSBjb250cm9s cy4KKworICAgICAgICAqIHBhZ2UvU2V0dGluZ3MuY3BwOiBDaGFuZ2VkIHRoZSBpbml0aWFsIHZh bHVlIG9mCisgICAgICAgIGdTaG91bGRQYWludE5hdGl2ZUNvbnRyb2xzIHRvIHRydWUuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVTYWZhcmkuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyVGhlbWU6OnRoZW1lRm9yUGFnZSk6IEFkZGVkIGEgRklYTUUgYWJvdXQgdGhlIGRl c2lnbgorICAgICAgICBmbGF3IGhlcmUgaW52b2x2aW5nIHF1ZXJ5aW5nIFNldHRpbmdzIGJlZm9y ZSBpdCdzIGJlZW4gaW5pdGlhbGl6ZWQuCisKKzIwMDktMDYtMTcgIEFkYW0gUm9iZW4gIDxhcm9i ZW5AYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCBhIFNPRlRfTElOS19PUFRJT05BTCBtYWNybwog CiAgICAgICAgIFRoaXMgbWFjcm8gaXMgdXNlZnVsIHdoZW4gc29mdC1saW5raW5nIGZ1bmN0aW9u cyB0aGF0IGFyZSBwcmVzZW50IGluCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3Mu Y3BwIGIvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNwcAppbmRleCA5MWVjMGIzLi5hZGJjYjhmIDEw MDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCisrKyBiL1dlYkNvcmUvcGFnZS9T ZXR0aW5ncy5jcHAKQEAgLTQ0LDcgKzQ0LDcgQEAgc3RhdGljIHZvaWQgc2V0TmVlZHNSZWFwcGx5 U3R5bGVzSW5BbGxGcmFtZXMoUGFnZSogcGFnZSkKIH0KIAogI2lmIFVTRShTQUZBUklfVEhFTUUp Ci1ib29sIFNldHRpbmdzOjpnU2hvdWxkUGFpbnROYXRpdmVDb250cm9scyA9IGZhbHNlOworYm9v bCBTZXR0aW5nczo6Z1Nob3VsZFBhaW50TmF0aXZlQ29udHJvbHMgPSB0cnVlOwogI2VuZGlmCiAK IFNldHRpbmdzOjpTZXR0aW5ncyhQYWdlKiBwYWdlKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWVTYWZhcmkuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVTYWZhcmkuY3BwCmluZGV4IDM4ZDgzYmIuLjE2ZDc0NGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lU2FmYXJpLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZVNhZmFyaS5jcHAKQEAgLTc1LDYgKzc1LDEwIEBAIFBhc3NSZWZQdHI8UmVuZGVy VGhlbWU+IFJlbmRlclRoZW1lOjp0aGVtZUZvclBhZ2UoUGFnZSogcGFnZSkKIHsKICAgICBzdGF0 aWMgUmVuZGVyVGhlbWUqIHNhZmFyaVRoZW1lID0gUmVuZGVyVGhlbWVTYWZhcmk6OmNyZWF0ZSgp LnJlbGVhc2VSZWYoKTsKICAgICBzdGF0aWMgUmVuZGVyVGhlbWUqIHdpbmRvd3NUaGVtZSA9IFJl bmRlclRoZW1lV2luOjpjcmVhdGUoKS5yZWxlYXNlUmVmKCk7CisKKyAgICAvLyBGSVhNRTogVGhp cyBpcyBjYWxsZWQgYmVmb3JlIFNldHRpbmdzIGhhcyBiZWVuIGluaXRpYWxpemVkIGJ5IFdlYktp dCwgc28gd2lsbCByZXR1cm4gYQorICAgIC8vIHBvdGVudGlhbGx5IHdyb25nIGFuc3dlciB0aGUg dmVyeSBmaXJzdCB0aW1lIGl0J3MgY2FsbGVkIChzZWUKKyAgICAvLyA8aHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NDkzPikuCiAgICAgaWYgKFNldHRpbmdzOjpzaG91 bGRQYWludE5hdGl2ZUNvbnRyb2xzKCkpCiAgICAgICAgIHJldHVybiB3aW5kb3dzVGhlbWU7IC8v IGtlZXAgdGhlIHJlZmVyZW5jZSBvZiBvbmUuCiAgICAgcmV0dXJuIHNhZmFyaVRoZW1lOyAvLyBr ZWVwIHRoZSByZWZlcmVuY2Ugb2Ygb25lLgotLSAKMS42LjIuMgoK