26484 2009-06-17 10:45:55 -0700 [CHROMIUM] ASSERT_NOT_REACHED reached in Chromium font code 2009-06-25 17:10:06 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 nsylvain webkit-unassigned ojan oldest_to_newest 126487 0 nsylvain 2009-06-17 10:45:55 -0700 In the font code for chromium, we try to load font, and if it fails because of the sandbox, we ask the browser process to try to load it by calling ensureFontLoaded. If it still fails after ensureFontLoaded, we hit a ASSERT_NOT_REACHED. This case happens once in a while during browser shutdown. The browser will queue a message to the renderer to shutdown, and will then stop answering sync messages from the renderer. If the renderer is still loading a page during this time, it might try to call the browser process to ask to load a font. The browser process will ignore the request, and the font will fail to load, even after the second try. This is unfortunate, but there is no real risk here, since the renderer will be going away as soon as it processes another message. My proposal is to change FontCacheChromiumWin.cpp:291 from: ASSERT_NOT_REACHED(); to: LOG_ERROR("Unable to get the font unicode range after second attempt"); 126498 1 31426 ojan 2009-06-17 11:14:09 -0700 Created attachment 31426 Replace assert with log. 2 files changed, 26 insertions(+), 1 deletions(-) 126753 2 levin 2009-06-18 12:42:07 -0700 It looks like this was committed as http://trac.webkit.org/changeset/44770. 128316 3 nsylvain 2009-06-25 16:43:55 -0700 I'm reopening this bug since I found another instance of this in Font::drawGlyphs. I'll submit a patch for review. (with a similar code change) 128331 4 eric 2009-06-25 17:10:06 -0700 Please use a new bug. 31426 2009-06-17 11:14:09 -0700 2009-06-17 11:16:35 -0700 Replace assert with log. Replace-assert-with-log..patch text/plain 2195 ojan YWQ3NjM4MTc2MTQ5MmEzYzQzNzQwYWQ0Y2M3OTdjYzFlNWI2ZTc2ZQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NDhjMjBhLi4yMTU2OGE4 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDI4IEBACisyMDA5LTA2LTE3ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYg bG9hZGluZyBhIGZvbnQgZmFpbHMgYmVjYXVzZSBvZiB0aGUgc2FuZGJveCwgd2UgYXNrIHRoZSBi cm93c2VyIHByb2Nlc3MgdG8KKyAgICAgICAgdHJ5IHRvIGxvYWQgaXQgYnkgY2FsbGluZyBlbnN1 cmVGb250TG9hZGVkLiBJZiBpdCBzdGlsbCBmYWlscyBhZnRlcgorICAgICAgICBlbnN1cmVGb250 TG9hZGVkLCB3ZSBoaXQgYSBBU1NFUlRfTk9UX1JFQUNIRUQuCisKKyAgICAgICAgVGhpcyBjYXNl IGhhcHBlbnMgb25jZSBpbiBhIHdoaWxlIGR1cmluZyBicm93c2VyIHNodXRkb3duLiBUaGUgYnJv d3NlciB3aWxsCisgICAgICAgIHF1ZXVlIGEgbWVzc2FnZSB0byB0aGUgcmVuZGVyZXIgdG8gc2h1 dGRvd24sIGFuZCB3aWxsIHRoZW4gc3RvcCBhbnN3ZXJpbmcgc3luYworICAgICAgICBtZXNzYWdl cyBmcm9tIHRoZSByZW5kZXJlci4gSWYgdGhlIHJlbmRlcmVyIGlzIHN0aWxsIGxvYWRpbmcgYSBw YWdlIGR1cmluZyB0aGlzCisgICAgICAgIHRpbWUsIGl0IG1pZ2h0IHRyeSB0byBjYWxsIHRoZSBi cm93c2VyIHByb2Nlc3MgdG8gYXNrIHRvIGxvYWQgYSBmb250LiBUaGUKKyAgICAgICAgYnJvd3Nl ciBwcm9jZXNzIHdpbGwgaWdub3JlIHRoZSByZXF1ZXN0LCBhbmQgdGhlIGZvbnQgd2lsbCBmYWls IHRvIGxvYWQsIGV2ZW4KKyAgICAgICAgYWZ0ZXIgdGhlIHNlY29uZCB0cnkuCisKKyAgICAgICAg VGhpcyBpcyB1bmZvcnR1bmF0ZSwgYnV0IHRoZXJlIGlzIG5vIHJlYWwgcmlzayBoZXJlLCBzaW5j ZSB0aGUgcmVuZGVyZXIgd2lsbCBiZQorICAgICAgICBnb2luZyBhd2F5IGFzIHNvb24gYXMgaXQg cHJvY2Vzc2VzIGFub3RoZXIgbWVzc2FnZS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgY2FuJ3Qg YmUgbGF5b3V0IHRlc3RlZCBhcyBpdCBkZXBlbmRzIG9uIHRoZSBzYW5kYm94LgorICAgICAgICAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NDg0CisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVDaHJvbWl1bVdp bi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmb250Q29udGFpbnNDaGFyYWN0ZXIpOgorCiAyMDA5 LTA2LTE3ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYWxs IHRoZSBnZW5lcmF0ZWQgSlMqLmNwcCBmaWxlcyBiYWNrIHRvIFdlYkNvcmUudmNwcm9qCmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUNocm9t aXVtV2luLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hl Q2hyb21pdW1XaW4uY3BwCmluZGV4IGJmMWNkMmUuLjkyNTJhZTAgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlQ2hyb21pdW1XaW4uY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlQ2hyb21pdW1X aW4uY3BwCkBAIC0yODgsNyArMjg4LDcgQEAgc3RhdGljIGJvb2wgZm9udENvbnRhaW5zQ2hhcmFj dGVyKGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEqIGZvbnREYXRhLAogICAgIGlmIChjb3VudCA9PSAw ICYmIENocm9taXVtQnJpZGdlOjplbnN1cmVGb250TG9hZGVkKGhmb250KSkKICAgICAgICAgY291 bnQgPSBHZXRGb250VW5pY29kZVJhbmdlcyhoZGMsIDApOwogICAgIGlmIChjb3VudCA9PSAwKSB7 Ci0gICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBMT0dfRVJST1IoIlVuYWJs ZSB0byBnZXQgdGhlIGZvbnQgdW5pY29kZSByYW5nZSBhZnRlciBzZWNvbmQgYXR0ZW1wdCIpOwog ICAgICAgICBTZWxlY3RPYmplY3QoaGRjLCBvbGRGb250KTsKICAgICAgICAgUmVsZWFzZURDKDAs IGhkYyk7CiAgICAgICAgIHJldHVybiB0cnVlOwo=