264808 2023-11-14 05:10:24 -0800 [CMake] build-webkit script should check env var BUILD_WEBKIT_ARGS when checking if the cache should be cleaned 2023-11-23 11:25:15 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clopez clopez cgarcia webkit-bug-importer oldest_to_newest 1992433 0 clopez 2023-11-14 05:10:24 -0800 The script build-webkit caches the parameters passed to it in order to clean the CMake cache if the developer changes those from one invocation to the next one. The issue is that we support passing parameters also via the environment variable BUILD_WEBKIT_ARGS (which we use on the bots) But we are not checking the values from this env var when deciding to clean the cache or not. So it happens that if you change this environment variable with new values the CMake cache will not be clean automatically. 1992434 1 clopez 2023-11-14 05:15:21 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20477 1994571 2 ews-feeder 2023-11-23 11:24:19 -0800 Committed 271085@main (183e4e8088af): <https://commits.webkit.org/271085@main> Reviewed commits have been landed. Closing PR #20477 and removing active labels. 1994572 3 webkit-bug-importer 2023-11-23 11:25:15 -0800 <rdar://problem/118752244>