<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>264796</bug_id>
          
          <creation_ts>2023-11-13 22:50:32 -0800</creation_ts>
          <short_desc>[web-animations] interpolating keyframes should be shared in `KeyframeInterpolation`</short_desc>
          <delta_ts>2023-11-14 00:53:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Animations</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>264747</dependson>
    
    <dependson>264756</dependson>
          <blocked>250970</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Antoine Quint">graouts</reporter>
          <assigned_to name="Antoine Quint">graouts</assigned_to>
          <cc>dino</cc>
    
    <cc>graouts</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1992383</commentid>
    <comment_count>0</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-11-13 22:50:32 -0800</bug_when>
    <thetext>Currently the code to interpolate keyframes is contained within `KeyframeEffect::setAnimatedPropertiesInStyle()`. As part of the work on threaded animation resolution (see bug 250970), we will need to share this logic with `AcceleratedEffect` as well. Now that we have a shared concept of a keyframe (see bug 264747) and shared code to determine the interpolation interval (see bug 264756), we can add a method to `KeyframeInterpolation` for the purpose of interpolation and whatever virtual methods are required to support it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1992384</commentid>
    <comment_count>1</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2023-11-13 22:59:43 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/20464</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1992405</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-11-14 00:52:20 -0800</bug_when>
    <thetext>Committed 270700@main (5dfffd1d9c0c): &lt;https://commits.webkit.org/270700@main&gt;

Reviewed commits have been landed. Closing PR #20464 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1992406</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-11-14 00:53:13 -0800</bug_when>
    <thetext>&lt;rdar://problem/118380665&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>