264770 2023-11-13 13:03:42 -0800 Replaced elements avoid floats, including check boxes and radio boxes 2024-06-27 15:05:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ahmad.saleem792 webkit-unassigned akeerthi bfulgham divya karlcow ntim simon.fraser webkit-bug-importer zalan oldest_to_newest 1992239 0 ahmad.saleem792 2023-11-13 13:03:42 -0800 HI Team, While going through Blink's commit, I came across another failing test: Blink Commit: https://chromium.googlesource.com/chromium/blink/+/141235180acceb7bbdd50a315c31171dfcf55a07 Test Case: https://jsfiddle.net/baLmywgu/show ^ Fails in Firefox Nightly 121 as well. Another Test Case (from Chrome Monorail bug): https://codepen.io/chrisbank/pen/DzmVXY ^ The checkbox & radio are not same place as 'Chrome Canary 121' and Firefox Nightly 121. Just wanted to raise, so we can fix it. Thanks! 1992243 1 ahmad.saleem792 2023-11-13 13:07:25 -0800 static bool isReplacedElement(Element* element) { // Checkboxes and radioboxes are not isReplaced() nor do they have their own renderer in which to override avoidFloats(). return element && element->isElementNode() && element->isFormControlElement(); } bool RenderBox::avoidsFloats() const { return isReplacedOrInlineBlock() || isReplacedElement(element()) || isLegend() || isFieldset() || createsNewFormattingContext(); } ^ This compiles and fix the bug. 1993977 2 webkit-bug-importer 2023-11-20 13:04:14 -0800 <rdar://problem/118660695> 2005127 3 ews-feeder 2024-01-15 11:12:56 -0800 Committed 273047@main (7adc3dd2a226): <https://commits.webkit.org/273047@main> Reviewed commits have been landed. Closing PR #22762 and removing active labels. 2043476 4 ahmad.saleem792 2024-06-27 15:05:32 -0700 *** Bug 124723 has been marked as a duplicate of this bug. ***