264756 2023-11-13 11:15:20 -0800 [web-animations] determining the interpolation interval should be shared in `KeyframeInterpolation` 2023-11-13 22:50:55 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 264747 250970 264796 1 graouts graouts dino graouts webkit-bug-importer oldest_to_newest 1992177 0 graouts 2023-11-13 11:15:20 -0800 Currently the code to determine the interpolation interval, the "from" and "to" keyframes, is contained within `KeyframeEffect::setAnimatedPropertiesInStyle()`. As part of the work on threaded animation resolution (see bug 250970), we will need to share this logic with `AcceleratedEffect` as well. Now that we have a shared concept of a keyframe (see bug 264747), we can add a method to `KeyframeInterpolation` for that purpose with whatever virtual methods are required on a new share base class for `AcceleratedEffect` and `KeyframeEffect`. 1992182 1 graouts 2023-11-13 11:21:46 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20428 1992376 2 ews-feeder 2023-11-13 22:25:01 -0800 Committed 270692@main (9bafc5fbd3e0): <https://commits.webkit.org/270692@main> Reviewed commits have been landed. Closing PR #20428 and removing active labels. 1992377 3 webkit-bug-importer 2023-11-13 22:26:14 -0800 <rdar://problem/118375013>