264751 2023-11-13 10:01:20 -0800 REGRESSION(268639@main): [ macOS wk2 ] fast/frames/iframe-window-focus.html is a flaky failure 2023-11-14 16:02:54 -0800 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=262286 InRadar P2 Normal --- 1 ben_schwartz charliew charliew g_squelart webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1992148 0 ben_schwartz 2023-11-13 10:01:20 -0800 fast/frames/iframe-window-focus.html This test is consistently failing on most macOS wk2 configurations. HISTORY: https://results.webkit.org/?suite=layout-tests&test=fast%2Fframes%2Fiframe-window-focus.html&flavor=wk2&platform=mac TEXT DIFF: This tests that focusing an editable iframe's window works correctly and allows text and newlines to be entered. -TEST +EST PASS DIFF URL: https://build.webkit.org/results/Apple-Sonoma-Release-WK2-Tests/270636%40main%20(623)/fast/frames/iframe-window-focus-pretty-diff.html REPRODUCIBILITY: I was able to reproduce this issue on macOS Sonoma (14.1, 23B74/arm64) ToT using the following command: run-webkit-tests --clobber-old-results --verbose --iterations 100 --exit-after-n-failures 1 fast/frames/iframe-window-focus.html REGRESSION: I am unable to bisect an exact regression point, as there were a string of build failures spanning the range in which we would expect it to be (268626@main - 268640@main). My best guess is that 268632@main caused the failure, as changes seem like they could be related. 1992149 1 webkit-bug-importer 2023-11-13 10:01:43 -0800 <rdar://problem/118340493> 1992154 2 ews-feeder 2023-11-13 10:10:25 -0800 Test gardening commit 270644@main (34368464f184): <https://commits.webkit.org/270644@main> Reviewed commits have been landed. Closing PR #20424 and removing active labels. 1992305 3 g_squelart 2023-11-13 15:49:38 -0800 Thank you Ben for the initial report and bisection. I was able to fix the compilation issue locally, and further bisect the regression. The regression point is actually https://commits.webkit.org/268639@main aka https://bugs.webkit.org/show_bug.cgi?id=262286 rdar://116167166 The failing test sends keyDown events, and the 268639@main patch is about key events, that seems to confirm my bisection. I'll ping the author to investigate further... 1992485 4 ben_schwartz 2023-11-14 09:45:57 -0800 Thanks Gerald! I modified the title to reflect your findings. 1992531 5 charliew 2023-11-14 11:16:52 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20496 1992594 6 ews-feeder 2023-11-14 16:02:51 -0800 Committed 270731@main (7326eec80566): <https://commits.webkit.org/270731@main> Reviewed commits have been landed. Closing PR #20496 and removing active labels.